screen: restore newline character
It was removed in commit 389a1ad8:
- fprintf(stderr, _("Error: Screen to small\n"));
+ fprintf(stderr, "%s", _("Error: Screen too small"));
exit(EXIT_FAILURE);
It was removed in commit 389a1ad8:
- fprintf(stderr, _("Error: Screen to small\n"));
+ fprintf(stderr, "%s", _("Error: Screen too small"));
exit(EXIT_FAILURE);
mpdclient: handle mpd_send_add's return value
configure.ac: add missing AC_MSG_RESULT
mpdclient_connect: fix parenthesis style
screen_outputs.c: fix indentation
title_bar.c: include config.h directly
options: remove double-semicolon
NEWS: screen_queue: follow songs being moved
Done in commit d71be00d7bbd135c1cd7ec2cfe38774a8a0b373f.
Done in commit d71be00d7bbd135c1cd7ec2cfe38774a8a0b373f.
convert NEWS to UTF-8
resolve.c: Only include netdb.h when not on WIN32
screen.c: re-enable the leaveok optimization
Of course only if we don't need the cursor.
Of course only if we don't need the cursor.
screen_lyrics: fix lyrics_title on small screens
It turns out snprintf returns the length of the resulting string, not
the actual number of bytes copied into the buffer, e.g. the following
call will return 33, and not 7 (or 8):
snprintf(buffer, 8, "this string is 33 characters long");
This patch also adds empty lines around the code dealing with the
plugin name to help readabiliy.
It turns out snprintf returns the length of the resulting string, not
the actual number of bytes copied into the buffer, e.g. the following
call will return 33, and not 7 (or 8):
snprintf(buffer, 8, "this string is 33 characters long");
This patch also adds empty lines around the code dealing with the
plugin name to help readabiliy.
remove unused typedef screen_functions_t
<@cirrus> legacy, I think.
<@cirrus> legacy, I think.
screen.c: don't disable CMD_SCREEN_SWAP on !OUTPUTS_SCREEN
Makefile.am: fix a typo ("smalles")
screen_queue: fix a typo: "revceived"
filelist: simplify some code
clang --analyze pointed me to this code:
src/filelist.c:146:3: warning: Value stored to 'iter' is never read
clang --analyze pointed me to this code:
src/filelist.c:146:3: warning: Value stored to 'iter' is never read
document screen_find, make it return bool
po: update Ukrainian translation
Minor grammar errors and inconsistent punctuation in the ncmpc man page
Merge branch 'regr' of git://git.musicpd.org/jn/ncmpc
screen_queue: fix CMD_LIST_MOVE_*
The code now tries to keep as much as possible of the selection being
moved visible.
The code now tries to keep as much as possible of the selection being
moved visible.
list_window: export scroll-after-cursor code
This moves the list_window_check_origin code into a new, more generic
function, which is exported.
This moves the list_window_check_origin code into a new, more generic
function, which is exported.
options: fix the --key-file help text
Revert "screen_queue: use list_window_move_cursor"
I hadn't quite understood what list_window_move_cursor does, and didn't
test the change.
This reverts commit aba25b543d7a34ce46964a7f22e495cdc3b57852.
I hadn't quite understood what list_window_move_cursor does, and didn't
test the change.
This reverts commit aba25b543d7a34ce46964a7f22e495cdc3b57852.
configure.ac: update comment "Check for glib-2.4"
main: avoid gcc warning for LOCALE && !NLS
Mark charset as G_GNUC_UNUSED if ncmpc hasn't been configured with NLS.
Mark charset as G_GNUC_UNUSED if ncmpc hasn't been configured with NLS.
doc/ncmpc.lirc: fix a typo ("ncmcp")
options: remove misleading MAX_LONGOPT_LENGTH
list_window: "if ( x)" -> "if (x)"
manpage: update the search-mode documentation
Merge remote branches 'jn/doc', 'jn/stuff' and 'jn/stuff1'
screen_queue: use list_window_move_cursor
It ensures the cursor stays visible.
It ensures the cursor stays visible.
list_window: document list_window_center
fix a typo ("connectiond")
plugin: fix plugin_callback_t documentation
screen_lyrics: clarify some code
list_window.h: "non-zero" -> "true", we use bool
command: use RET instead of 13 for '\r'
command: use KEY_CTL
And add the convenience macro C().
And add the convenience macro C().
command: add macro KEY_CTL()
I copied it from tig[1], which is licensed under the GPLv2+, so we
may use the code.
[1] http://jonas.nitro.dk/tig/
I copied it from tig[1], which is licensed under the GPLv2+, so we
may use the code.
[1] http://jonas.nitro.dk/tig/
command: white space cosmetics
Restore the old idention style of the key code macros, it was
destoyed by commit f81333d (code style, indent with tabs XI).
(That's a long time ago, I know.)
Restore the old idention style of the key code macros, it was
destoyed by commit f81333d (code style, indent with tabs XI).
(That's a long time ago, I know.)
screen_artist: document add_query (some more)
screen_artist: don't use artist directly in add_query
screen_artist: add_query: add a "const"
screen_search: make SEARCH_ARTIST_TITLE part of an enum
conf.c: unbreak two short lines, remove parentheses
increase connection timeout to 5 seconds
1.5 seconds was not long enough for some MPD operations. The
disadvantage is that the user may have to wait up to 5 seconds without
screen updates, because ncmpc doesn't do full asynchronous I/O yet.
1.5 seconds was not long enough for some MPD operations. The
disadvantage is that the user may have to wait up to 5 seconds without
screen updates, because ncmpc doesn't do full asynchronous I/O yet.
mpdclient: pass integer timeout to mpdclient_connect()
Use milliseconds instead of float seconds. Reduces overhead.
Use milliseconds instead of float seconds. Reduces overhead.
screen_lyrics: prevent a double free/use after free
And a memory leak.
And a memory leak.
implement the "lyrics-timeout" config option
screen_lyrics: optionally show the plugin used
This feature is disabled by default, because I guess that most users
won't want to use it.
This feature is disabled by default, because I guess that most users
won't want to use it.
plugin: pass the plugin name to the callback
lyricwiki: allow ampersands in artist/song names
options.c: use a for loop in options_parse
It just looks cleaner.
It just looks cleaner.
remove the rest of the splash screen
See http://musicpd.org/mantis/view.php?id=2981
See http://musicpd.org/mantis/view.php?id=2981
ncmpc.1: document the browser color options
See http://musicpd.org/mantis/view.php?id=2924
See http://musicpd.org/mantis/view.php?id=2924
Modify version string to post-release version 0.20~git
ncmpc version 0.19
po: fix format string in Polish translation
AUTHORS: add Jonathan Neuschäfer
po: add Polish translation
mpdclient: fix crash after "clear" command
mpdclient_cmd_clear() calls playlist_clear(), which leaves a freed
pointer in c->song. c->song is now cleared, too.
mpdclient_cmd_clear() calls playlist_clear(), which leaves a freed
pointer in c->song. c->song is now cleared, too.
workaround for libncurses macro warnings
screen_artist: fix variable name typo in assertion
add missing g_free in error path
cppcheck detected this little bug.
cppcheck detected this little bug.
po: update German translation
po: update Esperanto translation
po: update Chinese translation
po: update Galician translation
po: update Finnish translation
po: update Czech translation
po: regenerate ncmpc.pot
main: *settings_name: translate "unknown"
main: don't show (null) as the server name
With libmpdclient older than version 2.4.0, connection_settings_name()
will return g_strdup(options.host), but options.host can be NULL.
Return g_strdup("localhost") in that case, assuming localhost is
mpd_connection_new's "default host".
With libmpdclient older than version 2.4.0, connection_settings_name()
will return g_strdup(options.host), but options.host can be NULL.
Return g_strdup("localhost") in that case, assuming localhost is
mpd_connection_new's "default host".
use glib regex for list_window_jump.
Compile a single regex search string in list_window_jump instead of
using g_regex_match which compiles a new one each time.
Compile a single regex search string in list_window_jump instead of
using g_regex_match which compiles a new one each time.
main.c: fix compiler warning
src/main.c: In function ‘idle_callback’:
src/main.c:385:25: error: variable ‘connection’ set but not used [-Werror=unused-but-set-variable]
src/main.c: In function ‘idle_callback’:
src/main.c:385:25: error: variable ‘connection’ set but not used [-Werror=unused-but-set-variable]
screen_find.c: fix backspace bug
Use ncurses macros instead of magic numbers.
Use ncurses macros instead of magic numbers.
mpdclient.h: fix the spelling of "occurred"
13 years agofix malloc/free deadlock in signal handler by implementing a signaling pipe for sigco...
fix malloc/free deadlock in signal handler by implementing a signaling pipe for sigcont and sigwinch signal handlers
po: regenerate ncmpc.pot
Just line number changes.
Just line number changes.
po: 2 minor fixups for Russian
po: update Brazilian Portuguese translation
po: update Italian translation
po: update Galician translation
po: update French translation
po: update Spanish translation
po: update Esperanto translation
po: update German translation
po: update Czech translation
po: update Russian translation
main: show real server address in status message
Use the new mpd_settings object to determine the real server host
(libmpdclient 2.4).
Use the new mpd_settings object to determine the real server host
(libmpdclient 2.4).
configure.ac: require libmpdclient 2.2
We need a sane LIBMPDCLIENT_CHECK_VERSION macro.
We need a sane LIBMPDCLIENT_CHECK_VERSION macro.
Modify version string to post-release version 0.19~git
ncmpc version 0.18
po: regenerate ncmpc.pot
an i18n fix
screen_artist: respect artist when adding albums
po: update Brazilian Portuguese translation
po: update Hungarian translation