screen_artist: respect artist when adding albums
po: update Brazilian Portuguese translation
po: update Hungarian translation
po: update Hebrew translation
doc: Updated manpage.
Added -m/-M options; fixed -S/--no-splash option.
As reported by Martin Hradil in Debian bug #589660.
Added -m/-M options; fixed -S/--no-splash option.
As reported by Martin Hradil in Debian bug #589660.
screen_song: show song range
screen_artist: tracks w/o album tag != all tracks
The `album' variable used to store a pointer to an empty string, which was
somewhere in memory, for the virtual album `All tracks', but this didn't allow
seeing all tracks without an album tag as one album.
Now, the address of the char array `ALL_TRACKS' is assigned to `album', when
`All Tracks' are viewed.
The `album' variable used to store a pointer to an empty string, which was
somewhere in memory, for the virtual album `All tracks', but this didn't allow
seeing all tracks without an album tag as one album.
Now, the address of the char array `ALL_TRACKS' is assigned to `album', when
`All Tracks' are viewed.
options.c: Read mpd host from environment if not specified.
This fixes the "Connecting to localhost" message if "MPD_HOST=mpd ncmpc" is used.
This fixes the "Connecting to localhost" message if "MPD_HOST=mpd ncmpc" is used.
lyrics/leoslyrics: don't print backtrace on HTTP failure
po: update German translation
po: update Norwegian Bokmal translation
screen_help: remove CMD_SCREEN_SONG if song screen is disabled
This fixes a NULL pointer dereference, caused by
get_key_names(CMD_SCREEN_SONG)==NULL.
This fixes a NULL pointer dereference, caused by
get_key_names(CMD_SCREEN_SONG)==NULL.
Makefile.am: add GLIB_LIBS to _LDADD
Adding GLIB_LIBS to _LDFLAGS instead of _LDADD lead to build error
when using -Wl,--as-needed.
Adding GLIB_LIBS to _LDFLAGS instead of _LDADD lead to build error
when using -Wl,--as-needed.
po: update Spanish translation
po: added Italian translation
po: update Galician translation
Modify version string to post-release version 0.18~git
ncmpc version 0.17
po: updated Swedish translation
po: updated Slovak translation
po: added Finnish translation
po: updated Czech translation
po: regenerate ncmpc.pot
20-lyricwiki.rb: recode recieved lyrics
The lyrics are recieved in Latin1, but UTF-8 is needed.
The lyrics are recieved in Latin1, but UTF-8 is needed.
screen_browser: check for error before adding song to playlist
The function enqueue_and_play() may cause an assertion failure,
because it evaluates the filelist_entry object after
mpdclient_get_connection() call. However, mpdclient_get_connection() may
indirectly invalidate the filelist_entry object, when it sees that the
connection has become invalid; it will return a NULL connection then.
This results in an assertion failure or a segmentation fault.
The function enqueue_and_play() may cause an assertion failure,
because it evaluates the filelist_entry object after
mpdclient_get_connection() call. However, mpdclient_get_connection() may
indirectly invalidate the filelist_entry object, when it sees that the
connection has become invalid; it will return a NULL connection then.
This results in an assertion failure or a segmentation fault.
configure.ac: disable -Wdeclaration-after-statement
ncmpc requires a C99 compliant compiler, so let's allow this C99
extension, too.
ncmpc requires a C99 compliant compiler, so let's allow this C99
extension, too.
screen_lyrics: handle the spacebar
screen_help says that the lyrics can be reloaded using the spacebar
(CMD_SELECT). This patch implements the documented behavior.
screen_help says that the lyrics can be reloaded using the spacebar
(CMD_SELECT). This patch implements the documented behavior.
screen_lyrics: some cleanup
screen_queue: fix range selection check on "shuffle"
When list_window_get_range() was changed to become more robust, its
return value changed when no range was selected. This patch makes
CMD_SHUFFLE assume that range selection is disabled when only one song
is selected, and shuffling one song doesn't make sense anyway.
When list_window_get_range() was changed to become more robust, its
return value changed when no range was selected. This patch makes
CMD_SHUFFLE assume that range selection is disabled when only one song
is selected, and shuffling one song doesn't make sense anyway.
po: updated Dutch translation
Make delete_lyr_hd usable
screen_lyrics.c: Add function delete_lyr_hd
screen_lyrics.c: wrapped some duplicate code
po: updated Galician translation
po: added Brazilian Portuguese translation
screen_find: strip prompt from search string
The jump prompt was left at the start of the search string. This
patch removes this.
The jump prompt was left at the start of the search string. This
patch removes this.
screen_find: fix garbage control chars in search string
Went a control key was pressed it would exit, but still append some
garbage to the end of the search string. This meant that the find
next/previous command didn't work. This patch moves the loop
condition to after getting the key input.
Went a control key was pressed it would exit, but still append some
garbage to the end of the search string. This meant that the find
next/previous command didn't work. This patch moves the loop
condition to after getting the key input.
Modify version string to post-release version 0.17~git
ncmpc version 0.16.1
screen_browser: fixed jump to playlist file
Don't add asterisks around the playlist file name in
browser_lw_callback(). This was useless since we are using the
list_window paint callback, and the formatted playlist name isn't used
anymore for painting.
Don't add asterisks around the playlist file name in
browser_lw_callback(). This was useless since we are using the
list_window paint callback, and the formatted playlist name isn't used
anymore for painting.
po: updated Russian translation
Merge branch 'master' of git://git.musicpd.org/avuton/ncmpc
Update copyright notices
screen_song: make the "labels" array static
Don't reinitialize the whole list each time the screen is opened.
Don't reinitialize the whole list each time the screen is opened.
screen_queue: always update the list size
This fixes an assertion failure.
This fixes an assertion failure.
list_window: check for unchanged value in set_length()
Minor optimization.
Minor optimization.
doc/ncmpc.1: fixed some typos
include "config.h" in all files using HAVE_* defines
Modify version string to post-release version 0.17~git
ncmpc version 0.16
updated the AUTHORS file
po: regenerated ncmpc.pot
Only line number changes.
Only line number changes.
po: added Esperanto translation
Anonymous Launchpad contribution.
Anonymous Launchpad contribution.
po: updated German translation
Anonymous Launchpad contribution.
Anonymous Launchpad contribution.
screen_artist: return strings without square brackets
This fixes the "jump" regression.
This fixes the "jump" regression.
screen_artist: use a list_window paint callback
The goal is to remove the square brackets from the old list_window
callback.
The goal is to remove the square brackets from the old list_window
callback.
screen_artist: don't convert _() to locale
gettext returns all strings in the locale charset.
gettext returns all strings in the locale charset.
screen_browser: export screen_browser_paint_directory()
Makefile.am: fixed include path for test/run_hscroll
Use $(srcdir) to support out-of-tree builds.
Use $(srcdir) to support out-of-tree builds.
compatibility fixes for GLib 2.12
At the same time, raise the minimum required GLib version to 2.12,
because I don't have older versions to test with.
At the same time, raise the minimum required GLib version to 2.12,
because I don't have older versions to test with.
screen_browser: explicitly initialize local variable
Make gcc happy.
Make gcc happy.
screen_queue: simplified screen_readln() call in MINI
Fix compiling with --disable-locale
locale_width() was previously broken when trying to compile ncmpc
without locale support. This was due to stale code in an #if block.
Signed-off-by: Thomas Adam <thomas.adam22@gmail.com>
locale_width() was previously broken when trying to compile ncmpc
without locale support. This was due to stale code in an #if block.
Signed-off-by: Thomas Adam <thomas.adam22@gmail.com>
colors: Change config to use attribute list
Colors can now be specified with a comma separated list of attributes,
for example: `blue,bold,underline'.
Putting multiple colors in the list is probably a bad idea..
Existing `bright' colors should be converted to bold colors.
e.g. brightblue => blue,bold
Colors can now be specified with a comma separated list of attributes,
for example: `blue,bold,underline'.
Putting multiple colors in the list is probably a bad idea..
Existing `bright' colors should be converted to bold colors.
e.g. brightblue => blue,bold
colors: Clean up color handling code using curses.h
Using attr_t lets us remove some unnecessary code, such as
COLOR_BRIGHT_MASK which is now just A_BOLD. We can also add in other
style properties, such as underline, easier as well.
Also moved the background color to the color table, there's no reason to
special case it.
Using attr_t lets us remove some unnecessary code, such as
COLOR_BRIGHT_MASK which is now just A_BOLD. We can also add in other
style properties, such as underline, easier as well.
Also moved the background color to the color table, there's no reason to
special case it.
colors: Allow using 256 colors
Return the corresponding value when integers are passed to str2color. This
allows high colors to be used with 256 color terminals. Bright colors can be
used by adding 256 to integer.
COLOR_BRIGHT_MASK changed to avoid conflicts with >127 colors.
Return the corresponding value when integers are passed to str2color. This
allows high colors to be used with 256 color terminals. Bright colors can be
used by adding 256 to integer.
COLOR_BRIGHT_MASK changed to avoid conflicts with >127 colors.
leoslyrics.sh plugin: Add bash leoslyrics plugin
Simple version of the Leo's Lyrics plugin that uses bash and wget.
This also caches the lyrics in ~/.lyrics so that they are later retrieved by
the hd.sh plugin.
Simple version of the Leo's Lyrics plugin that uses bash and wget.
This also caches the lyrics in ~/.lyrics so that they are later retrieved by
the hd.sh plugin.
lyrics plugins: Change numbering scheme
Rename lyrics plugins to x0-plugin instead of 0x-plugin to allow additional
plugins to be added between provided plugins.
Rename lyrics plugins to x0-plugin instead of 0x-plugin to allow additional
plugins to be added between provided plugins.
colors: work around "value computed is not used" warning
Cast wattrset() to void.
Cast wattrset() to void.
added option "second-column"
This allows the second column displaying the song length to be
disabled using the config file. By default it is set to on, so it
shouldn't affect anyone unless they specify it.
This allows the second column displaying the song length to be
disabled using the config file. By default it is set to on, so it
shouldn't affect anyone unless they specify it.
charset: added support for zero-width characters
Consider zero-length characters in utf8_width().
Consider zero-length characters in utf8_width().
charset: moved code to unicode_char_width()
mpdclient: allow song id 0
Off-by-one bug. Change ">" to ">=".
Off-by-one bug. Change ">" to ">=".
status_bar: display elapsed time event when total time is unknown
This is useful for streams: how long have we been playing this stream?
This is useful for streams: how long have we been playing this stream?
status_bar: fix display_remaining_time while seeking
If the display_remaining_time option is enabled, apply this setting
even during seeking.
If the display_remaining_time option is enabled, apply this setting
even during seeking.
status_bar: moved variable "bitrate" inside closure
status_bar: moved code to format_bitrate()
screen_outputs: set list_window length to 0 if not connected
The "length" wasn't set properly because we commented out the
according line from clear_outputs_list().
The "length" wasn't set properly because we commented out the
according line from clear_outputs_list().
update screens after being disconnected from server
Signed-off-by: Romain Bignon <romain@peerfuse.org>
Signed-off-by: Romain Bignon <romain@peerfuse.org>
use MPD_IDLE_QUEUE instead of deprecated MPD_IDLE_PLAYLIST flag
Signed-off-by: Romain Bignon <romain@peerfuse.org>
Signed-off-by: Romain Bignon <romain@peerfuse.org>
screen_song: store list items in the locale charset
Pre-convert the strings, instead of converting on demand.
Pre-convert the strings, instead of converting on demand.
charset: added function locale_width()
This function is a rather expensive wrapper: it converts the string to
UTF-8 and calls utf8_width().
This function is a rather expensive wrapper: it converts the string to
UTF-8 and calls utf8_width().
screen_song: properly implement line breaks
The old code didn't consider wide characters. This patch uses
utf8_cut_width() to break lines.
The old code didn't consider wide characters. This patch uses
utf8_cut_width() to break lines.
screen_song: fill spaces with memset()
Faster than a manual "for" loop.
Faster than a manual "for" loop.
screen_song: don't allow screen_song_append(NULL)
All callers make sure that value!=NULL.
All callers make sure that value!=NULL.
player_command: implement setup_seek() without a song object
Get the current song id from mpd_status_get_song_id().
Get the current song id from mpd_status_get_song_id().
player_command: merged code into setup_seek()
player_command: break from switch if not playing
Eliminate one indent level.
Eliminate one indent level.
screen_queue: update current song in method open()
When the queue screen is not open, and the song changes, it was not
updated, not even if you switch back and press Ctrl-L.
This patch moves some common code to screen_queue_song_change(), which
is also called by the open() method.
When the queue screen is not open, and the song changes, it was not
updated, not even if you switch back and press Ctrl-L.
This patch moves some common code to screen_queue_song_change(), which
is also called by the open() method.
screen_queue: use mpd_status.song_pos for centering the list
Don't look up the playlist. Just use the position provided by MPD.
Side effect: we can pass the mpd_status object to
center_playing_item(), not the whole mpdclient object.
Don't look up the playlist. Just use the position provided by MPD.
Side effect: we can pass the mpd_status object to
center_playing_item(), not the whole mpdclient object.
screen_queue: eliminated length check in center()
list_window_center() does all the checks fine. Don't duplicate that.
list_window_center() does all the checks fine. Don't duplicate that.
screen_queue: eliminated unused variable "song"
Not used in center_playing_item().
Not used in center_playing_item().
mpdclient: added inline function mpdclient_is_playing()
lyricwiki: convert numeric HTML escape sequences to proper characters
I've stumbled across several cases of obfuscated lyrics that use the numeric
HTML escape sequences.
I've stumbled across several cases of obfuscated lyrics that use the numeric
HTML escape sequences.
po: regenerated ncmpc.pot and *.po
A lot of code has been moved around.
A lot of code has been moved around.
po: updated POTFILES.in
There are several new source files, and screen_play.c has been renamed
to screen_queue.c.
There are several new source files, and screen_play.c has been renamed
to screen_queue.c.
screen_search: revert label to "Filename"
po: updated Spanish translation
screen_outputs: preserve cursor position after update
Don't clear the list_window in clear_outputs_list().
Don't clear the list_window in clear_outputs_list().
command, conf: simplify variable initialization