object: Assert that object's are not free'd multiple times.

Else, we'd access free'd memory when trying to do so.

diff --git a/src/core/object.c b/src/core/object.c
index 9101918654379a1ff41491df64187d399468d186..c39faf4aed2c89f684a3e2c0c947b0eba7fe2d18 100644 (file)
--- a/src/core/object.c
+++ b/src/core/object.c
@@ -149,6 +149,9 @@ sdb_object_deref(sdb_object_t *obj)
        if (obj->ref_cnt > 0)
                return;
 
+       /* we'd access free'd memory in case ref_cnt < 0 */
+       assert(! obj->ref_cnt);
+
        if (obj->type.destroy)
                obj->type.destroy(obj);
 

diff --git a/t/unit/core/object_test.c b/t/unit/core/object_test.c
index dec6d41c73a3f989e97fcd85c79e4a950908ab79..73d7c86e1f1b21c18de0746ec250132df1001706 100644 (file)
--- a/t/unit/core/object_test.c
+++ b/t/unit/core/object_test.c
@@ -275,8 +275,7 @@ START_TEST(test_obj_ref)
                        "%d time%s; expected: 0", destroy_noop_called == 1 ? "" : "2",
                        destroy_noop_called);
 
-       /* test_obj_create already checks the ref_cnt == 1 case */
-       obj->ref_cnt = 0;
+       obj->ref_cnt = 1;
        sdb_object_deref(obj);
        fail_unless(init_noop_called == 1,
                        "after some sdb_object_{de,}ref(); object's init called %d times; "