store: Don't update unchanged attribute values.

When handling dynamically allocated data, this would generate unnecessary
memory churn.

diff --git a/src/core/store.c b/src/core/store.c
index 7de75b1ee546e6a49509746fa0a13410834ba779..1c04a77cb6a6c1ce252380211ee8bdb9de188309 100644 (file)
--- a/src/core/store.c
+++ b/src/core/store.c
@@ -327,6 +327,10 @@ store_attr(sdb_llist_t *attributes, const char *key, const sdb_data_t *value,
        if (status)
                return status;
 
        if (status)
                return status;
 

+       /* don't update unchanged values */
+       if (! sdb_data_cmp(&ATTR(attr)->value, value))
+               return status;
+

        assert(attr);
        if (sdb_data_copy(&ATTR(attr)->value, value))
                return -1;
        assert(attr);
        if (sdb_data_copy(&ATTR(attr)->value, value))
                return -1;