Code

sysdb: Wait for remaining data after the mainloop terminates.
[sysdb.git] / src / tools / sysdb / main.c
index 8455a6c7000e4856483b8650ce02a932c0fa98a2..fc226f965f991ec65f4cc4bbfa5b61f7ba318e57 100644 (file)
@@ -184,7 +184,6 @@ execute_commands(sdb_client_t *client, sdb_llist_t *commands)
 
        while (sdb_llist_iter_has_next(iter)) {
                sdb_object_t *obj = sdb_llist_iter_get_next(iter);
-               int err;
 
                if (sdb_client_send(client, CONNECTION_QUERY,
                                        (uint32_t)strlen(obj->name), obj->name) <= 0) {
@@ -193,13 +192,23 @@ execute_commands(sdb_client_t *client, sdb_llist_t *commands)
                        status = 1;
                        break;
                }
-               err = sdb_command_print_reply(client);
-               if (err) {
-                       if (err < 0)
+
+               /* Wait for server replies. We might get any number of log messages
+                * but eventually see the reply to the query, which is either OK or
+                * ERROR. */
+               while (42) {
+                       status = sdb_command_print_reply(client);
+                       if (status < 0) {
                                sdb_log(SDB_LOG_ERR, "Failed to read reply from server");
-                       status = 1;
-                       break;
+                               break;
+                       }
+
+                       if ((status == CONNECTION_OK) || (status == CONNECTION_ERROR))
+                               break;
                }
+
+               if (status)
+                       break;
        }
 
        sdb_llist_iter_destroy(iter);
@@ -297,7 +306,8 @@ main(int argc, char **argv)
        }
 
        sdb_log(SDB_LOG_INFO, "SysDB client "SDB_CLIENT_VERSION_STRING
-                       SDB_CLIENT_VERSION_EXTRA"\n");
+                       SDB_CLIENT_VERSION_EXTRA" (libsysdbclient %s%s)\n",
+                       sdb_client_version_string(), sdb_client_version_extra());
 
        using_history();
 
@@ -318,6 +328,12 @@ main(int argc, char **argv)
        sdb_input_init(&input);
        sdb_input_mainloop();
 
+       sdb_client_shutdown(input.client, SHUT_WR);
+       while (! sdb_client_eof(input.client)) {
+               /* wait for remaining data to arrive */
+               sdb_command_print_reply(input.client);
+       }
+
        if (hist_file[0] != '\0') {
                errno = 0;
                if (write_history(hist_file)) {