frontend, proto: Include the response data type in query replies.

[sysdb.git] / src / tools / sysdb / main.c

diff --git a/src/tools/sysdb/main.c b/src/tools/sysdb/main.c
index 991e1ffb6d8e744252309646f4741e67abfe901d..331cfa25e640912ac79ac6b37c44d3a91f374323 100644 (file)
--- a/src/tools/sysdb/main.c
+++ b/src/tools/sysdb/main.c
@@ -184,6 +184,7 @@ execute_commands(sdb_client_t *client, sdb_llist_t *commands)
 
        while (sdb_llist_iter_has_next(iter)) {
                sdb_object_t *obj = sdb_llist_iter_get_next(iter);
+
                if (sdb_client_send(client, CONNECTION_QUERY,
                                        (uint32_t)strlen(obj->name), obj->name) <= 0) {
                        sdb_log(SDB_LOG_ERR, "Failed to send command '%s' to server",
@@ -191,11 +192,30 @@ execute_commands(sdb_client_t *client, sdb_llist_t *commands)
                        status = 1;
                        break;
                }
-               if (sdb_command_print_reply(client)) {
-                       sdb_log(SDB_LOG_ERR, "Failed to read reply from server");
-                       status = 1;
-                       break;
+
+               /* Wait for server replies. We might get any number of log messages
+                * but eventually see the reply to the query, which is either DATA or
+                * ERROR. */
+               while (42) {
+                       status = sdb_command_print_reply(client);
+                       if (status < 0) {
+                               sdb_log(SDB_LOG_ERR, "Failed to read reply from server");
+                               break;
+                       }
+
+                       if ((status == CONNECTION_DATA) || (status == CONNECTION_ERROR))
+                               break;
+                       if (status == CONNECTION_OK) {
+                               /* pre 0.4 versions used OK instead of DATA */
+                               sdb_log(SDB_LOG_WARNING, "Received unexpected OK status from "
+                                               "server in response to a QUERY (expected DATA); "
+                                               "assuming we're talking to an old server");
+                               break;
+                       }
                }
+
+               if ((status != CONNECTION_OK) && (status != CONNECTION_DATA))
+                       break; /* error */
        }
 
        sdb_llist_iter_destroy(iter);
@@ -289,11 +309,14 @@ main(int argc, char **argv)
                int status = execute_commands(input.client, commands);
                sdb_llist_destroy(commands);
                sdb_client_destroy(input.client);
-               exit(status);
+               if ((status != CONNECTION_OK) && (status != CONNECTION_DATA))
+                       exit(1);
+               exit(0);
        }
 
        sdb_log(SDB_LOG_INFO, "SysDB client "SDB_CLIENT_VERSION_STRING
-                       SDB_CLIENT_VERSION_EXTRA"\n");
+                       SDB_CLIENT_VERSION_EXTRA" (libsysdbclient %s%s)\n",
+                       sdb_client_version_string(), sdb_client_version_extra());
 
        using_history();
 
@@ -314,6 +337,12 @@ main(int argc, char **argv)
        sdb_input_init(&input);
        sdb_input_mainloop();
 
+       sdb_client_shutdown(input.client, SHUT_WR);
+       while (! sdb_client_eof(input.client)) {
+               /* wait for remaining data to arrive */
+               sdb_command_print_reply(input.client);
+       }
+
        if (hist_file[0] != '\0') {
                errno = 0;
                if (write_history(hist_file)) {