frontend, sysdb: Correctly handle empty queries.

[sysdb.git] / src / tools / sysdb / command.c

diff --git a/src/tools/sysdb/command.c b/src/tools/sysdb/command.c
index be41b15f9d92557588df6b9fefc326a261a80844..81f679233d969ccb203f5f938c07e6d5f98fd693 100644 (file)
--- a/src/tools/sysdb/command.c
+++ b/src/tools/sysdb/command.c
@@ -29,19 +29,68 @@
 #      include "config.h"
 #endif /* HAVE_CONFIG_H */
 
+#include "sysdb.h"
+
 #include "tools/sysdb/command.h"
 #include "tools/sysdb/input.h"
 
 #include "frontend/proto.h"
 #include "utils/error.h"
+#include "utils/proto.h"
 #include "utils/strbuf.h"
 
 #include <errno.h>
 
 #include <assert.h>
 #include <ctype.h>
+#include <stdlib.h>
 #include <string.h>
 
+static void
+log_printer(sdb_strbuf_t *buf)
+{
+       uint32_t prio = sdb_proto_get_int(buf, 0);
+
+       if (prio == UINT32_MAX) {
+               printf("ERROR: Received a LOG message with invalid "
+                               "or missing priority\n");
+               return;
+       }
+       sdb_strbuf_skip(buf, 0, sizeof(prio));
+
+       printf("%s: %s\n", SDB_LOG_PRIO_TO_STRING((int)prio),
+                       sdb_strbuf_string(buf));
+} /* log_printer */
+
+static void
+data_printer(sdb_strbuf_t *buf)
+{
+       size_t len = sdb_strbuf_len(buf);
+
+       if ((! len) || (len == sizeof(uint32_t))) {
+               /* empty command or empty reply */
+               return;
+       }
+       else if (len < sizeof(uint32_t)) {
+               printf("ERROR: Received a DATA message with invalid "
+                               "or missing data-type\n");
+               return;
+       }
+
+       /* At the moment, we don't care about the result type. We simply print the
+        * result without further parsing it. */
+       sdb_strbuf_skip(buf, 0, sizeof(uint32_t));
+       printf("%s\n", sdb_strbuf_string(buf));
+} /* data_printer */
+
+static struct {
+       int status;
+       void (*printer)(sdb_strbuf_t *);
+} response_printers[] = {
+       { CONNECTION_LOG,  log_printer },
+       { CONNECTION_DATA, data_printer },
+};
+
 /*
  * public API
  */
@@ -52,7 +101,9 @@ sdb_command_print_reply(sdb_client_t *client)
        sdb_strbuf_t *recv_buf;
        const char *result;
        uint32_t rcode = 0;
+
        int status = 0;
+       size_t i;
 
        recv_buf = sdb_strbuf_create(1024);
        if (! recv_buf)
@@ -61,8 +112,10 @@ sdb_command_print_reply(sdb_client_t *client)
        if (sdb_client_recv(client, &rcode, recv_buf) < 0)
                rcode = UINT32_MAX;
 
-       if (sdb_client_eof(client))
+       if (sdb_client_eof(client)) {
+               sdb_strbuf_destroy(recv_buf);
                return -1;
+       }
 
        if (rcode == UINT32_MAX) {
                printf("ERROR: ");
@@ -71,6 +124,14 @@ sdb_command_print_reply(sdb_client_t *client)
        else
                status = (int)rcode;
 
+       for (i = 0; i < SDB_STATIC_ARRAY_LEN(response_printers); ++i) {
+               if (status == response_printers[i].status) {
+                       response_printers[i].printer(recv_buf);
+                       sdb_strbuf_destroy(recv_buf);
+                       return status;
+               }
+       }
+
        result = sdb_strbuf_string(recv_buf);
        if (result && *result)
                printf("%s\n", result);
@@ -115,8 +176,11 @@ sdb_command_exec(sdb_input_t *input)
                 * sends back. We'll wait for the first reply and then return to the
                 * main loop which will handle any subsequent replies, including
                 * eventually the reply to the query (if it's not the first reply). */
-               if (sdb_command_print_reply(input->client) < 0)
+               if (sdb_command_print_reply(input->client) < 0) {
+                       if (data)
+                               free(data);
                        return NULL;
+               }
        }
 
        sdb_strbuf_skip(input->input, 0, input->query_len);