![[tokkee]](http://tokkee.org/images/avatar.png){kind=avatar}
diff --git a/src/frontend/grammar.y b/src/frontend/grammar.y
index 97be55d0c7dfa5b397fade235888bafe4f505a27..3180167fe2d98256637078338be98baf1e5368f8 100644 (file)
--- a/src/frontend/grammar.y
+++ b/src/frontend/grammar.y
void
sdb_fe_yyerror(YYLTYPE *lval, sdb_fe_yyscan_t scanner, const char *msg);
+void
+sdb_fe_yyerrorf(YYLTYPE *lval, sdb_fe_yyscan_t scanner, const char *fmt, ...);
/* quick access to the current parse tree */
#define pt sdb_fe_yyget_extra(scanner)->parsetree
/* quick access to the parser mode */
#define parser_mode sdb_fe_yyget_extra(scanner)->mode
+/* quick access to the parser's error buffer */
+#define errbuf sdb_fe_yyget_extra(scanner)->errbuf
+
#define MODE_TO_STRING(m) \
(((m) == SDB_PARSE_DEFAULT) ? "statement" \
: ((m) == SDB_PARSE_COND) ? "condition" \
{
/* only accepted in default parse mode */
if (parser_mode != SDB_PARSE_DEFAULT) {
- char errmsg[1024];
- snprintf(errmsg, sizeof(errmsg),
+ sdb_fe_yyerrorf(&yylloc, scanner,
YY_("syntax error, unexpected statement, "
"expecting %s"), MODE_TO_STRING(parser_mode));
- sdb_fe_yyerror(&yylloc, scanner, errmsg);
sdb_object_deref(SDB_OBJ($3));
YYABORT;
}
{
/* only accepted in default parse mode */
if (parser_mode != SDB_PARSE_DEFAULT) {
- char errmsg[1024];
- snprintf(errmsg, sizeof(errmsg),
+ sdb_fe_yyerrorf(&yylloc, scanner,
YY_("syntax error, unexpected statement, "
"expecting %s"), MODE_TO_STRING(parser_mode));
- sdb_fe_yyerror(&yylloc, scanner, errmsg);
sdb_object_deref(SDB_OBJ($1));
YYABORT;
}
{
/* only accepted in condition parse mode */
if (! (parser_mode & SDB_PARSE_COND)) {
- char errmsg[1024];
- snprintf(errmsg, sizeof(errmsg),
+ sdb_fe_yyerrorf(&yylloc, scanner,
YY_("syntax error, unexpected condition, "
"expecting %s"), MODE_TO_STRING(parser_mode));
- sdb_fe_yyerror(&yylloc, scanner, errmsg);
sdb_object_deref(SDB_OBJ($1));
YYABORT;
}
{
/* only accepted in expression parse mode */
if (! (parser_mode & SDB_PARSE_EXPR)) {
- char errmsg[1024];
- snprintf(errmsg, sizeof(errmsg),
+ sdb_fe_yyerrorf(&yylloc, scanner,
YY_("syntax error, unexpected expression, "
"expecting %s"), MODE_TO_STRING(parser_mode));
- sdb_fe_yyerror(&yylloc, scanner, errmsg);
sdb_object_deref(SDB_OBJ($1));
YYABORT;
}
sdb_conn_node_t *n;
n = SDB_CONN_NODE(sdb_object_create_dT(/* name = */ NULL,
conn_expr_t, conn_expr_destroy));
- n->cmd = CONNECTION_EXPR;
+ n->cmd = SDB_CONNECTION_EXPR;
CONN_EXPR(n)->expr = $1;
sdb_llist_append(pt, SDB_OBJ(n));
CONN_FETCH($$)->host = $3;
CONN_FETCH($$)->name = NULL;
CONN_FETCH($$)->filter = CONN_MATCHER($4);
- $$->cmd = CONNECTION_FETCH;
+ $$->cmd = SDB_CONNECTION_FETCH;
}
|
FETCH object_type STRING '.' STRING filter_clause
CONN_FETCH($$)->host = $3;
CONN_FETCH($$)->name = $5;
CONN_FETCH($$)->filter = CONN_MATCHER($6);
- $$->cmd = CONNECTION_FETCH;
+ $$->cmd = SDB_CONNECTION_FETCH;
}
;
conn_list_t, conn_list_destroy));
CONN_LIST($$)->type = $2;
CONN_LIST($$)->filter = CONN_MATCHER($3);
- $$->cmd = CONNECTION_LIST;
+ $$->cmd = SDB_CONNECTION_LIST;
}
;
* Returns detailed information about <type> matching condition.
*/
lookup_statement:
- LOOKUP HOSTS_T matching_clause filter_clause
+ LOOKUP object_type_plural matching_clause filter_clause
{
- /* TODO: support other types as well */
-
$$ = SDB_CONN_NODE(sdb_object_create_dT(/* name = */ NULL,
conn_lookup_t, conn_lookup_destroy));
- CONN_LOOKUP($$)->type = SDB_HOST;
+ CONN_LOOKUP($$)->type = $2;
CONN_LOOKUP($$)->matcher = CONN_MATCHER($3);
CONN_LOOKUP($$)->filter = CONN_MATCHER($4);
- $$->cmd = CONNECTION_LOOKUP;
+ $$->cmd = SDB_CONNECTION_LOOKUP;
}
;
CONN_TS($$)->metric = $4;
CONN_TS($$)->opts.start = $5;
CONN_TS($$)->opts.end = $6;
- $$->cmd = CONNECTION_TIMESERIES;
+ $$->cmd = SDB_CONNECTION_TIMESERIES;
}
;
$$ = SDB_CONN_NODE(sdb_object_create_dT(/* name = */ NULL,
conn_matcher_t, conn_matcher_destroy));
- $$->cmd = CONNECTION_MATCHER;
+ $$->cmd = SDB_CONNECTION_MATCHER;
CONN_MATCHER($$)->matcher = $1;
}
;
sdb_object_deref(SDB_OBJ($3)); $3 = NULL;
}
|
- HOST_T
- {
- /* TODO: this only works as long as queries
- * are limited to hosts */
- $$ = sdb_store_expr_fieldvalue(SDB_FIELD_NAME);
- }
- |
field
{
$$ = sdb_store_expr_fieldvalue($1);
METRIC_T { $$ = SDB_METRIC; }
|
ATTRIBUTE_T { $$ = SDB_ATTRIBUTE; }
+ |
+ BACKEND_T { $$ = SDB_FIELD_BACKEND; }
;
field:
unit = sdb_strpunit($2);
if (! unit) {
- char errmsg[strlen($2) + 32];
- snprintf(errmsg, sizeof(errmsg),
+ sdb_fe_yyerrorf(&yylloc, scanner,
YY_("invalid time unit %s"), $2);
- sdb_fe_yyerror(&yylloc, scanner, errmsg);
free($2); $2 = NULL;
YYABORT;
}
sdb_fe_yyerror(YYLTYPE *lval, sdb_fe_yyscan_t scanner, const char *msg)
{
sdb_log(SDB_LOG_ERR, "frontend: parse error: %s", msg);
+ sdb_strbuf_sprintf(errbuf, "%s", msg);
} /* sdb_fe_yyerror */
+void
+sdb_fe_yyerrorf(YYLTYPE *lval, sdb_fe_yyscan_t scanner, const char *fmt, ...)
+{
+ va_list ap, aq;
+ va_start(ap, fmt);
+ va_copy(aq, ap);
+ sdb_vlog(SDB_LOG_ERR, fmt, ap);
+ sdb_strbuf_vsprintf(errbuf, "%s", aq);
+ va_end(ap);
+} /* sdb_fe_yyerrorf */
+
static sdb_store_matcher_t *
name_iter_matcher(int m_type, int type, const char *cmp,
sdb_store_expr_t *expr)
sdb_store_matcher_t *m, *tmp = NULL;
assert(cb);
- /* TODO: this only works as long as queries
- * are limited to hosts */
+ /* hosts are never iterable */
if (type == SDB_HOST) {
return NULL;
}
- e = sdb_store_expr_fieldvalue(SDB_FIELD_NAME);
+ if (type == SDB_FIELD_BACKEND)
+ e = sdb_store_expr_fieldvalue(type);
+ else
+ e = sdb_store_expr_fieldvalue(SDB_FIELD_NAME);
m = cb(e, expr);
if (m_type == MATCHER_ANY)
tmp = sdb_store_any_matcher(type, m);