analyzer: attributes and backends are always iterable, even in filters.

[sysdb.git] / src / frontend / analyzer.c

diff --git a/src/frontend/analyzer.c b/src/frontend/analyzer.c
index c71d5ca078b5fbe9a3915013c183bb05ab6bd1f5..bef6b1d24d36f4fc55d4d01bb2ae5dfa745900c9 100644 (file)
--- a/src/frontend/analyzer.c
+++ b/src/frontend/analyzer.c
@@ -153,47 +153,50 @@ analyze_matcher(int context, int parent_type,
                case MATCHER_ANY:
                case MATCHER_ALL:
                {
-                       int type = -1;
+                       int child_context = -1;
                        int left_type = -1;
+                       int type = -1;
 
                        assert(ITER_M(m)->m);
 
-                       if (ITER_M(m)->iter->type == TYPED_EXPR) {
-                               type = (int)ITER_M(m)->iter->data.data.integer;
-                               left_type = ITER_M(m)->iter->data_type;
-                       }
-                       else if (ITER_M(m)->iter->type == FIELD_VALUE) {
-                               type = (int)ITER_M(m)->iter->data.data.integer;
-                               /* element type of the field */
-                               left_type = ITER_M(m)->iter->data_type & 0xff;
+                       if ((ITER_M(m)->iter->type == TYPED_EXPR)
+                                       || (ITER_M(m)->iter->type == FIELD_VALUE))
+                               type = ITER_M(m)->iter->data.data.integer;
+
+                       if (context == -1) { /* inside a filter */
+                               /* attributes are always iterable */
+                               if ((ITER_M(m)->iter->type == TYPED_EXPR)
+                                               && (type != SDB_ATTRIBUTE)) {
+                                       iter_error(errbuf, m->type, ITER_M(m)->iter, context);
+                                       return -1;
+                               }
+                               /* backends are always iterable */
+                               if ((ITER_M(m)->iter->type == FIELD_VALUE)
+                                               && (! (type != SDB_FIELD_BACKEND))) {
+                                       iter_error(errbuf, m->type, ITER_M(m)->iter, context);
+                                       return -1;
+                               }
                        }
-                       else {
+                       else if (! sdb_store_expr_iterable(ITER_M(m)->iter, context)) {
                                iter_error(errbuf, m->type, ITER_M(m)->iter, context);
                                return -1;
                        }
 
-                       if ((context != SDB_HOST)
-                                       && (context != SDB_SERVICE)
-                                       && (context != SDB_METRIC)) {
-                               iter_error(errbuf, m->type, ITER_M(m)->iter, context);
-                               return -1;
-                       }
-                       if (type == context) {
-                               iter_error(errbuf, m->type, ITER_M(m)->iter, context);
-                               return -1;
+                       if (ITER_M(m)->iter->type == TYPED_EXPR) {
+                               child_context = type;
+                               left_type = ITER_M(m)->iter->data_type;
                        }
-                       if ((type != SDB_SERVICE)
-                                       && (type != SDB_METRIC)
-                                       && (type != SDB_ATTRIBUTE)
-                                       && (type != SDB_FIELD_BACKEND)) {
-                               iter_error(errbuf, m->type, ITER_M(m)->iter, context);
-                               return -1;
+                       else if (ITER_M(m)->iter->type == FIELD_VALUE) {
+                               child_context = context;
+                               /* element type of the field */
+                               left_type = ITER_M(m)->iter->data_type & 0xff;
                        }
-                       if ((context == SDB_SERVICE) && (type == SDB_METRIC)) {
-                               iter_error(errbuf, m->type, ITER_M(m)->iter, context);
-                               return -1;
+                       else if (! ITER_M(m)->iter->type) {
+                               child_context = context;
+                               /* elements of the array constant */
+                               left_type = ITER_M(m)->iter->data.type & 0xff;
                        }
-                       else if ((context == SDB_METRIC) && (type == SDB_SERVICE)) {
+                       else {
                                iter_error(errbuf, m->type, ITER_M(m)->iter, context);
                                return -1;
                        }
@@ -222,7 +225,14 @@ analyze_matcher(int context, int parent_type,
                                        return -1;
                                }
                        }
-                       if (analyze_matcher(type, m->type, ITER_M(m)->m, errbuf))
+                       if (child_context <= 0) {
+                               sdb_strbuf_sprintf(errbuf, "Unable to determine the context "
+                                               "(object type) of iterator %s %s %s %s",
+                                               MATCHER_SYM(m->type), SDB_TYPE_TO_STRING(left_type),
+                                               MATCHER_SYM(ITER_M(m)->m->type),
+                                               SDB_TYPE_TO_STRING(CMP_M(ITER_M(m)->m)->right->data_type));
+                       }
+                       if (analyze_matcher(child_context, m->type, ITER_M(m)->m, errbuf))
                                return -1;
                        break;
                }
@@ -386,6 +396,11 @@ sdb_fe_analyze(sdb_conn_node_t *node, sdb_strbuf_t *errbuf)
                return -1;
        }
 
+       if (context <= 0) {
+               sdb_strbuf_sprintf(errbuf, "Unable to determine the context "
+                               "(object type) for command %#x", node->cmd);
+               return -1;
+       }
        if (analyze_matcher(context, -1, m, errbuf))
                status = -1;
        if (analyze_matcher(-1, -1, filter, errbuf))