The PostgreSQL backend quotes database names now for CREATE and DROP,

  enabling more exotic tracker names. Closes issue2550497.
  Thanks to Sebastian Harl for providing the patch.

git-svn-id: http://svn.roundup-tracker.org/svnroot/roundup/roundup/trunk@4627 57a73879-2fb5-44c3-a270-3262357dd7e2

diff --git a/CHANGES.txt b/CHANGES.txt
index 59687934a7983498d9c3a50909312a4ec76743f8..e8309ddbfb18fd6fbf341c7feaffc5302b994c75 100644 (file)
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -15,6 +15,9 @@ Features:
 
 Fixed:
 
+- The PostgreSQL backend quotes database names now for CREATE and DROP, 
+  enabling more exotic tracker names. Closes issue2550497. 
+  Thanks to Sebastian Harl for providing the patch. (Bernhard Reiter)
 - Updated the url to point to www.roundup-tracker.org in two places in the
   docs. (Bernhard Reiter)
 - Do not depend on a CPython implementation detail anymore to make Roundup 

diff --git a/roundup/backends/back_postgresql.py b/roundup/backends/back_postgresql.py
index defa905e2dfb3db5145dd63f5170bfd5d142d8d0..9a6d034a552b09fcda7a7c3e578ae02430240803 100644 (file)
--- a/roundup/backends/back_postgresql.py
+++ b/roundup/backends/back_postgresql.py
@@ -35,7 +35,7 @@ def connection_dict(config, dbnamestr=None):
 
 def db_create(config):
     """Clear all database contents and drop database itself"""
-    command = "CREATE DATABASE %s WITH ENCODING='UNICODE'"%config.RDBMS_NAME
+    command = "CREATE DATABASE \"%s\" WITH ENCODING='UNICODE'"%config.RDBMS_NAME
     if config.RDBMS_TEMPLATE :
         command = command + " TEMPLATE=%s" % config.RDBMS_TEMPLATE
     logging.getLogger('roundup.hyperdb').info(command)
@@ -43,7 +43,7 @@ def db_create(config):
 
 def db_nuke(config, fail_ok=0):
     """Clear all database contents and drop database itself"""
-    command = 'DROP DATABASE %s'% config.RDBMS_NAME
+    command = 'DROP DATABASE "%s"'% config.RDBMS_NAME
     logging.getLogger('roundup.hyperdb').info(command)
     db_command(config, command)