Fixed coredump from check_nt when drive not found (Olli Hauer - SF 2179754)

diff --git a/NEWS b/NEWS
index 9cb2a53b843070b311dfa1342b78799f52a1da22..4dad53fbedd01c0a08eabe293b5c664732edeefc 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -21,6 +21,7 @@ This file documents the major additions and syntax changes between releases.
        Fixed check_mrtg returning UNKNOWN instead of OK (bug #2378068)
        Fixed check_http behaviour: all check are now performed as long as a valid response is returned (sf.net #1460312)
        check_http --onredirect=sticky follows using the same IP address (sf.net #2550208).
+       Fixed coredump from check_nt when invalid drive is specified (#2179754 - Olli Hauer)
 
 1.4.13 25th Sept 2008
        Fix Debian bug #460097: check_http --max-age broken (Hilko Bengen)

diff --git a/THANKS.in b/THANKS.in
index eb6158afbee145d69599c6ba9449799f9411ea13..812bd372cec425f92dcd3dea03d962416a183472 100644 (file)
--- a/THANKS.in
+++ b/THANKS.in
@@ -245,3 +245,4 @@ Dieter Van de Walle
 Jan Lipphaus
 Erik Welch
 Nik Soggia
+Olli Hauer

diff --git a/plugins/check_nt.c b/plugins/check_nt.c
index 4d9157a6e4d3665967a4ca1b3fec0793da9edc89..ee5e2a63fc40918896e087d88a0852f1cce97514 100644 (file)
--- a/plugins/check_nt.c
+++ b/plugins/check_nt.c
@@ -93,6 +93,7 @@ int main(int argc, char **argv){
        char *temp_string_perf=NULL;
        char *description=NULL,*counter_unit = NULL;
        char *minval = NULL, *maxval = NULL, *errcvt = NULL;
+       char *fds=NULL, *tds=NULL;
 
        double total_disk_space=0;
        double free_disk_space=0;
@@ -214,13 +215,18 @@ int main(int argc, char **argv){
                else {
                        asprintf(&send_buffer,"%s&4&%s", req_password, value_list);
                        fetch_data (server_address, server_port, send_buffer);
-                       free_disk_space=atof(strtok(recv_buffer,"&"));
-                       total_disk_space=atof(strtok(NULL,"&"));
-                       percent_used_space = ((total_disk_space - free_disk_space) / total_disk_space) * 100;
-                       warning_used_space = ((float)warning_value / 100) * total_disk_space;
-                       critical_used_space = ((float)critical_value / 100) * total_disk_space;
+                       fds=strtok(recv_buffer,"&");
+                       tds=strtok(NULL,"&");
+                       if(fds!=NULL)
+                               free_disk_space=atof(fds);
+                       if(tds!=NULL)
+                               total_disk_space=atof(tds);
+
+                       if (total_disk_space>0 && free_disk_space>=0) {
+                               percent_used_space = ((total_disk_space - free_disk_space) / total_disk_space) * 100;
+                               warning_used_space = ((float)warning_value / 100) * total_disk_space;
+                               critical_used_space = ((float)critical_value / 100) * total_disk_space;
 
-                       if (free_disk_space>=0) {
                                asprintf(&temp_string,_("%s:\\ - total: %.2f Gb - used: %.2f Gb (%.0f%%) - free %.2f Gb (%.0f%%)"),
                                  value_list, total_disk_space / 1073741824, (total_disk_space - free_disk_space) / 1073741824,
                                  percent_used_space, free_disk_space / 1073741824, (free_disk_space / total_disk_space)*100);
@@ -238,7 +244,7 @@ int main(int argc, char **argv){
                                output_message = strdup (temp_string);
                                perfdata = temp_string_perf;
                        } else {
-                               output_message = strdup (_("Free disk space : Invalid drive "));
+                               output_message = strdup (_("Free disk space : Invalid drive"));
                                return_code=STATE_UNKNOWN;
                        }
                }

diff --git a/plugins/tests/check_nt.t b/plugins/tests/check_nt.t
new file mode 100755 (executable)
index 0000000..d1600c7
--- /dev/null
+++ b/plugins/tests/check_nt.t
@@ -0,0 +1,77 @@
+#! /usr/bin/perl -w -I ..
+#
+# Test check_nt by having a stub check_nt daemon
+#
+
+use strict;
+use Test::More;
+use NPTest;
+use FindBin qw($Bin);
+
+use IO::Socket;
+use IO::Select;
+use POSIX;
+
+my $port = 50000 + int(rand(1000));
+
+my $pid = fork();
+if ($pid) {
+       # Parent
+       #print "parent\n";
+       # give our webserver some time to startup
+       sleep(1);
+} else {
+       # Child
+       #print "child\n";
+
+       my $server = IO::Socket::INET->new(
+               LocalPort => $port,
+               Type => SOCK_STREAM,
+               Reuse => 1,
+               Proto => "tcp",
+               Listen => 10,
+       ) or die "Cannot be a tcp server on port $port: $@";
+
+       $server->autoflush(1);
+
+       print "Please contact me at port $port\n";
+       while (my $client = $server->accept ) {
+               my $data = "";
+               my $rv = $client->recv($data, POSIX::BUFSIZ, 0);
+
+               my ($password, $command, $arg) = split('&', $data);
+               
+               if ($command eq "4") {
+                       if ($arg eq "c") {
+                               print $client "930000000&1000000000";
+                       } elsif ($arg eq "d") {
+                               print $client "UNKNOWN: Drive is not a fixed drive";
+                       }
+               }
+       }
+       exit;
+}
+
+END { if ($pid) { print "Killing $pid\n"; kill "INT", $pid } };
+
+if ($ARGV[0] && $ARGV[0] eq "-d") {
+       sleep 1000;
+}
+
+if (-x "./check_nt") {
+       plan tests => 4;
+} else {
+       plan skip_all => "No check_nt compiled";
+}
+
+my $result;
+my $command = "./check_nt -H 127.0.0.1 -p $port";
+
+$result = NPTest->testCmd( "$command -v USEDDISKSPACE -l c" );
+is( $result->return_code, 0, "USEDDISKSPACE c");
+is( $result->output, q{c:\ - total: 0.93 Gb - used: 0.07 Gb (7%) - free 0.87 Gb (93%) | 'c:\ Used Space'=0.07Gb;0.00;0.00;0.00;0.93}, "Output right" );
+
+$result = NPTest->testCmd( "$command -v USEDDISKSPACE -l d" );
+is( $result->return_code, 3, "USEDDISKSPACE d - invalid");
+is( $result->output, "Free disk space : Invalid drive", "Output right" );
+