Code

gitk: Avoid crash if closed while reading references
authorPat Thoyts <patthoyts@users.sourceforge.net>
Wed, 15 Apr 2009 16:14:03 +0000 (17:14 +0100)
committerPaul Mackerras <paulus@samba.org>
Fri, 17 Apr 2009 12:52:15 +0000 (22:52 +1000)
As recorded in msysGit issue 125, if the user closes gitk while it
reports itself as still reading references then Tk will crash in the
geometry management code.  This has been fixed for Tk 8.5.7 and above.
This patch avoids the problem by flushing outstanding geometry events
before calling the readrefs procedure.

See also http://code.google.com/p/msysgit/issues/detail?id=125

Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
Signed-off-by: Paul Mackerras <paulus@samba.org>
gitk

diff --git a/gitk b/gitk
index 488286f6a1751da8c079c83260d38787a391d603..dca1741c71254175d2161c1fd58091077f6087fd 100755 (executable)
--- a/gitk
+++ b/gitk
@@ -11128,6 +11128,7 @@ catch {
 # wait for the window to become visible
 tkwait visibility .
 wm title . "[file tail $argv0]: [file tail [pwd]]"
+update
 readrefs
 
 if {$cmdline_files ne {} || $revtreeargs ne {} || $revtreeargscmd ne {}} {