Code

ncmpc.git
10 years agofix typo in error message
Max Kellermann [Fri, 13 Dec 2013 10:18:18 +0000 (11:18 +0100)]
fix typo in error message

11 years ago*: make variables more local
Max Kellermann [Fri, 8 Nov 2013 18:52:09 +0000 (19:52 +0100)]
*: make variables more local

11 years agoconfigure.ac: require libmpdclient 2.3
Max Kellermann [Fri, 8 Nov 2013 18:49:02 +0000 (19:49 +0100)]
configure.ac: require libmpdclient 2.3

11 years ago*: use Compiler.h macros instead of glib.h
Max Kellermann [Fri, 8 Nov 2013 18:43:01 +0000 (19:43 +0100)]
*: use Compiler.h macros instead of glib.h

11 years agoconf: simplify read_configuration()
Max Kellermann [Fri, 8 Nov 2013 18:41:53 +0000 (19:41 +0100)]
conf: simplify read_configuration()

Move code to find_config_file() and find_keys_file().

11 years agoconf: convert runtime check to assertion
Max Kellermann [Fri, 8 Nov 2013 18:36:49 +0000 (19:36 +0100)]
conf: convert runtime check to assertion

11 years agoconf: eliminate local variable "match_found"
Max Kellermann [Fri, 8 Nov 2013 18:35:04 +0000 (19:35 +0100)]
conf: eliminate local variable "match_found"

11 years ago*: add "pure" attributes
Max Kellermann [Fri, 8 Nov 2013 17:14:31 +0000 (18:14 +0100)]
*: add "pure" attributes

11 years agomain: remove useless "Connected to ..." message
Max Kellermann [Fri, 8 Nov 2013 16:57:00 +0000 (17:57 +0100)]
main: remove useless "Connected to ..." message

This message has no use, because the user already knows where he asked
ncmpc to connect to.  And it was annoying, because it delays the
progress display in the status bar.

11 years agostatus_bar: export _clear_message()
Max Kellermann [Fri, 8 Nov 2013 17:04:36 +0000 (18:04 +0100)]
status_bar: export _clear_message()

11 years agomain: require MPD 0.16
Max Kellermann [Thu, 7 Nov 2013 22:36:48 +0000 (23:36 +0100)]
main: require MPD 0.16

Remove a few version checks and some fallback code.

11 years agomatch,charset: add obsolete GLib version checks
Max Kellermann [Thu, 7 Nov 2013 22:33:30 +0000 (23:33 +0100)]
match,charset: add obsolete GLib version checks

11 years agoresolver: remove unused library
Max Kellermann [Thu, 7 Nov 2013 22:27:27 +0000 (23:27 +0100)]
resolver: remove unused library

11 years agoglib_compat.h: remove obsolete header
Max Kellermann [Thu, 7 Nov 2013 22:25:20 +0000 (23:25 +0100)]
glib_compat.h: remove obsolete header

We require GLib 2.14, and the GLib 2.16 functions are not used by
ncmpc.

11 years agoconfigure.ac: enable automake silent-rules
Max Kellermann [Thu, 7 Nov 2013 22:22:43 +0000 (23:22 +0100)]
configure.ac: enable automake silent-rules

11 years agoconfigure.ac: update VERSION_MINOR
Max Kellermann [Thu, 7 Nov 2013 22:21:04 +0000 (23:21 +0100)]
configure.ac: update VERSION_MINOR

11 years agoscreen_queue: rename "playlist" to "queue"
Max Kellermann [Thu, 7 Nov 2013 22:18:45 +0000 (23:18 +0100)]
screen_queue: rename "playlist" to "queue"

"Playlists" are m3u files, and the "queue" is the current list of
songs that are about to be played by MPD.

11 years agoconfigure.ac: add more optimization flags
Max Kellermann [Thu, 7 Nov 2013 22:13:48 +0000 (23:13 +0100)]
configure.ac: add more optimization flags

11 years agoconfigure.ac: prepare for 0.22
Max Kellermann [Thu, 7 Nov 2013 22:08:41 +0000 (23:08 +0100)]
configure.ac: prepare for 0.22

11 years agorelease 0.21 release-0.21 v0.21
Max Kellermann [Thu, 11 Apr 2013 08:05:51 +0000 (10:05 +0200)]
release 0.21

11 years agoMakefile.am: remove src/win/ncmpc.rc from SOURCES
Max Kellermann [Thu, 11 Apr 2013 08:12:45 +0000 (10:12 +0200)]
Makefile.am: remove src/win/ncmpc.rc from SOURCES

11 years agopo: regenerate ncmpc.pot
Max Kellermann [Thu, 11 Apr 2013 08:12:50 +0000 (10:12 +0200)]
po: regenerate ncmpc.pot

11 years agopo/POTFILES.in: add screen_chat.c
Max Kellermann [Thu, 11 Apr 2013 08:24:23 +0000 (10:24 +0200)]
po/POTFILES.in: add screen_chat.c

11 years agopo: update Spanish translation
Adolfo Jayme Barrientos [Thu, 11 Apr 2013 08:03:42 +0000 (10:03 +0200)]
po: update Spanish translation

11 years agoconfigure.ac: require GLib 2.14
Max Kellermann [Thu, 11 Apr 2013 07:35:30 +0000 (09:35 +0200)]
configure.ac: require GLib 2.14

Required for GRegex.

11 years agostrfsong: Add fallback mpd tags for more compatibility
Jari Vetoniemi [Thu, 11 Apr 2013 07:23:17 +0000 (09:23 +0200)]
strfsong: Add fallback mpd tags for more compatibility

11 years agoscreen_lyrics: return if fork fails
Max Kellermann [Thu, 11 Apr 2013 07:30:37 +0000 (09:30 +0200)]
screen_lyrics: return if fork fails

Avoids the clang warning due to uninitialized "status".

11 years agoautogen.sh: use $AUTOMAKE_FLAGS
Max Kellermann [Thu, 11 Apr 2013 07:31:19 +0000 (09:31 +0200)]
autogen.sh: use $AUTOMAKE_FLAGS

Allows caller to pass --copy.

11 years agolyricswiki: fix Ruby 2.0 and UTF-8
Cedric Fung [Thu, 11 Apr 2013 07:11:29 +0000 (09:11 +0200)]
lyricswiki: fix Ruby 2.0 and UTF-8

12 years agoscreen_song: show song position
Valmiky Arquissandas [Tue, 14 Aug 2012 03:58:15 +0000 (04:58 +0100)]
screen_song: show song position

12 years agoscreen_queue: fix CMD_SCREEN_SWAP with an empty queue
Jonathan Neuschäfer [Fri, 10 Aug 2012 11:21:39 +0000 (13:21 +0200)]
screen_queue: fix CMD_SCREEN_SWAP with an empty queue

It crashed without this patch.

12 years agoTry to keep the cursor position when reloading lyrics
Jonathan Neuschäfer [Fri, 10 Aug 2012 11:21:39 +0000 (13:21 +0200)]
Try to keep the cursor position when reloading lyrics

12 years agompdclient.h: don't self-include
Jonathan Neuschäfer [Fri, 10 Aug 2012 11:21:38 +0000 (13:21 +0200)]
mpdclient.h: don't self-include

12 years agolist_window.h: fix a comment
Jonathan Neuschäfer [Fri, 10 Aug 2012 11:21:38 +0000 (13:21 +0200)]
list_window.h: fix a comment

12 years agoncmpc.1: remove double-spaces (" ")
Jonathan Neuschäfer [Fri, 10 Aug 2012 11:21:37 +0000 (13:21 +0200)]
ncmpc.1: remove double-spaces ("  ")

12 years agostrfsong: add %albumartist%, %composer%, and %performer%
Jonathan Neuschäfer [Fri, 10 Aug 2012 11:21:37 +0000 (13:21 +0200)]
strfsong: add %albumartist%, %composer%, and %performer%

12 years agoncmpc.1: update the list of "metadata delimiters"
Jonathan Neuschäfer [Fri, 10 Aug 2012 11:21:37 +0000 (13:21 +0200)]
ncmpc.1: update the list of "metadata delimiters"

12 years agoscreen_search: fix crash when disconnected
Max Kellermann [Wed, 1 Aug 2012 08:11:52 +0000 (10:11 +0200)]
screen_search: fix crash when disconnected

12 years agoncmpc.1: fix song format example: %file% can't fail
Jonathan Neuschäfer [Tue, 1 May 2012 21:56:33 +0000 (23:56 +0200)]
ncmpc.1: fix song format example: %file% can't fail

(And also fix the asymmetry of "%file")

12 years agostrfsong: evaluate literal text as "true"
Jonathan Neuschäfer [Tue, 12 Jun 2012 21:15:44 +0000 (23:15 +0200)]
strfsong: evaluate literal text as "true"

That is, you can now do things like this:
"[%artist%|(artist n/a)] - [%title%|(title n/a)]"

12 years agostrfsong: add a '\0' after copied chars; avoid memset
Jonathan Neuschäfer [Tue, 12 Jun 2012 21:15:44 +0000 (23:15 +0200)]
strfsong: add a '\0' after copied chars; avoid memset

12 years agoFix strfsong behaviour for unknown identifier
Lars-Dominik Braun [Tue, 12 Jun 2012 21:15:44 +0000 (23:15 +0200)]
Fix strfsong behaviour for unknown identifier

[jn: adjusted the white space style]

12 years agoncmpc.1: describe the "chat" protocol
Jonathan Neuschäfer [Tue, 12 Jun 2012 19:54:45 +0000 (21:54 +0200)]
ncmpc.1: describe the "chat" protocol

12 years agoncmpc.1: document the "chat-prefix" option
Jonathan Neuschäfer [Tue, 12 Jun 2012 19:48:12 +0000 (21:48 +0200)]
ncmpc.1: document the "chat-prefix" option

12 years agoMerge branch 'chat' of git://git.musicpd.org/jn/ncmpc
Max Kellermann [Tue, 12 Jun 2012 19:17:38 +0000 (21:17 +0200)]
Merge branch 'chat' of git://git.musicpd.org/jn/ncmpc

12 years agoscreen_chat: add an option to set the message prefix
Jonathan Neuschäfer [Wed, 23 May 2012 01:21:05 +0000 (03:21 +0200)]
screen_chat: add an option to set the message prefix

12 years agoscreen_chat: add nick name emulation
Jonathan Neuschäfer [Wed, 23 May 2012 00:51:24 +0000 (02:51 +0200)]
screen_chat: add nick name emulation

12 years agoscreen_chat: make it useful
Jonathan Neuschäfer [Wed, 4 Jan 2012 17:33:31 +0000 (18:33 +0100)]
screen_chat: make it useful

This patch adds basic functionality to the chat screen.

12 years agompdclient: add client-to-client support
Jonathan Neuschäfer [Wed, 4 Jan 2012 17:33:31 +0000 (18:33 +0100)]
mpdclient: add client-to-client support

12 years agoconfigure.ac: screen_chat needs screen_text
Jonathan Neuschäfer [Wed, 4 Jan 2012 17:33:30 +0000 (18:33 +0100)]
configure.ac: screen_chat needs screen_text

12 years agoconfigure.ac: the chat screen needs libmpdclient >= 2.5
Jonathan Neuschäfer [Wed, 4 Jan 2012 17:33:30 +0000 (18:33 +0100)]
configure.ac: the chat screen needs libmpdclient >= 2.5

12 years agoscreen_text: add support for appending text
Jonathan Neuschäfer [Wed, 4 Jan 2012 17:33:30 +0000 (18:33 +0100)]
screen_text: add support for appending text

12 years agoscreen_text: (API) use (char *) for strings
Jonathan Neuschäfer [Wed, 4 Jan 2012 17:33:30 +0000 (18:33 +0100)]
screen_text: (API) use (char *) for strings

Reduce some unneeded complexity when adding strings returned
by other libraries than glib.

12 years agostruct mpdclient: add a reconnection count
Jonathan Neuschäfer [Wed, 4 Jan 2012 17:33:29 +0000 (18:33 +0100)]
struct mpdclient: add a reconnection count

12 years agoconfigure.ac: set HAVE_WINDOWS=0 to avoid a "test" warning
Jonathan Neuschäfer [Wed, 2 May 2012 17:27:53 +0000 (19:27 +0200)]
configure.ac: set HAVE_WINDOWS=0 to avoid a "test" warning

The warning would be:
./configure: line 5033: test: -eq: unary operator expected

12 years agoadd an initial version of a chat screen
Jonathan Neuschäfer [Wed, 2 May 2012 14:57:58 +0000 (16:57 +0200)]
add an initial version of a chat screen

12 years agowin32: Add a Windows OS resource file and icon
Avuton Olrich [Sun, 19 Feb 2012 00:31:36 +0000 (16:31 -0800)]
win32: Add a Windows OS resource file and icon

12 years agoconf.c: Add windows system key binding config
Avuton Olrich [Fri, 10 Feb 2012 03:25:42 +0000 (19:25 -0800)]
conf.c: Add windows system key binding config

12 years agoconf.c: Move system key binding filename building to a function
Avuton Olrich [Fri, 10 Feb 2012 03:25:04 +0000 (19:25 -0800)]
conf.c: Move system key binding filename building to a function

12 years agoconf.c: Add windows default user key binding config check
Avuton Olrich [Fri, 10 Feb 2012 03:19:07 +0000 (19:19 -0800)]
conf.c: Add windows default user key binding config check

12 years agoconf.c: Add windows default config checking
Avuton Olrich [Fri, 10 Feb 2012 02:51:34 +0000 (18:51 -0800)]
conf.c: Add windows default config checking

12 years agoModify version string to post-release version 0.21~git
Avuton Olrich [Sun, 5 Feb 2012 19:25:25 +0000 (11:25 -0800)]
Modify version string to post-release version 0.21~git

12 years agoncmpc version 0.20 release-0.20 v0.20
Avuton Olrich [Sun, 5 Feb 2012 19:25:25 +0000 (11:25 -0800)]
ncmpc version 0.20

12 years agoconfigure.ac: Don't add CURSES_LIB to AM_CPPFLAGS
Jonathan Neuschäfer [Sat, 21 Jan 2012 23:00:06 +0000 (00:00 +0100)]
configure.ac: Don't add CURSES_LIB to AM_CPPFLAGS

12 years agoscreen_keydef: don't crash on Ctrl-Space
Jonathan Neuschäfer [Fri, 3 Feb 2012 18:44:33 +0000 (19:44 +0100)]
screen_keydef: don't crash on Ctrl-Space

12 years agocommand: don't crash on Ctrl-Space
Jonathan Neuschäfer [Fri, 3 Feb 2012 18:43:46 +0000 (19:43 +0100)]
command: don't crash on Ctrl-Space

12 years agoscreen_keydef: use inline functions instead of macros for non-constants
Jonathan Neuschäfer [Wed, 4 Jan 2012 20:08:26 +0000 (21:08 +0100)]
screen_keydef: use inline functions instead of macros for non-constants

12 years agoconf.c: return void in read_configuration
Jonathan Neuschäfer [Thu, 29 Dec 2011 13:23:06 +0000 (14:23 +0100)]
conf.c: return void in read_configuration

12 years agoshow the path of the config files in --version output
Jonathan Neuschäfer [Wed, 4 Jan 2012 19:36:05 +0000 (20:36 +0100)]
show the path of the config files in --version output

fixes http://musicpd.org/mantis/view.php?id=3354

12 years agoconf: helper functions to build config file names
Jonathan Neuschäfer [Wed, 4 Jan 2012 19:36:05 +0000 (20:36 +0100)]
conf: helper functions to build config file names

12 years agoconf: rename get_user_key_binding_filename to build_*
Jonathan Neuschäfer [Wed, 4 Jan 2012 19:36:04 +0000 (20:36 +0100)]
conf: rename get_user_key_binding_filename to build_*

This name is consistent with g_build_filename and it better reflects
the fact that memory is allocatd by this function.

12 years agoncmpc.1: update --version documentation
Jonathan Neuschäfer [Wed, 4 Jan 2012 19:36:04 +0000 (20:36 +0100)]
ncmpc.1: update --version documentation

12 years agoMerge remote branches 'jn/keydef' and 'jn/dev'
Max Kellermann [Wed, 4 Jan 2012 19:21:11 +0000 (20:21 +0100)]
Merge remote branches 'jn/keydef' and 'jn/dev'

12 years agoscreen_keydef: join two short-ish lines
Jonathan Neuschäfer [Wed, 28 Dec 2011 22:39:26 +0000 (23:39 +0100)]
screen_keydef: join two short-ish lines

12 years agoscreen_keydef: support CMD_GO_ROOT_DIRECTORY
Jonathan Neuschäfer [Wed, 28 Dec 2011 22:37:00 +0000 (23:37 +0100)]
screen_keydef: support CMD_GO_ROOT_DIRECTORY

Maybe a bit pointless, but some user might want that.

12 years agoscreen_keydef: support adding keys with CMD_ADD
Jonathan Neuschäfer [Wed, 28 Dec 2011 22:18:51 +0000 (23:18 +0100)]
screen_keydef: support adding keys with CMD_ADD

12 years agoAUTHORS: fix some grammar ("whom"/"who")
Jonathan Neuschäfer [Sat, 29 Oct 2011 14:05:03 +0000 (16:05 +0200)]
AUTHORS: fix some grammar ("whom"/"who")

This commit lacks a good description.

12 years agompdclient: add G_GNUC_PURE to _is_connected()/_get_current_song()
Jonathan Neuschäfer [Wed, 4 Jan 2012 17:50:28 +0000 (18:50 +0100)]
mpdclient: add G_GNUC_PURE to _is_connected()/_get_current_song()

12 years agoscreen_queue: fix indentation after #ifndef block
Jonathan Neuschäfer [Fri, 30 Dec 2011 11:14:07 +0000 (12:14 +0100)]
screen_queue: fix indentation after #ifndef block

12 years agoconf: make "hardware-cursor" a macro
Jonathan Neuschäfer [Thu, 29 Dec 2011 21:04:13 +0000 (22:04 +0100)]
conf: make "hardware-cursor" a macro

12 years agoremove obsolete str_pool.c and str_pool.h
Jonathan Neuschäfer [Thu, 29 Dec 2011 20:17:43 +0000 (21:17 +0100)]
remove obsolete str_pool.c and str_pool.h

12 years agocommand.c: remove obsolete DEBUG_KEYS and DK()
Jonathan Neuschäfer [Thu, 29 Dec 2011 13:53:24 +0000 (14:53 +0100)]
command.c: remove obsolete DEBUG_KEYS and DK()

12 years agoconf.c: use g_mkdir for WIN32 compatibility
Jonathan Neuschäfer [Tue, 27 Dec 2011 23:08:53 +0000 (00:08 +0100)]
conf.c: use g_mkdir for WIN32 compatibility

This patch is a follow-up to release-0.19-59-g3aea924.

12 years agoscreen_keydef: save lw->start when switching view modes
Jonathan Neuschäfer [Wed, 28 Dec 2011 22:14:27 +0000 (23:14 +0100)]
screen_keydef: save lw->start when switching view modes

12 years agoscreen_keydef: split out code to switch views
Jonathan Neuschäfer [Wed, 28 Dec 2011 22:04:36 +0000 (23:04 +0100)]
screen_keydef: split out code to switch views

12 years agoscreen_keydef: better distinction of adding and replacing keys
Jonathan Neuschäfer [Sat, 24 Dec 2011 17:28:06 +0000 (18:28 +0100)]
screen_keydef: better distinction of adding and replacing keys

12 years agoscreen_keydef: don't assign a key twice to one command
Jonathan Neuschäfer [Sat, 24 Dec 2011 17:28:06 +0000 (18:28 +0100)]
screen_keydef: don't assign a key twice to one command

12 years agoscreen_keydef: show command descriptions
Jonathan Neuschäfer [Sat, 24 Dec 2011 17:28:06 +0000 (18:28 +0100)]
screen_keydef: show command descriptions

12 years agoscreen_keydef: rework the list length / item position logic
Jonathan Neuschäfer [Sat, 24 Dec 2011 17:28:05 +0000 (18:28 +0100)]
screen_keydef: rework the list length / item position logic

12 years agoscreen_keydef: clean up keydef_cmd return values
Jonathan Neuschäfer [Sat, 24 Dec 2011 17:28:05 +0000 (18:28 +0100)]
screen_keydef: clean up keydef_cmd return values

12 years agoscreen_keydef: remove LIST_ITEM_{SAVE,APPLY}_LABEL
Jonathan Neuschäfer [Sat, 24 Dec 2011 17:28:04 +0000 (18:28 +0100)]
screen_keydef: remove LIST_ITEM_{SAVE,APPLY}_LABEL

These macros were only being used in one place.

12 years agoscreen_keydef: get rid of the BUFSIZE constant
Jonathan Neuschäfer [Sat, 24 Dec 2011 17:28:04 +0000 (18:28 +0100)]
screen_keydef: get rid of the BUFSIZE constant

It was only used in one function. Use sizeof(buf) instead.

12 years agoscreen_keydef: document delete_key
Jonathan Neuschäfer [Sat, 24 Dec 2011 17:28:04 +0000 (18:28 +0100)]
screen_keydef: document delete_key

12 years agooptions: get_key_names: use bool
Jonathan Neuschäfer [Thu, 22 Dec 2011 21:13:04 +0000 (22:13 +0100)]
options: get_key_names: use bool

(And true/false in calls to it)

12 years agocommand.c: set_key_flags: return void
Jonathan Neuschäfer [Thu, 22 Dec 2011 21:07:02 +0000 (22:07 +0100)]
command.c: set_key_flags: return void

The return value was unused

12 years agoconfig.sample: add the "timeout" option
Jonathan Neuschäfer [Thu, 22 Dec 2011 21:39:57 +0000 (22:39 +0100)]
config.sample: add the "timeout" option

12 years agoncmpc.1: the default connection timeout is 5 seconds
Jonathan Neuschäfer [Thu, 22 Dec 2011 13:45:41 +0000 (14:45 +0100)]
ncmpc.1: the default connection timeout is 5 seconds

12 years agochange CMD_LYRICS_EDIT to CMD_EDIT
Jonathan Neuschäfer [Wed, 21 Dec 2011 18:55:10 +0000 (19:55 +0100)]
change CMD_LYRICS_EDIT to CMD_EDIT

This allows other screens to implement edit funtionality

12 years agoscreen_lyrics: optionally ask before starting an editor
Jonathan Neuschäfer [Sat, 17 Dec 2011 20:58:01 +0000 (21:58 +0100)]
screen_lyrics: optionally ask before starting an editor

12 years agouse screen_get_yesno
Jonathan Neuschäfer [Sat, 17 Dec 2011 21:54:46 +0000 (22:54 +0100)]
use screen_get_yesno