![[tokkee]](http://tokkee.org/images/avatar.png){kind=avatar}
diff --git a/src/widgets/icon.cpp b/src/widgets/icon.cpp
index 25f911d7d95be822eadc3fb6d987c66f95524ecb..ca4aa286faa9243fe5801c0170e18cf142d1f590 100644 (file)
--- a/src/widgets/icon.cpp
+++ b/src/widgets/icon.cpp
#ifdef HAVE_CONFIG_H
# include "config.h"
#endif
-#include "path-prefix.h"
-
-
+#include <cstring>
+#include <glib/gmem.h>
#include <gtk/gtkiconfactory.h>
#include <gtk/gtkstock.h>
#include <gtk/gtkimage.h>
-
+#include <gtkmm/iconfactory.h>
+#include <gtkmm/iconset.h>
+#include <gtkmm/iconsource.h>
#include <gtkmm/image.h>
+#include "path-prefix.h"
#include "prefs-utils.h"
#include "inkscape.h"
#include "document.h"
static gboolean icon_prerender_task(gpointer data);
-static void addPreRender( GtkIconSize lsize, gchar const *name );
+static void addPreRender( Inkscape::IconSize lsize, gchar const *name );
static void sp_icon_class_init(SPIconClass *klass);
static void sp_icon_init(SPIcon *icon);
@@ -55,20 +57,34 @@ static void sp_icon_screen_changed( GtkWidget *widget, GdkScreen *previous_scree
static void sp_icon_style_set( GtkWidget *widget, GtkStyle *previous_style );
static void sp_icon_theme_changed( SPIcon *icon );
-static guchar *sp_icon_image_load_pixmap(gchar const *name, unsigned lsize, unsigned psize);
-static guchar *sp_icon_image_load_svg(gchar const *name, unsigned lsize, unsigned psize);
-
-static guchar *sp_icon_image_load(SPIcon *icon, gchar const *name);
-
-static int sp_icon_get_phys_size(int size);
+static GdkPixbuf *sp_icon_image_load_pixmap(gchar const *name, unsigned lsize, unsigned psize);
+static GdkPixbuf *sp_icon_image_load_svg(gchar const *name, unsigned lsize, unsigned psize);
static void sp_icon_overlay_pixels( guchar *px, int width, int height, int stride,
unsigned r, unsigned g, unsigned b );
+static void injectCustomSize();
+
static GtkWidgetClass *parent_class;
static bool sizeDirty = true;
+static bool sizeMapDone = false;
+static GtkIconSize iconSizeLookup[] = {
+ GTK_ICON_SIZE_INVALID,
+ GTK_ICON_SIZE_MENU,
+ GTK_ICON_SIZE_SMALL_TOOLBAR,
+ GTK_ICON_SIZE_LARGE_TOOLBAR,
+ GTK_ICON_SIZE_BUTTON,
+ GTK_ICON_SIZE_DND,
+ GTK_ICON_SIZE_DIALOG,
+ GTK_ICON_SIZE_MENU, // for Inkscape::ICON_SIZE_DECORATION
+};
+
+static Glib::RefPtr<Gtk::IconFactory> inkyIcons;
+static std::map<Glib::ustring, Gtk::IconSet *> iconSetCache;
+
+
GtkType
sp_icon_get_type()
{
sp_icon_init(SPIcon *icon)
{
GTK_WIDGET_FLAGS(icon) |= GTK_NO_WINDOW;
- icon->lsize = GTK_ICON_SIZE_BUTTON;
+ icon->lsize = Inkscape::ICON_SIZE_BUTTON;
icon->psize = 0;
icon->name = 0;
icon->pb = 0;
if ( GTK_WIDGET_DRAWABLE(widget) ) {
SPIcon *icon = SP_ICON(widget);
if ( !icon->pb ) {
- guchar *pixels = 0;
+ sp_icon_fetch_pixbuf( icon );
+ }
+
+ sp_icon_paint(SP_ICON(widget), &event->area);
+ }
+
+ return TRUE;
+}
+// PUBLIC CALL:
+void sp_icon_fetch_pixbuf( SPIcon *icon )
+{
+ if ( icon ) {
+ if ( !icon->pb ) {
icon->psize = sp_icon_get_phys_size(icon->lsize);
- pixels = sp_icon_image_load( icon, icon->name );
+ GdkPixbuf *pb = sp_icon_image_load_svg( icon->name, icon->lsize, icon->psize );
+ if (!pb) {
+ pb = sp_icon_image_load_pixmap( icon->name, icon->lsize, icon->psize );
+ }
- if (pixels) {
- // don't pass the nr_free because we're caching the pixel
- // space loaded through ...
- // I just changed this. make sure sp_icon_image_load still does the right thing.
- icon->pb = gdk_pixbuf_new_from_data(pixels, GDK_COLORSPACE_RGB, TRUE, 8,
- icon->psize, icon->psize, icon->psize * 4,
- /*(GdkPixbufDestroyNotify)nr_free*/NULL, NULL);
+ if ( pb ) {
+ icon->pb = pb;
icon->pb_faded = gdk_pixbuf_copy(icon->pb);
-
- pixels = gdk_pixbuf_get_pixels(icon->pb_faded);
- size_t stride = gdk_pixbuf_get_rowstride(icon->pb_faded);
- pixels += 3; // alpha
- for ( int row = 0 ; row < icon->psize ; row++ ) {
- guchar *row_pixels = pixels;
- for ( int column = 0 ; column < icon->psize ; column++ ) {
- *row_pixels = *row_pixels >> 1;
- row_pixels += 4;
- }
- pixels += stride;
- }
+ gdk_pixbuf_saturate_and_pixelate(icon->pb, icon->pb_faded, 0.5, TRUE);
} else {
/* TODO: We should do something more useful if we can't load the image. */
g_warning ("failed to load icon '%s'", icon->name);
}
}
-
- sp_icon_paint(SP_ICON(widget), &event->area);
}
-
- return TRUE;
}
-
static void sp_icon_screen_changed( GtkWidget *widget, GdkScreen *previous_screen )
{
if ( GTK_WIDGET_CLASS( parent_class )->screen_changed ) {
static GtkWidget *
-sp_icon_new_full( GtkIconSize lsize, gchar const *name )
+sp_icon_new_full( Inkscape::IconSize lsize, gchar const *name )
{
static gint dump = prefs_get_int_attribute_limited( "debug.icons", "dumpGtk", 0, 0, 1 );
static gint fallback = prefs_get_int_attribute_limited( "debug.icons", "checkNames", 0, 0, 1 );
GtkWidget *widget = 0;
if ( tryLoad ) {
- GtkWidget *img = gtk_image_new_from_stock( name, lsize );
+ gint trySize = CLAMP( static_cast<gint>(lsize), 0, static_cast<gint>(G_N_ELEMENTS(iconSizeLookup) - 1) );
+
+ if ( !sizeMapDone ) {
+ injectCustomSize();
+ }
+
+ GtkWidget *img = gtk_image_new_from_stock( name, iconSizeLookup[trySize] );
if ( img ) {
GtkImageType type = gtk_image_get_storage_type( GTK_IMAGE(img) );
if ( type == GTK_IMAGE_STOCK ) {
}
GtkWidget *
-sp_icon_new( GtkIconSize lsize, gchar const *name )
+sp_icon_new( Inkscape::IconSize lsize, gchar const *name )
{
return sp_icon_new_full( lsize, name );
}
-Gtk::Widget *sp_icon_get_icon( Glib::ustring const &oid, GtkIconSize size )
+// PUBLIC CALL:
+Gtk::Widget *sp_icon_get_icon( Glib::ustring const &oid, Inkscape::IconSize size )
{
Gtk::Widget *result = 0;
GtkWidget *widget = sp_icon_new_full( size, oid.c_str() );
return result;
}
-// Try to load the named svg, falling back to pixmaps
-guchar *
-sp_icon_image_load( SPIcon *icon, gchar const *name )
-{
- guchar *px = sp_icon_image_load_svg( name, icon->lsize, icon->psize );
- if (!px) {
- px = sp_icon_image_load_pixmap(name, icon->lsize, icon->psize);
- }
-
- return px;
-}
-
GtkIconSize
sp_icon_get_gtk_size(int size)
{
- static GtkIconSize map[64] = {(GtkIconSize)0};
+ static GtkIconSize sizemap[64] = {(GtkIconSize)0};
size = CLAMP(size, 4, 63);
- if (!map[size]) {
+ if (!sizemap[size]) {
static int count = 0;
char c[64];
g_snprintf(c, 64, "InkscapeIcon%d", count++);
- map[size] = gtk_icon_size_register(c, size, size);
+ sizemap[size] = gtk_icon_size_register(c, size, size);
}
- return map[size];
+ return sizemap[size];
}
-static int sp_icon_get_phys_size(int size)
+static void injectCustomSize()
+{
+ // TODO - still need to handle the case of theme changes and resize, especially as we can't re-register a string.
+ if ( !sizeMapDone )
+ {
+ gint dump = prefs_get_int_attribute_limited( "debug.icons", "dumpDefault", 0, 0, 1 );
+ gint width = 0;
+ gint height = 0;
+ if ( gtk_icon_size_lookup(GTK_ICON_SIZE_MENU, &width, &height ) ) {
+ gint newWidth = ((width * 3) / 4);
+ gint newHeight = ((height * 3) / 4);
+ GtkIconSize newSizeEnum = gtk_icon_size_register( "inkscape-decoration", newWidth, newHeight );
+ if ( newSizeEnum ) {
+ if ( dump ) {
+ g_message("Registered (%d, %d) <= (%d, %d) as index %d", newWidth, newHeight, width, height, newSizeEnum);
+ }
+ guint index = static_cast<guint>(Inkscape::ICON_SIZE_DECORATION);
+ if ( index < G_N_ELEMENTS(iconSizeLookup) ) {
+ iconSizeLookup[index] = newSizeEnum;
+ } else if ( dump ) {
+ g_message("size lookup array too small to store entry");
+ }
+ }
+ }
+ sizeMapDone = true;
+ }
+
+ static bool hit = false;
+ if ( !hit ) {
+ hit = true;
+ inkyIcons = Gtk::IconFactory::create();
+ inkyIcons->add_default();
+ }
+}
+
+// PUBLIC CALL:
+int sp_icon_get_phys_size(int size)
{
static bool init = false;
- static int lastSys[GTK_ICON_SIZE_DIALOG + 1];
- static int vals[GTK_ICON_SIZE_DIALOG + 1];
+ static int lastSys[Inkscape::ICON_SIZE_DECORATION + 1];
+ static int vals[Inkscape::ICON_SIZE_DECORATION + 1];
- size = CLAMP( size, GTK_ICON_SIZE_MENU, GTK_ICON_SIZE_DIALOG );
+ size = CLAMP( size, GTK_ICON_SIZE_MENU, Inkscape::ICON_SIZE_DECORATION );
+
+ if ( !sizeMapDone ) {
+ injectCustomSize();
+ }
if ( sizeDirty && init ) {
GtkIconSize const gtkSizes[] = {
GTK_ICON_SIZE_LARGE_TOOLBAR,
GTK_ICON_SIZE_BUTTON,
GTK_ICON_SIZE_DND,
- GTK_ICON_SIZE_DIALOG
+ GTK_ICON_SIZE_DIALOG,
+ static_cast<guint>(Inkscape::ICON_SIZE_DECORATION) < G_N_ELEMENTS(iconSizeLookup) ?
+ iconSizeLookup[static_cast<int>(Inkscape::ICON_SIZE_DECORATION)] :
+ GTK_ICON_SIZE_MENU
};
for (unsigned i = 0; i < G_N_ELEMENTS(gtkSizes) && init; ++i) {
- unsigned const val_ix(gtkSizes[i]);
+ guint const val_ix = (gtkSizes[i] <= GTK_ICON_SIZE_DIALOG) ? (guint)gtkSizes[i] : (guint)Inkscape::ICON_SIZE_DECORATION;
+
g_assert( val_ix < G_N_ELEMENTS(vals) );
gint width = 0;
if ( !init ) {
sizeDirty = false;
gint dump = prefs_get_int_attribute_limited( "debug.icons", "dumpDefault", 0, 0, 1 );
+
if ( dump ) {
g_message( "Default icon sizes:" );
}
GTK_ICON_SIZE_LARGE_TOOLBAR,
GTK_ICON_SIZE_BUTTON,
GTK_ICON_SIZE_DND,
- GTK_ICON_SIZE_DIALOG
+ GTK_ICON_SIZE_DIALOG,
+ static_cast<guint>(Inkscape::ICON_SIZE_DECORATION) < G_N_ELEMENTS(iconSizeLookup) ?
+ iconSizeLookup[static_cast<int>(Inkscape::ICON_SIZE_DECORATION)] :
+ GTK_ICON_SIZE_MENU
};
gchar const *const names[] = {
"GTK_ICON_SIZE_MENU",
"GTK_ICON_SIZE_LARGE_TOOLBAR",
"GTK_ICON_SIZE_BUTTON",
"GTK_ICON_SIZE_DND",
- "GTK_ICON_SIZE_DIALOG"
+ "GTK_ICON_SIZE_DIALOG",
+ "inkscape-decoration"
};
GtkWidget *icon = (GtkWidget *)g_object_new(SP_TYPE_ICON, NULL);
for (unsigned i = 0; i < G_N_ELEMENTS(gtkSizes); ++i) {
- unsigned const val_ix(gtkSizes[i]);
+ guint const val_ix = (gtkSizes[i] <= GTK_ICON_SIZE_DIALOG) ? (guint)gtkSizes[i] : (guint)Inkscape::ICON_SIZE_DECORATION;
+
g_assert( val_ix < G_N_ELEMENTS(vals) );
gint width = 0;
int const x1 = std::min(area->x + area->width, widget.allocation.x + padx + static_cast<int>(icon->psize) );
int const y1 = std::min(area->y + area->height, widget.allocation.y + pady + static_cast<int>(icon->psize) );
- gdk_draw_pixbuf(GDK_DRAWABLE(widget.window), NULL, image,
- x0 - widget.allocation.x - padx,
- y0 - widget.allocation.y - pady,
- x0, y0,
- x1 - x0, y1 - y0,
- GDK_RGB_DITHER_NORMAL, x0, y0);
+ int width = x1 - x0;
+ int height = y1 - y0;
+ // Limit drawing to when we actually have something. Avoids some crashes.
+ if ( (width > 0) && (height > 0) ) {
+ gdk_draw_pixbuf(GDK_DRAWABLE(widget.window), NULL, image,
+ x0 - widget.allocation.x - padx,
+ y0 - widget.allocation.y - pady,
+ x0, y0,
+ width, height,
+ GDK_RGB_DITHER_NORMAL, x0, y0);
+ }
}
}
-static guchar *
-sp_icon_image_load_pixmap(gchar const *name, unsigned lsize, unsigned psize)
+GdkPixbuf *sp_icon_image_load_pixmap(gchar const *name, unsigned /*lsize*/, unsigned psize)
{
- gchar *path;
- guchar *px;
- GdkPixbuf *pb;
-
- path = (gchar *) g_strdup_printf("%s/%s.png", INKSCAPE_PIXMAPDIR, name);
+ gchar *path = (gchar *) g_strdup_printf("%s/%s.png", INKSCAPE_PIXMAPDIR, name);
// TODO: bulia, please look over
gsize bytesRead = 0;
gsize bytesWritten = 0;
&bytesRead,
&bytesWritten,
&error);
- pb = gdk_pixbuf_new_from_file(localFilename, NULL);
+ GdkPixbuf *pb = gdk_pixbuf_new_from_file(localFilename, NULL);
g_free(localFilename);
g_free(path);
if (!pb) {
g_free(localFilename);
g_free(path);
}
+
if (pb) {
- if (!gdk_pixbuf_get_has_alpha(pb))
+ if (!gdk_pixbuf_get_has_alpha(pb)) {
gdk_pixbuf_add_alpha(pb, FALSE, 0, 0, 0);
+ }
+
if ( ( static_cast<unsigned>(gdk_pixbuf_get_width(pb)) != psize )
|| ( static_cast<unsigned>(gdk_pixbuf_get_height(pb)) != psize ) ) {
GdkPixbuf *spb = gdk_pixbuf_scale_simple(pb, psize, psize, GDK_INTERP_HYPER);
g_object_unref(G_OBJECT(pb));
pb = spb;
}
- guchar *spx = gdk_pixbuf_get_pixels(pb);
- int srs = gdk_pixbuf_get_rowstride(pb);
- px = nr_new(guchar, 4 * psize * psize);
- for (unsigned y = 0; y < psize; y++) {
- memcpy(px + 4 * y * psize, spx + y * srs, 4 * psize);
- }
- g_object_unref(G_OBJECT(pb));
-
- return px;
}
- return NULL;
+ return pb;
}
// takes doc, root, icon, and icon name to produce pixels
SPObject *object = doc->getObjectById(name);
if (object && SP_IS_ITEM(object)) {
/* Find bbox in document */
- NR::Matrix const i2doc(sp_item_i2doc_affine(SP_ITEM(object)));
- NR::Rect dbox = SP_ITEM(object)->invokeBbox(i2doc);
+ NR::Matrix const i2doc(from_2geom(sp_item_i2doc_affine(SP_ITEM(object))));
+ NR::Maybe<NR::Rect> dbox = SP_ITEM(object)->getBounds(i2doc);
if ( SP_OBJECT_PARENT(object) == NULL )
{
}
/* This is in document coordinates, i.e. pixels */
- if (dbox.isEmpty() == false) {
+ if ( dbox && !dbox->isEmpty() ) {
NRGC gc(NULL);
/* Update to renderable state */
double sf = 1.0;
- NRMatrix t;
- nr_matrix_set_scale(&t, sf, sf);
- nr_arena_item_set_transform(root, &t);
- nr_matrix_set_identity(&gc.transform);
+ nr_arena_item_set_transform(root, NR::Matrix(NR::scale(sf, sf)));
+ gc.transform.set_identity();
nr_arena_item_invoke_update( root, NULL, &gc,
NR_ARENA_ITEM_STATE_ALL,
NR_ARENA_ITEM_STATE_NONE );
/* Item integer bbox in points */
NRRectL ibox;
- ibox.x0 = (int) floor(sf * dbox.min()[NR::X] + 0.5);
- ibox.y0 = (int) floor(sf * dbox.min()[NR::Y] + 0.5);
- ibox.x1 = (int) floor(sf * dbox.max()[NR::X] + 0.5);
- ibox.y1 = (int) floor(sf * dbox.max()[NR::Y] + 0.5);
+ ibox.x0 = (int) floor(sf * dbox->min()[NR::X] + 0.5);
+ ibox.y0 = (int) floor(sf * dbox->min()[NR::Y] + 0.5);
+ ibox.x1 = (int) floor(sf * dbox->max()[NR::X] + 0.5);
+ ibox.y1 = (int) floor(sf * dbox->max()[NR::Y] + 0.5);
if ( dump ) {
g_message( " box --'%s' (%f,%f)-(%f,%f)", name, (double)ibox.x0, (double)ibox.y0, (double)ibox.x1, (double)ibox.y1 );
}
sf = (double)psize / (double)block;
- nr_matrix_set_scale(&t, sf, sf);
- nr_arena_item_set_transform(root, &t);
- nr_matrix_set_identity(&gc.transform);
+ nr_arena_item_set_transform(root, NR::Matrix(NR::scale(sf, sf)));
+ gc.transform.set_identity();
nr_arena_item_invoke_update( root, NULL, &gc,
NR_ARENA_ITEM_STATE_ALL,
NR_ARENA_ITEM_STATE_NONE );
/* Item integer bbox in points */
- ibox.x0 = (int) floor(sf * dbox.min()[NR::X] + 0.5);
- ibox.y0 = (int) floor(sf * dbox.min()[NR::Y] + 0.5);
- ibox.x1 = (int) floor(sf * dbox.max()[NR::X] + 0.5);
- ibox.y1 = (int) floor(sf * dbox.max()[NR::Y] + 0.5);
+ ibox.x0 = (int) floor(sf * dbox->min()[NR::X] + 0.5);
+ ibox.y0 = (int) floor(sf * dbox->min()[NR::Y] + 0.5);
+ ibox.x1 = (int) floor(sf * dbox->max()[NR::X] + 0.5);
+ ibox.y1 = (int) floor(sf * dbox->max()[NR::Y] + 0.5);
if ( dump ) {
g_message( " box2 --'%s' (%f,%f)-(%f,%f)", name, (double)ibox.x0, (double)ibox.y0, (double)ibox.x1, (double)ibox.y1 );
g_message( " ua --'%s' (%f,%f)-(%f,%f)", name, (double)ua.x0, (double)ua.y0, (double)ua.x1, (double)ua.y1 );
}
/* Set up pixblock */
- px = nr_new(guchar, 4 * psize * psize);
+ px = g_new(guchar, 4 * psize * psize);
memset(px, 0x00, 4 * psize * psize);
/* Render */
NRPixBlock B;
px + 4 * psize * (ua.y0 - area.y0) +
4 * (ua.x0 - area.x0),
4 * psize, FALSE, FALSE );
- nr_arena_item_invoke_render( root, &ua, &B,
+ nr_arena_item_invoke_render(NULL, root, &ua, &B,
NR_ARENA_ITEM_RENDER_NO_CACHE );
nr_pixblock_release(&B);
};
static std::map<Glib::ustring, svg_doc_cache_t *> doc_cache;
-static std::map<Glib::ustring, guchar *> px_cache;
+static std::map<Glib::ustring, GdkPixbuf *> pb_cache;
static Glib::ustring icon_cache_key(gchar const *name,
unsigned lsize, unsigned psize)
return key;
}
-static guchar *get_cached_pixels(Glib::ustring const &key) {
- std::map<Glib::ustring, guchar *>::iterator found=px_cache.find(key);
- if ( found != px_cache.end() ) {
+static GdkPixbuf *get_cached_pixbuf(Glib::ustring const &key) {
+ std::map<Glib::ustring, GdkPixbuf *>::iterator found = pb_cache.find(key);
+ if ( found != pb_cache.end() ) {
return found->second;
}
return NULL;
}
static guchar *load_svg_pixels(gchar const *name,
- unsigned lsize, unsigned psize)
+ unsigned /*lsize*/, unsigned psize)
{
SPDocument *doc = NULL;
NRArenaItem *root = NULL;
return px;
}
+static void addToIconSet(GdkPixbuf* pb, gchar const* name, unsigned lsize, unsigned /*psize*/) {
+ Gtk::IconSet* icnset = 0;
+ if ( iconSetCache.find(name) == iconSetCache.end() ) {
+ icnset = new Gtk::IconSet();
+ iconSetCache[name] = icnset;
+ inkyIcons->add(Gtk::StockID(name), *icnset);
+ } else {
+ icnset = iconSetCache[name];
+ }
+ Gtk::IconSource src;
+ src.set_pixbuf( Glib::wrap(pb) );
+ src.set_size( Gtk::IconSize(lsize) );
+ //src.set_state_wildcarded();
+ icnset->add_source(src);
+}
+
// returns true if icon needed preloading, false if nothing was done
static bool prerender_icon(gchar const *name, unsigned lsize, unsigned psize)
{
- Glib::ustring key=icon_cache_key(name, lsize, psize);
- guchar *px=get_cached_pixels(key);
- if (px) {
+ Glib::ustring key = icon_cache_key(name, lsize, psize);
+ GdkPixbuf *pb = get_cached_pixbuf(key);
+ if (pb) {
return false;
} else {
- px = load_svg_pixels(name, lsize, psize);
+ guchar* px = load_svg_pixels(name, lsize, psize);
if (px) {
- px_cache[key] = px;
+ pb = gdk_pixbuf_new_from_data(px, GDK_COLORSPACE_RGB, TRUE, 8,
+ psize, psize, psize * 4,
+ /*(GdkPixbufDestroyNotify)g_free*/NULL, NULL);
+
+ pb_cache[key] = pb;
+ addToIconSet(pb, name, lsize, psize);
}
return true;
}
}
-static guchar *
-sp_icon_image_load_svg(gchar const *name, unsigned lsize, unsigned psize)
+static GdkPixbuf *sp_icon_image_load_svg(gchar const *name, unsigned lsize, unsigned psize)
{
- Glib::ustring key=icon_cache_key(name, lsize, psize);
+ Glib::ustring key = icon_cache_key(name, lsize, psize);
// did we already load this icon at this scale/size?
- guchar *px=get_cached_pixels(key);
- if (!px) {
- px = load_svg_pixels(name, lsize, psize);
+ GdkPixbuf* pb = get_cached_pixbuf(key);
+ if (!pb) {
+ guchar *px = load_svg_pixels(name, lsize, psize);
if (px) {
- px_cache[key] = px;
+ // don't pass the g_free because we're caching the pixel
+ // space loaded through ...
+ // I just changed this. make sure sp_icon_image_load still does the right thing.
+ pb = gdk_pixbuf_new_from_data(px, GDK_COLORSPACE_RGB, TRUE, 8,
+ psize, psize, psize * 4,
+ /*(GdkPixbufDestroyNotify)g_free*/NULL, NULL);
+ pb_cache[key] = pb;
+ addToIconSet(pb, name, lsize, psize);
}
}
- return px;
+
+ // increase refcount since we're hading out ownership
+ g_object_ref(G_OBJECT(pb));
+ return pb;
}
void sp_icon_overlay_pixels(guchar *px, int width, int height, int stride,
class preRenderItem
{
public:
- preRenderItem( GtkIconSize lsize, gchar const *name ) :
+ preRenderItem( Inkscape::IconSize lsize, gchar const *name ) :
_lsize( lsize ),
_name( name )
{}
- GtkIconSize _lsize;
+ Inkscape::IconSize _lsize;
Glib::ustring _name;
};
static std::queue<preRenderItem> pendingRenders;
static bool callbackHooked = false;
-static void addPreRender( GtkIconSize lsize, gchar const *name )
+static void addPreRender( Inkscape::IconSize lsize, gchar const *name )
{
if ( !callbackHooked )
pendingRenders.push(preRenderItem(lsize, name));
}
-gboolean icon_prerender_task(gpointer data) {
+gboolean icon_prerender_task(gpointer /*data*/) {
if (!pendingRenders.empty()) {
preRenderItem single=pendingRenders.front();
pendingRenders.pop();