Code

* don't strech buttons on lpe dialog when resizing the dialog
[inkscape.git] / src / ui / dialog / dialog.cpp
index e7f1a7e135b8f979589d340ea07b351395ccf96e..7d2242802ed4f07d955f8c7be03288a1c66a4a90 100644 (file)
@@ -19,6 +19,7 @@
 
 #include <gtkmm/stock.h>
 #include <gtk/gtk.h>
+#include <gdk/gdkkeysyms.h>
 
 #include "application/application.h"
 #include "application/editor.h"
@@ -27,7 +28,7 @@
 #include "desktop.h"
 #include "desktop-handles.h"
 #include "dialog-manager.h"
-#include "dialogs/dialog-events.h"
+#include "modifier-fns.h"
 #include "shortcuts.h"
 #include "prefs-utils.h"
 #include "interface.h"
@@ -41,14 +42,14 @@ namespace UI {
 namespace Dialog {
 
 void
-sp_retransientize (Inkscape::Application *inkscape, SPDesktop *desktop, gpointer dlgPtr)
+sp_retransientize(Inkscape::Application *inkscape, SPDesktop *desktop, gpointer dlgPtr)
 {
     Dialog *dlg = (Dialog *)dlgPtr;
     dlg->onDesktopActivated (desktop);
 }
 
 gboolean
-sp_retransientize_again (gpointer dlgPtr)
+sp_retransientize_again(gpointer dlgPtr)
 {
     Dialog *dlg = (Dialog *)dlgPtr;
     dlg->retransientize_suppress = false;
@@ -56,7 +57,7 @@ sp_retransientize_again (gpointer dlgPtr)
 }
 
 void
-sp_dialog_shutdown (GtkObject *object, gpointer dlgPtr)
+sp_dialog_shutdown(GtkObject *object, gpointer dlgPtr)
 {
     Dialog *dlg = (Dialog *)dlgPtr;
     dlg->onShutdown();
@@ -94,7 +95,7 @@ void unhideCallback(GtkObject *object, gpointer dlgPtr)
  */
 
 Dialog::Dialog(Behavior::BehaviorFactory behavior_factory, const char *prefs_path, int verb_num,
-               const char *apply_label) 
+               Glib::ustring const &apply_label) 
     : _hiddenF12 (false),
       _prefs_path (prefs_path),
       _verb_num(verb_num),
@@ -109,8 +110,6 @@ Dialog::Dialog(Behavior::BehaviorFactory behavior_factory, const char *prefs_pat
 
     _behavior = behavior_factory(*this);
     
-    gtk_signal_connect( GTK_OBJECT (gobj()), "event", GTK_SIGNAL_FUNC(sp_dialog_event_handler), gobj() );
-
     if (Inkscape::NSApplication::Application::getNewGui()) {
         _desktop_activated_connection = Inkscape::NSApplication::Editor::connectDesktopActivated (sigc::mem_fun (*this, &Dialog::onDesktopActivated));
         _dialogs_hidden_connection = Inkscape::NSApplication::Editor::connectDialogsHidden (sigc::mem_fun (*this, &Dialog::onHideF12));
@@ -123,16 +122,8 @@ Dialog::Dialog(Behavior::BehaviorFactory behavior_factory, const char *prefs_pat
         g_signal_connect(G_OBJECT(INKSCAPE), "shut_down", G_CALLBACK(sp_dialog_shutdown), (void *)this);
     }
 
-    Glib::wrap(gobj())->signal_key_press_event().connect(sigc::ptr_fun(&windowKeyPress));
-
-    if (prefs_get_int_attribute ("dialogs", "showclose", 0) || apply_label) {
-        // TODO: make the order of buttons obey the global preference
-        if (apply_label) {
-            add_button(Glib::ustring(apply_label), Gtk::RESPONSE_APPLY);
-            set_default_response(Gtk::RESPONSE_APPLY);
-        }
-        add_button(Gtk::Stock::CLOSE, Gtk::RESPONSE_CLOSE);
-    }
+    Glib::wrap(gobj())->signal_event().connect(sigc::mem_fun(*this, &Dialog::_onEvent));
+    Glib::wrap(gobj())->signal_key_press_event().connect(sigc::mem_fun(*this, &Dialog::_onKeyPress));
 
     read_geometry();
 }
@@ -155,20 +146,6 @@ Dialog::~Dialog()
 //---------------------------------------------------------------------
 
 
-bool Dialog::windowKeyPress(GdkEventKey *event)
-{
-    unsigned int shortcut = 0;
-    shortcut = get_group0_keyval (event) |
-        ( event->state & GDK_SHIFT_MASK ?
-          SP_SHORTCUT_SHIFT_MASK : 0 ) |
-        ( event->state & GDK_CONTROL_MASK ?
-          SP_SHORTCUT_CONTROL_MASK : 0 ) |
-        ( event->state & GDK_MOD1_MASK ?
-          SP_SHORTCUT_ALT_MASK : 0 );
-    return sp_shortcut_invoke( shortcut, SP_ACTIVE_DESKTOP );
-
-}
-
 void
 Dialog::onDesktopActivated(SPDesktop *desktop)
 {
@@ -204,7 +181,7 @@ Dialog::onShowF12()
 }
 
 
-inline Dialog::operator Gtk::Widget&()                           { return *_behavior; }
+inline Dialog::operator Gtk::Widget &()                          { return *_behavior; }
 inline GtkWidget *Dialog::gobj()                                 { return _behavior->gobj(); }
 inline void Dialog::present()                                    { _behavior->present(); }
 inline Gtk::VBox *Dialog::get_vbox()                             {  return _behavior->get_vbox(); }
@@ -212,33 +189,17 @@ inline void Dialog::hide()                                       { _behavior->hi
 inline void Dialog::show()                                       { _behavior->show(); }
 inline void Dialog::show_all_children()                          { _behavior->show_all_children(); }
 inline void Dialog::set_size_request(int width, int height)      { _behavior->set_size_request(width, height); }
-inline void Dialog::size_request(Gtk::Requisitionrequisition)  { _behavior->size_request(requisition); }
-inline void Dialog::get_position(int& x, int& y)                 { _behavior->get_position(x, y); }
-inline void Dialog::get_size(int& width, int& height)            { _behavior->get_size(width, height); }
+inline void Dialog::size_request(Gtk::Requisition &requisition)  { _behavior->size_request(requisition); }
+inline void Dialog::get_position(int &x, int &y)                 { _behavior->get_position(x, y); }
+inline void Dialog::get_size(int &width, int &height)            { _behavior->get_size(width, height); }
 inline void Dialog::resize(int width, int height)                { _behavior->resize(width, height); }
 inline void Dialog::move(int x, int y)                           { _behavior->move(x, y); }
 inline void Dialog::set_position(Gtk::WindowPosition position)   { _behavior->set_position(position); }
 inline void Dialog::set_title(Glib::ustring title)               { _behavior->set_title(title); }
 inline void Dialog::set_sensitive(bool sensitive)                { _behavior->set_sensitive(sensitive); }
 
-inline void Dialog::set_response_sensitive(int response_id, bool setting)
-{ _behavior->set_response_sensitive(response_id, setting); }
-
-void Dialog::set_resizable(bool) { }
-void Dialog::set_default(Gtk::Widget&) { }
-
-inline void Dialog::set_default_response(int response_id) { _behavior->set_default_response(response_id); }
-
-Glib::SignalProxy0<void> Dialog::signal_show () { return _behavior->signal_show(); }
-Glib::SignalProxy0<void> Dialog::signal_hide () { return _behavior->signal_hide(); }
-Glib::SignalProxy1<void, int> Dialog::signal_response () { return _behavior->signal_response(); }
-
-Gtk::Button* Dialog::add_button (const Glib::ustring& button_text, int response_id) 
-{ return _behavior->add_button(button_text, response_id); }
-
-Gtk::Button* Dialog::add_button (const Gtk::StockID& stock_id, int response_id)
-{ return _behavior->add_button(stock_id, response_id); }
-
+Glib::SignalProxy0<void> Dialog::signal_show() { return _behavior->signal_show(); }
+Glib::SignalProxy0<void> Dialog::signal_hide() { return _behavior->signal_hide(); }
 
 void
 Dialog::read_geometry()
@@ -292,13 +253,9 @@ Dialog::save_geometry()
 }
 
 void
-Dialog::_onResponse(int response_id)
+Dialog::_handleResponse(int response_id)
 {
     switch (response_id) {
-        case Gtk::RESPONSE_APPLY: {
-            _apply();
-            break;
-        }
         case Gtk::RESPONSE_CLOSE: {
             _close();
             break;
@@ -315,6 +272,54 @@ Dialog::_onDeleteEvent(GdkEventAny *event)
     return false;
 }
 
+bool
+Dialog::_onEvent(GdkEvent *event)
+{
+    bool ret = false;
+
+    switch (event->type) {
+        case GDK_KEY_PRESS: {
+            switch (get_group0_keyval (&event->key)) {
+                case GDK_Escape: {
+                    _defocus();
+                    ret = true;
+                    break;
+                }
+                case GDK_F4:
+                case GDK_w:
+                case GDK_W: {
+                    if (mod_ctrl_only(event->key.state)) {
+                        _close();
+                        ret = true;
+                    }
+                    break;
+                }
+                default: { // pass keypress to the canvas
+                    break;
+                }
+            }
+        }
+        default:
+            ;
+    }
+
+    return ret;
+}
+
+bool
+Dialog::_onKeyPress(GdkEventKey *event)
+{
+    unsigned int shortcut;
+    shortcut = get_group0_keyval(event) |
+        ( event->state & GDK_SHIFT_MASK ?
+          SP_SHORTCUT_SHIFT_MASK : 0 ) |
+        ( event->state & GDK_CONTROL_MASK ?
+          SP_SHORTCUT_CONTROL_MASK : 0 ) |
+        ( event->state & GDK_MOD1_MASK ?
+          SP_SHORTCUT_ALT_MASK : 0 );
+    return sp_shortcut_invoke(shortcut, SP_ACTIVE_DESKTOP);
+}
+
 void
 Dialog::_apply()
 {
@@ -346,6 +351,23 @@ Dialog::_close()
         g_object_unref(G_OBJECT(event.window));
 }
 
+void
+Dialog::_defocus()
+{
+    SPDesktop *desktop = SP_ACTIVE_DESKTOP;
+
+    if (desktop) {
+        Gtk::Widget *canvas = Glib::wrap(GTK_WIDGET(desktop->canvas));
+
+        // make sure the canvas window is present before giving it focus
+        Gtk::Window *toplevel_window = dynamic_cast<Gtk::Window *>(canvas->get_toplevel());
+        if (toplevel_window)
+            toplevel_window->present();
+
+        canvas->grab_focus();
+    }
+}
+
 Inkscape::Selection*
 Dialog::_getSelection()
 {