![[tokkee]](http://tokkee.org/images/avatar.png){kind=avatar}
diff --git a/src/seltrans.cpp b/src/seltrans.cpp
index a1a200282490f7e85c2652e19974eabe4ccd8b6e..9c874c242cb666d8d2b07f18c92deb0e7b1846bd 100644 (file)
--- a/src/seltrans.cpp
+++ b/src/seltrans.cpp
_show(SHOW_CONTENT),
_grabbed(false),
_show_handles(true),
- _box(NR::Nothing()),
+ _bbox(NR::Nothing()),
+ _approximate_bbox(NR::Nothing()),
_chandle(NULL),
_stamp_cache(NULL),
_message_context(desktop->messageStack())
{
+ gchar const *prefs_bbox = prefs_get_string_attribute("tools.select", "bounding_box");
+ _snap_bbox_type = (prefs_bbox != NULL && strcmp(prefs_bbox, "geometric")==0)? SPItem::GEOMETRIC_BBOX : SPItem::APPROXIMATE_BBOX;
+
g_return_if_fail(desktop != NULL);
for (int i = 0; i < 8; i++) {
@@ -254,36 +258,70 @@ void Inkscape::SelTrans::grab(NR::Point const &p, gdouble x, gdouble y, bool sho
_current.set_identity();
_point = p;
-
- _snap_points = selection->getSnapPointsConvexHull();
- _box = selection->bounds();
- _bbox_points.clear();
- if (_box) {
- for ( unsigned i = 0 ; i < 4 ; i++ ) {
- _bbox_points.push_back(_box->corner(i));
+
+ // The selector tool should snap the bbox and the special snappoints, but not path nodes
+ // (The special points are the handles, center, rotation axis, font baseline, ends of spiral, etc.)
+
+ // First, determine the bounding box for snapping ...
+ _bbox = selection->bounds(_snap_bbox_type);
+ _approximate_bbox = selection->bounds(SPItem::APPROXIMATE_BBOX); // Used for correctly scaling the strokewidth
+
+
+ // Next, get all special points for snapping
+ _snap_points = selection->getSnapPoints(); // Excludes path nodes
+ std::vector<NR::Point> snap_points_hull = selection->getSnapPointsConvexHull(); // Includes path nodes
+ if (_snap_points.size() > 100) {
+ /* Snapping a huge number of nodes will take way too long, so limit the number of snappable nodes
+ An average user would rarely ever try to snap such a large number of nodes anyway, because
+ (s)he could hardly discern which node would be snapping */
+ _snap_points = snap_points_hull;
+ // Unfortunately, by now we will have lost the font-baseline snappoints :-(
+ }
+
+ // Find bbox hulling all special points, which excludes stroke width. Here we need to include the
+ // path nodes, for example because a rectangle which has been converted to a path doesn't have
+ // any other special points
+ NR::Rect snap_points_bbox;
+ if ( snap_points_hull.empty() == false ) {
+ std::vector<NR::Point>::iterator i = snap_points_hull.begin();
+ snap_points_bbox = NR::Rect(*i, *i);
+ i++;
+ while (i != snap_points_hull.end()) {
+ snap_points_bbox.expandTo(*i);
+ i++;
}
}
-
- gchar const *scale_origin = prefs_get_string_attribute("tools.select", "scale_origin");
- bool const origin_on_bbox = (scale_origin == NULL || !strcmp(scale_origin, "bbox"));
-
- if (_box) {
- NR::Rect op_box = *_box;
- // FIXME: should be using ConvexHull here
- if (origin_on_bbox == false && _snap_points.empty() == false) {
- std::vector<NR::Point>::iterator i = _snap_points.begin();
- op_box = NR::Rect(*i, *i);
- i++;
- while (i != _snap_points.end()) {
- op_box.expandTo(*i);
- i++;
- }
+
+ _bbox_points.clear();
+ if (_bbox) {
+ // ... and add the bbox corners to _bbox_points
+ for ( unsigned i = 0 ; i < 4 ; i++ ) {
+ _bbox_points.push_back(_bbox->corner(i));
}
-
- _opposite = ( op_box.min() + ( op_box.dimensions() * NR::scale(1-x, 1-y) ) );
+ // There are two separate "opposites" (i.e. opposite w.r.t. the handle being dragged):
+ // - one for snapping the boundingbox, which can be either visual or geometric
+ // - one for snapping the special points
+ // The "opposite" in case of a geometric boundingbox always coincides with the "opposite" for the special points
+ // These distinct "opposites" are needed in the snapmanager to avoid bugs such as #1540195 (in which
+ // a box is caught between to guides)
+ _opposite_for_bboxpoints = _bbox->min() + _bbox->dimensions() * NR::scale(1-x, 1-y);
+ _opposite_for_specpoints = (snap_points_bbox.min() + (snap_points_bbox.dimensions() * NR::scale(1-x, 1-y) ) );
+ // Only a single "opposite" can be used in calculating transformations.
+ _opposite = _opposite_for_bboxpoints;
+ }
+
+ /*std::cout << "Number of snap points: " << _snap_points.size() << std::endl;
+ for (std::vector<NR::Point>::const_iterator i = _snap_points.begin(); i != _snap_points.end(); i++)
+ {
+ std::cout << " " << *i << std::endl;
}
-
-
+
+ std::cout << "Number of bbox points: " << _bbox_points.size() << std::endl;
+ for (std::vector<NR::Point>::const_iterator i = _bbox_points.begin(); i != _bbox_points.end(); i++)
+ {
+ std::cout << " " << *i << std::endl;
+ }*/
+
if ((x != -1) && (y != -1)) {
sp_canvas_item_show(_norm);
sp_canvas_item_show(_grip);
@@ -313,11 +351,11 @@ void Inkscape::SelTrans::transform(NR::Matrix const &rel_affine, NR::Point const
sp_item_set_i2d_affine(&item, prev_transform * affine);
}
} else {
- if (_box) {
+ if (_bbox) {
NR::Point p[4];
/* update the outline */
for (unsigned i = 0 ; i < 4 ; i++) {
- p[i] = _box->corner(i) * affine;
+ p[i] = _bbox->corner(i) * affine;
}
for (unsigned i = 0 ; i < 4 ; i++) {
sp_ctrlline_set_coords(SP_CTRLLINE(_l[i]), p[i], p[(i+1)%4]);
// remember parent
Inkscape::XML::Node *parent = sp_repr_parent(original_repr);
- Inkscape::XML::Node *copy_repr = original_repr->duplicate();
+ Inkscape::XML::Node *copy_repr = original_repr->duplicate(parent->document());
// add the new repr to the parent
parent->appendChild(copy_repr);
return;
}
- _box = selection->bounds();
- if (!_box) {
+ //Update the bboxes
+ _bbox = selection->bounds(_snap_bbox_type);
+ _approximate_bbox = selection->bounds(SPItem::APPROXIMATE_BBOX);
+
+ if (!_bbox) {
_empty = true;
return;
}
@@ -607,9 +648,9 @@ void Inkscape::SelTrans::_showHandles(SPKnot *knot[], SPSelTransHandle const han
NR::Point const handle_pt(handle[i].x, handle[i].y);
// shouldn't have nullary bbox, but knots
- g_assert(_box);
- NR::Point p( _box->min()
- + ( _box->dimensions()
+ g_assert(_bbox);
+ NR::Point p( _bbox->min()
+ + ( _bbox->dimensions()
* NR::scale(handle_pt) ) );
sp_knot_moveto(knot[i], &p);
@@ -728,8 +769,12 @@ gboolean Inkscape::SelTrans::handleRequest(SPKnot *knot, NR::Point *position, gu
if ((!(state & GDK_SHIFT_MASK) == !(_state == STATE_ROTATE)) && (&handle != &handle_center)) {
_origin = _opposite;
+ _origin_for_bboxpoints = _opposite_for_bboxpoints;
+ _origin_for_specpoints = _opposite_for_specpoints;
} else if (_center) {
_origin = *_center;
+ _origin_for_bboxpoints = *_center;
+ _origin_for_specpoints = *_center;
} else {
// FIXME
return TRUE;
@@ -747,6 +792,11 @@ gboolean Inkscape::SelTrans::handleRequest(SPKnot *knot, NR::Point *position, gu
void Inkscape::SelTrans::_selChanged(Inkscape::Selection *selection)
{
if (!_grabbed) {
+ // reread in case it changed on the fly:
+ gchar const *prefs_bbox = prefs_get_string_attribute("tools.select", "bounding_box");
+ _snap_bbox_type = (prefs_bbox != NULL && strcmp(prefs_bbox, "geometric")==0)? SPItem::GEOMETRIC_BBOX : SPItem::APPROXIMATE_BBOX;
+ //SPItem::APPROXIMATE_BBOX will be replaced by SPItem::VISUAL_BBOX, as soon as the latter is implemented properly
+
_updateVolatileState();
_current.set_identity();
_center_is_set = false; // center(s) may have changed
}
if ((state & GDK_CONTROL_MASK) || _desktop->isToolboxButtonActive ("lock")) {
- /* Scale is locked to a 1:1 aspect ratio, so that s[X] must be made to equal s[Y].
- ** To do this, we snap along a suitable constraint vector from the origin.
- */
+ // Scale is locked to a 1:1 aspect ratio, so that s[X] must be made to equal s[Y].
+ //
+ // The aspect-ratio must be locked before snapping
+ if (fabs(s[NR::X]) > fabs(s[NR::Y])) {
+ s[NR::X] = fabs(s[NR::Y]) * sign(s[NR::X]);
+ } else {
+ s[NR::Y] = fabs(s[NR::X]) * sign(s[NR::Y]);
+ }
+
+ // Snap along a suitable constraint vector from the origin.
+
+ // The inclination of the constraint vector is calculated from the aspect ratio
+ NR::Point bbox_dim = _bbox->dimensions();
+ double const aspect_ratio = bbox_dim[1] / bbox_dim[0]; // = height / width
+ // Determine direction of the constraint vector
NR::Point const cv = NR::Point(
pt[NR::X] > _origin[NR::X] ? 1 : -1,
- pt[NR::Y] > _origin[NR::Y] ? 1 : -1
+ pt[NR::Y] > _origin[NR::Y] ? aspect_ratio : -aspect_ratio
);
std::pair<NR::scale, bool> bb = m.constrainedSnapScale(Snapper::BBOX_POINT,
_bbox_points,
it,
- Snapper::ConstraintLine(_origin, cv),
+ Snapper::ConstraintLine(_origin_for_bboxpoints, cv),
s,
- _origin);
+ _origin_for_bboxpoints);
std::pair<NR::scale, bool> sn = m.constrainedSnapScale(Snapper::SNAP_POINT,
_snap_points,
it,
- Snapper::ConstraintLine(_origin, cv),
+ Snapper::ConstraintLine(_origin_for_specpoints, cv),
s,
- _origin);
+ _origin_for_specpoints);
if (bb.second == false && sn.second == false) {
-
- /* We didn't snap, so just lock aspect ratio */
- if (fabs(s[NR::X]) > fabs(s[NR::Y])) {
- s[NR::X] = fabs(s[NR::Y]) * sign(s[NR::X]);
- } else {
- s[NR::Y] = fabs(s[NR::X]) * sign(s[NR::Y]);
- }
-
+ /* We didn't snap, so just keep the locked aspect ratio */
} else {
-
/* Choose the smaller difference in scale. Since s[X] == s[Y] we can
** just compare difference in s[X].
*/
_bbox_points,
it,
s,
- _origin);
+ _origin_for_bboxpoints);
std::pair<NR::scale, bool> sn = m.freeSnapScale(Snapper::SNAP_POINT,
_snap_points,
it,
s,
- _origin);
+ _origin_for_specpoints);
/* Pick the snap that puts us closest to the original scale */
NR::Coord bd = bb.second ?
@@ -964,6 +1018,7 @@ gboolean Inkscape::SelTrans::stretchRequest(SPSelTransHandle const &handle, NR::
SnapManager const &m = _desktop->namedview->snap_manager;
if ( state & GDK_CONTROL_MASK ) {
+ // on ctrl, apply symmetrical scaling instead of stretching
s[perp] = fabs(s[axis]);
std::pair<NR::Coord, bool> const bb = m.freeSnapStretch(
@@ -971,7 +1026,7 @@ gboolean Inkscape::SelTrans::stretchRequest(SPSelTransHandle const &handle, NR::
_bbox_points,
it,
s[axis],
- _origin,
+ _origin_for_bboxpoints,
axis,
true);
@@ -980,7 +1035,7 @@ gboolean Inkscape::SelTrans::stretchRequest(SPSelTransHandle const &handle, NR::
_snap_points,
it,
s[axis],
- _origin,
+ _origin_for_specpoints,
axis,
true);
@@ -991,13 +1046,13 @@ gboolean Inkscape::SelTrans::stretchRequest(SPSelTransHandle const &handle, NR::
s[axis] = fabs(ratio) * sign(s[axis]);
s[perp] = fabs(s[axis]);
} else {
-
+
std::pair<NR::Coord, bool> const bb = m.freeSnapStretch(
Snapper::BBOX_POINT,
_bbox_points,
it,
s[axis],
- _origin,
+ _origin_for_bboxpoints,
axis,
false);
@@ -1006,7 +1061,7 @@ gboolean Inkscape::SelTrans::stretchRequest(SPSelTransHandle const &handle, NR::
_snap_points,
it,
s[axis],
- _origin,
+ _origin_for_specpoints,
axis,
false);
@@ -1086,15 +1141,15 @@ gboolean Inkscape::SelTrans::skewRequest(SPSelTransHandle const &handle, NR::Poi
_bbox_points,
std::list<SPItem const *>(),
skew[dim_a],
- _origin,
- dim_a);
+ _origin_for_bboxpoints,
+ dim_b);
std::pair<NR::Coord, bool> sn = m.freeSnapSkew(Inkscape::Snapper::SNAP_POINT,
_snap_points,
std::list<SPItem const *>(),
skew[dim_a],
- _origin,
- dim_a);
+ _origin_for_specpoints,
+ dim_b);
if (bb.second || sn.second) {
/* We snapped something, so change the skew to reflect it */
}
}
- if ( !(state & GDK_SHIFT_MASK) && _box ) {
+ if ( !(state & GDK_SHIFT_MASK) && _bbox ) {
// screen pixels to snap center to bbox
#define SNAP_DIST 5
// FIXME: take from prefs
double snap_dist = SNAP_DIST / _desktop->current_zoom();
for (int i = 0; i < 2; i++) {
- if (fabs(pt[i] - _box->min()[i]) < snap_dist) {
- pt[i] = _box->min()[i];
+ if (fabs(pt[i] - _bbox->min()[i]) < snap_dist) {
+ pt[i] = _bbox->min()[i];
}
- if (fabs(pt[i] - _box->midpoint()[i]) < snap_dist) {
- pt[i] = _box->midpoint()[i];
+ if (fabs(pt[i] - _bbox->midpoint()[i]) < snap_dist) {
+ pt[i] = _bbox->midpoint()[i];
}
- if (fabs(pt[i] - _box->max()[i]) < snap_dist) {
- pt[i] = _box->max()[i];
+ if (fabs(pt[i] - _bbox->max()[i]) < snap_dist) {
+ pt[i] = _bbox->max()[i];
}
}
}
@@ -1279,23 +1334,30 @@ void Inkscape::SelTrans::stretch(SPSelTransHandle const &handle, NR::Point &pt,
s[!dim] = fabs(s[dim]);
}
- if (!_box) {
+ if (!_bbox) {
return;
}
- NR::Point new_bbox_min = _box->min() * (NR::translate(-scale_origin) * NR::Matrix(s) * NR::translate(scale_origin));
- NR::Point new_bbox_max = _box->max() * (NR::translate(-scale_origin) * NR::Matrix(s) * NR::translate(scale_origin));
+ NR::Point new_bbox_min = _approximate_bbox->min() * (NR::translate(-scale_origin) * NR::Matrix(s) * NR::translate(scale_origin));
+ NR::Point new_bbox_max = _approximate_bbox->max() * (NR::translate(-scale_origin) * NR::Matrix(s) * NR::translate(scale_origin));
- int transform_stroke = prefs_get_int_attribute ("options.transform", "stroke", 1);
- NR::Matrix scaler = get_scale_transform_with_stroke (*_box, _strokewidth, transform_stroke,
- new_bbox_min[NR::X], new_bbox_min[NR::Y], new_bbox_max[NR::X], new_bbox_max[NR::Y]);
+ int transform_stroke = false;
+ gdouble strokewidth = 0;
+
+ if ( _snap_bbox_type != SPItem::GEOMETRIC_BBOX) {
+ transform_stroke = prefs_get_int_attribute ("options.transform", "stroke", 1);
+ strokewidth = _strokewidth;
+ }
+
+ NR::Matrix scaler = get_scale_transform_with_stroke (*_approximate_bbox, strokewidth, transform_stroke,
+ new_bbox_min[NR::X], new_bbox_min[NR::Y], new_bbox_max[NR::X], new_bbox_max[NR::Y]);
transform(scaler, NR::Point(0, 0)); // we have already accounted for origin, so pass 0,0
}
void Inkscape::SelTrans::scale(NR::Point &pt, guint state)
{
- if (!_box) {
+ if (!_bbox) {
return;
}
if (fabs(s[i]) < 1e-9)
s[i] = 1e-9;
}
- NR::Point new_bbox_min = _box->min() * (NR::translate(-_origin) * NR::Matrix(s) * NR::translate(_origin));
- NR::Point new_bbox_max = _box->max() * (NR::translate(-_origin) * NR::Matrix(s) * NR::translate(_origin));
-
- int transform_stroke = prefs_get_int_attribute ("options.transform", "stroke", 1);
- NR::Matrix scaler = get_scale_transform_with_stroke (*_box, _strokewidth, transform_stroke,
- new_bbox_min[NR::X], new_bbox_min[NR::Y], new_bbox_max[NR::X], new_bbox_max[NR::Y]);
+
+ NR::Point new_bbox_min = _approximate_bbox->min() * (NR::translate(-_origin) * NR::Matrix(s) * NR::translate(_origin));
+ NR::Point new_bbox_max = _approximate_bbox->max() * (NR::translate(-_origin) * NR::Matrix(s) * NR::translate(_origin));
+
+ int transform_stroke = false;
+ gdouble strokewidth = 0;
+ if ( _snap_bbox_type != SPItem::GEOMETRIC_BBOX) {
+ transform_stroke = prefs_get_int_attribute ("options.transform", "stroke", 1);
+ strokewidth = _strokewidth;
+ }
+
+ NR::Matrix scaler = get_scale_transform_with_stroke (*_approximate_bbox, strokewidth, transform_stroke,
+ new_bbox_min[NR::X], new_bbox_min[NR::Y], new_bbox_max[NR::X], new_bbox_max[NR::Y]);
+
transform(scaler, NR::Point(0, 0)); // we have already accounted for origin, so pass 0,0
}