![[tokkee]](http://tokkee.org/images/avatar.png){kind=avatar}
diff --git a/src/persp3d.cpp b/src/persp3d.cpp
index e647af6987499fd793c039b99d3e13cf51cfa0de..71d12619bc5d60582611eb4e59f87f0ae738e036 100644 (file)
--- a/src/persp3d.cpp
+++ b/src/persp3d.cpp
static void persp3d_release(SPObject *object);
static void persp3d_set(SPObject *object, unsigned key, gchar const *value);
static void persp3d_update(SPObject *object, SPCtx *ctx, guint flags);
-static Inkscape::XML::Node *persp3d_write(SPObject *object, Inkscape::XML::Node *repr, guint flags);
+static Inkscape::XML::Node *persp3d_write(SPObject *object, Inkscape::XML::Document *doc, Inkscape::XML::Node *repr, guint flags);
static void persp3d_on_repr_attr_changed (Inkscape::XML::Node * repr, const gchar *key, const gchar *oldval, const gchar *newval, bool is_interactive, void * data);
{
persp->tmat = Proj::TransfMat3x4 ();
- persp->boxes_transformed.clear();
+ persp->boxes_transformed = new std::map<SPBox3D *, bool>;
+ persp->boxes_transformed->clear();
persp->document = NULL;
persp->my_counter = global_counter++;
@@ -123,6 +124,8 @@ static void persp3d_build(SPObject *object, SPDocument *document, Inkscape::XML:
* Virtual release of Persp3D members before destruction.
*/
static void persp3d_release(SPObject *object) {
+ Persp3D *persp = SP_PERSP3D (object);
+ delete persp->boxes_transformed;
SP_OBJECT_REPR(object)->removeListenerByData(object);
}
@@ -227,7 +230,6 @@ persp3d_create_xml_element (SPDocument *document, Persp3D *dup) {// if dup is gi
str = proj_origin.coord_string();
repr->setAttribute("inkscape:persp3d-origin", str);
g_free (str);
- Inkscape::GC::release(repr);
}
/* Append the new persp3d to defs */
* Virtual write: write object attributes to repr.
*/
static Inkscape::XML::Node *
-persp3d_write(SPObject *object, Inkscape::XML::Node *repr, guint flags)
+persp3d_write(SPObject *object, Inkscape::XML::Document *xml_doc, Inkscape::XML::Node *repr, guint flags)
{
Persp3D *persp = SP_PERSP3D(object);
if ((flags & SP_OBJECT_WRITE_BUILD & SP_OBJECT_WRITE_EXT) && !repr) {
// this is where we end up when saving as plain SVG (also in other circumstances?);
// hence we don't set the sodipodi:type attribute
- Inkscape::XML::Document *xml_doc = sp_document_repr_doc(SP_OBJECT_DOCUMENT(object));
repr = xml_doc->createElement("inkscape:perspective");
}
}
if (((SPObjectClass *) persp3d_parent_class)->write)
- (* ((SPObjectClass *) persp3d_parent_class)->write)(object, repr, flags);
+ (* ((SPObjectClass *) persp3d_parent_class)->write)(object, xml_doc, repr, flags);
return repr;
}
/* convenience wrapper around persp3d_get_finite_dir() and persp3d_get_infinite_dir() */
-NR::Point persp3d_get_PL_dir_from_pt (Persp3D *persp, NR::Point const &pt, Proj::Axis axis) {
+Geom::Point persp3d_get_PL_dir_from_pt (Persp3D *persp, Geom::Point const &pt, Proj::Axis axis) {
if (persp3d_VP_is_finite(persp, axis)) {
return persp3d_get_finite_dir(persp, pt, axis);
} else {
@@ -295,20 +296,20 @@ NR::Point persp3d_get_PL_dir_from_pt (Persp3D *persp, NR::Point const &pt, Proj:
}
}
-NR::Point
-persp3d_get_finite_dir (Persp3D *persp, NR::Point const &pt, Proj::Axis axis) {
+Geom::Point
+persp3d_get_finite_dir (Persp3D *persp, Geom::Point const &pt, Proj::Axis axis) {
Box3D::PerspectiveLine pl(pt, axis, persp);
return pl.direction();
}
-NR::Point
+Geom::Point
persp3d_get_infinite_dir (Persp3D *persp, Proj::Axis axis) {
Proj::Pt2 vp(persp3d_get_VP(persp, axis));
if (vp[2] != 0.0) {
g_print ("VP should be infinite but is (%f : %f : %f)\n", vp[0], vp[1], vp[2]);
- g_return_val_if_fail(vp[2] != 0.0, NR::Point(0.0, 0.0));
+ g_return_val_if_fail(vp[2] != 0.0, Geom::Point(0.0, 0.0));
}
- return NR::Point(vp[0], vp[1]);
+ return Geom::Point(vp[0], vp[1]);
}
double
@@ -360,8 +361,8 @@ persp3d_rotate_VP (Persp3D *persp, Proj::Axis axis, double angle, bool alt_press
return;
}
Proj::Pt2 v_dir_proj (persp->tmat.column(axis));
- NR::Point v_dir (v_dir_proj[0], v_dir_proj[1]);
- double a = NR::atan2 (v_dir) * 180/M_PI;
+ Geom::Point v_dir (v_dir_proj[0], v_dir_proj[1]);
+ double a = Geom::atan2 (v_dir) * 180/M_PI;
a += alt_pressed ? 0.5 * ((angle > 0 ) - (angle < 0)) : angle; // the r.h.s. yields +/-0.5 or angle
persp->tmat.set_infinite_direction (axis, a);
@@ -375,7 +376,7 @@ persp3d_update_with_point (Persp3D *persp, Proj::Axis const axis, Proj::Pt2 cons
}
void
-persp3d_apply_affine_transformation (Persp3D *persp, NR::Matrix const &xform) {
+persp3d_apply_affine_transformation (Persp3D *persp, Geom::Matrix const &xform) {
persp->tmat *= xform;
persp3d_update_box_reprs(persp);
SP_OBJECT(persp)->updateRepr(SP_OBJECT_WRITE_EXT);
void
persp3d_add_box_transform (Persp3D *persp, SPBox3D *box) {
- std::map<SPBox3D *, bool>::iterator i = persp->boxes_transformed.find(box);
- if (i != persp->boxes_transformed.end() && (*i).second == true) {
+ std::map<SPBox3D *, bool>::iterator i = persp->boxes_transformed->find(box);
+ if (i != persp->boxes_transformed->end() && (*i).second == true) {
g_print ("Warning! In %s (%d): trying to add transform status for box %d twice when it's already listed as true.\n", SP_OBJECT_REPR(persp)->attribute("id"), persp->my_counter, box->my_counter);
return;
}
- persp->boxes_transformed[box] = false;
+ (*persp->boxes_transformed)[box] = false;
}
void
persp3d_remove_box_transform (Persp3D *persp, SPBox3D *box) {
- persp->boxes_transformed.erase(box);
+ persp->boxes_transformed->erase(box);
}
void
persp3d_set_box_transformed (Persp3D *persp, SPBox3D *box, bool transformed) {
- if (persp->boxes_transformed.find(box) == persp->boxes_transformed.end()) {
+ if (persp->boxes_transformed->find(box) == persp->boxes_transformed->end()) {
g_print ("Warning! In %s (%d): trying to set transform status for box %d, but it is not listed in the perspective!! Aborting.\n",
SP_OBJECT_REPR(persp)->attribute("id"), persp->my_counter,
box->my_counter);
return;
}
- persp->boxes_transformed[box] = transformed;
+ (*persp->boxes_transformed)[box] = transformed;
}
bool
persp3d_was_transformed (Persp3D *persp) {
- if (persp->boxes_transformed.size() == 1) {
+ if (persp->boxes_transformed->size() == 1) {
/* either the transform has not been applied to the single box associated to this perspective yet
or the transform was already reset; in both cases we need to return false because upcoming
transforms need to be applied */
- (*persp->boxes_transformed.begin()).second = false; // make sure the box is marked as untransformed (in case more boxes are added later)
+ (*persp->boxes_transformed->begin()).second = false; // make sure the box is marked as untransformed (in case more boxes are added later)
return false;
}
- for (std::map<SPBox3D *, bool>::iterator i = persp->boxes_transformed.begin();
- i != persp->boxes_transformed.end(); ++i) {
+ for (std::map<SPBox3D *, bool>::iterator i = persp->boxes_transformed->begin();
+ i != persp->boxes_transformed->end(); ++i) {
if ((*i).second == true) {
// at least one of the boxes in the perspective has already been transformed;
return true;
bool
persp3d_all_transformed(Persp3D *persp) {
- for (std::map<SPBox3D *, bool>::iterator i = persp->boxes_transformed.begin();
- i != persp->boxes_transformed.end(); ++i) {
+ for (std::map<SPBox3D *, bool>::iterator i = persp->boxes_transformed->begin();
+ i != persp->boxes_transformed->end(); ++i) {
if ((*i).second == false) {
return false;
}
void
persp3d_unset_transforms(Persp3D *persp) {
- for (std::map<SPBox3D *, bool>::iterator i = persp->boxes_transformed.begin();
- i != persp->boxes_transformed.end(); ++i) {
+ for (std::map<SPBox3D *, bool>::iterator i = persp->boxes_transformed->begin();
+ i != persp->boxes_transformed->end(); ++i) {
(*i).second = false;
}
}
return true;
}
+/**
+ * For each perspective having a box in \a selection, determine all its unselected boxes.
+ */
// TODO: Check where we can use pass-by-reference (or so) instead of recreating all the lists afresh.
std::map<Persp3D *, std::list<SPBox3D *> >
persp3d_unselected_boxes(Inkscape::Selection *selection) {
for (j = persp->boxes.begin(); j != persp->boxes.end(); ++j) {
SPBox3D *box = *j;
// ... check whether it is unselected, and if so add it to the list
- if (persp->boxes_transformed.find(box) == persp->boxes_transformed.end()) {
+ if (persp->boxes_transformed->find(box) == persp->boxes_transformed->end()) {
punsel[persp].push_back(box);
}
}
return punsel;
}
+/**
+ * Split all perspectives with a box in \a selection by moving their unselected boxes to newly
+ * created perspectives.
+ */
void
persp3d_split_perspectives_according_to_selection(Inkscape::Selection *selection) {
std::map<Persp3D *, std::list<SPBox3D *> > punsel = persp3d_unselected_boxes(selection);
for (std::list<Persp3D *>::iterator j = sel_persps.begin(); j != sel_persps.end(); ++j) {
Persp3D *persp = SP_PERSP3D(*j);
g_print (" %s (%d): ", SP_OBJECT_REPR(persp)->attribute("id"), persp->my_counter);
- for (std::map<SPBox3D *, bool>::iterator i = persp->boxes_transformed.begin();
- i != persp->boxes_transformed.end(); ++i) {
+ for (std::map<SPBox3D *, bool>::iterator i = persp->boxes_transformed->begin();
+ i != persp->boxes_transformed->end(); ++i) {
g_print ("<%d,%d> ", (*i).first->my_counter, (*i).second);
}
g_print ("\n");