diff --git a/src/oping.c b/src/oping.c
index ce2a08f75d54eb0e48a9ffc1fbe23986ceadc2a3..5e63392092acbaa7b3dea0d76be3161c5e846cbd 100644 (file)
--- a/src/oping.c
+++ b/src/oping.c
/* 1000 + one "infinity" bucket. */
#define OPING_HISTOGRAM_BUCKETS 1001
- uint32_t *latency_histogram;
+ uint32_t *histogram_counters;
+ uint32_t *histogram_accumulated;
+ double *histogram_ratio;
size_t latency_histogram_size;
#if USE_NCURSES
ret->latency_total_square = 0.0;
ret->latency_histogram_size = (size_t) OPING_HISTOGRAM_BUCKETS;
- ret->latency_histogram = calloc (ret->latency_histogram_size,
- sizeof (*ret->latency_histogram));
+ ret->histogram_counters = calloc (ret->latency_histogram_size,
+ sizeof (*ret->histogram_counters));
+ ret->histogram_accumulated = calloc (ret->latency_histogram_size,
+ sizeof (*ret->histogram_accumulated));
+ ret->histogram_ratio = calloc (ret->latency_histogram_size,
+ sizeof (*ret->histogram_ratio));
#if USE_NCURSES
ret->window = NULL;
}
#endif
- free (context->latency_histogram);
- context->latency_histogram = NULL;
+ free (context->histogram_counters);
+ context->histogram_counters = NULL;
+
+ free (context->histogram_accumulated);
+ context->histogram_accumulated = NULL;
+
+ free (context->histogram_ratio);
+ context->histogram_ratio = NULL;
free (context);
} /* }}} void context_destroy */
double percentile)
{
double threshold = percentile / 100.0;
- uint32_t accumulated[ctx->latency_histogram_size];
- double ratios[ctx->latency_histogram_size];
double index_to_ms_factor;
- uint32_t num;
size_t i;
+ double ret;
- if (ctx->latency_histogram == NULL)
+ if (ctx->histogram_ratio == NULL)
return (NAN);
- accumulated[0] = ctx->latency_histogram[0];
- for (i = 1; i < ctx->latency_histogram_size; i++)
- accumulated[i] = accumulated[i - 1]
- + ctx->latency_histogram[i];
- num = accumulated[ctx->latency_histogram_size - 1];
-
for (i = 0; i < ctx->latency_histogram_size; i++)
- {
- ratios[i] = ((double) accumulated[i]) / ((double) num);
- if (ratios[i] >= threshold)
+ if (ctx->histogram_ratio[i] >= threshold)
break;
- }
if (i >= ctx->latency_histogram_size)
return (NAN);
/* Multiply with i+1, because we're interested in the _upper_ bound of
* each bucket. */
- return (index_to_ms_factor * ((double) (i + 1)));
+ ret = (index_to_ms_factor * ((double) (i + 1)));
+
+ /* Avoid reporting a higher latency than latency_max. */
+ if (ret > ctx->latency_max)
+ ret = ctx->latency_max;
+
+ return (ret);
} /* }}} double context_get_percentile */
static double context_get_stddev (ping_context_t *ctx) /* {{{ */
" -f filename filename to read hosts from\n"
#if USE_NCURSES
" -u / -U force / disable UTF-8 output\n"
+ " -g graph graph type to draw\n"
#endif
" -P percent Report the n'th percentile of latency\n"
" -Z percent Exit with non-zero exit status if more than this percentage of\n"
opt_show_graph = 1;
else if (strcasecmp ("boxplot", optarg) == 0)
opt_show_graph = 2;
+ else if (strcasecmp ("histogram", optarg) == 0)
+ opt_show_graph = 3;
else
fprintf (stderr, "Unknown graph option: %s\n", optarg);
break;
# endif
} /* }}} _Bool has_utf8 */
-static int update_boxplot (ping_context_t *ctx) /* {{{ */
+static int update_graph_boxplot (ping_context_t *ctx) /* {{{ */
{
- uint32_t *accumulated;
double *ratios;
- uint32_t num;
size_t i;
size_t x_max;
size_t x;
x_max = (size_t) getmaxx (ctx->window);
- if (x_max <= 4)
+ if (x_max <= 8)
return (EINVAL);
x_max -= 4;
- accumulated = calloc (x_max, sizeof (*accumulated));
ratios = calloc (x_max, sizeof (*ratios));
/* Downsample */
for (i = 0; i < ctx->latency_histogram_size; i++)
{
x = i * x_max / ctx->latency_histogram_size;
- accumulated[x] += ctx->latency_histogram[i];
+ ratios[x] = ctx->histogram_ratio[i];
}
- /* Sum */
- for (x = 1; x < x_max; x++)
- accumulated[x] += accumulated[x - 1];
-
- num = accumulated[x_max - 1];
-
- /* Calculate ratios */
- for (x = 0; x < x_max; x++)
- ratios[x] = ((double) accumulated[x]) / ((double) num);
-
for (x = 0; x < x_max; x++)
{
int symbol = ' ';
}
free (ratios);
- free (accumulated);
return (0);
-} /* }}} int update_boxplot */
+} /* }}} int update_graph_boxplot */
-static int update_prettyping_graph (ping_context_t *ctx, /* {{{ */
+static int update_graph_prettyping (ping_context_t *ctx, /* {{{ */
double latency, unsigned int sequence)
{
int color = OPING_RED;
wprintw (ctx->window, " ");
return (0);
-} /* }}} int update_prettyping_graph */
+} /* }}} int update_graph_prettyping */
+
+static int update_graph_histogram (ping_context_t *ctx) /* {{{ */
+{
+ uint32_t *counters;
+ uint32_t *accumulated;
+ uint32_t num;
+ uint32_t max;
+ size_t i;
+ size_t x_max;
+ size_t x;
+
+ size_t symbols_num = hist_symbols_acs_num;
+
+ if (has_utf8 ())
+ symbols_num = hist_symbols_utf8_num;
+
+ x_max = (size_t) getmaxx (ctx->window);
+ if (x_max <= 4)
+ return (EINVAL);
+ x_max -= 4;
+
+ counters = calloc (x_max, sizeof (*counters));
+ accumulated = calloc (x_max, sizeof (*accumulated));
+
+ /* Downsample */
+ max = 0;
+ for (i = 0; i < ctx->latency_histogram_size; i++)
+ {
+ x = i * x_max / ctx->latency_histogram_size;
+ counters[x] += ctx->histogram_counters[i];
+ accumulated[x] = counters[x];
+
+ if (max < counters[x])
+ max = counters[x];
+ }
+
+ /* Sum */
+ for (x = 1; x < x_max; x++)
+ accumulated[x] += accumulated[x - 1];
+ num = accumulated[x_max - 1];
+
+ /* Calculate ratios */
+ for (x = 0; x < x_max; x++)
+ {
+ double height = ((double) counters[x]) / ((double) max);
+ double ratio_this = ((double) accumulated[x]) / ((double) num);
+ double ratio_prev = 0.0;
+ size_t index;
+ int color = 0;
+
+ index = (size_t) (height * ((double) symbols_num));
+ if (index >= symbols_num)
+ index = symbols_num - 1;
+
+ if (x > 0)
+ ratio_prev = ((double) accumulated[x - 1]) / ((double) num);
+
+ if (has_colors () == TRUE)
+ {
+ if ((ratio_this <= 0.5) || ((ratio_prev < 0.5) && (ratio_this > 0.5)))
+ color = OPING_GREEN;
+ else if ((ratio_this <= 0.95) || ((ratio_prev < 0.95) && (ratio_this > 0.95)))
+ color = OPING_YELLOW;
+ else
+ color = OPING_RED;
+
+ wattron (ctx->window, COLOR_PAIR(color));
+ }
+
+ if (counters[x] == 0)
+ mvwaddch (ctx->window, /* y = */ 3, /* x = */ x + 2, ' ');
+ else if (has_utf8 ())
+ mvwprintw (ctx->window, /* y = */ 3, /* x = */ x + 2,
+ hist_symbols_utf8[index]);
+ else
+ mvwaddch (ctx->window, /* y = */ 3, /* x = */ x + 2,
+ hist_symbols_acs[index] | A_ALTCHARSET);
+
+ if (has_colors () == TRUE)
+ wattroff (ctx->window, COLOR_PAIR(color));
+
+ }
+
+ free (accumulated);
+ return (0);
+} /* }}} int update_graph_histogram */
static int update_stats_from_context (ping_context_t *ctx, pingobj_iter_t *iter) /* {{{ */
{
@@ -1026,9 +1108,11 @@ static int update_stats_from_context (ping_context_t *ctx, pingobj_iter_t *iter)
}
if (opt_show_graph == 1)
- update_prettyping_graph (ctx, latency, sequence);
+ update_graph_prettyping (ctx, latency, sequence);
else if (opt_show_graph == 2)
- update_boxplot (ctx);
+ update_graph_boxplot (ctx);
+ else if (opt_show_graph == 3)
+ update_graph_histogram (ctx);
wrefresh (ctx->window);
@@ -1222,9 +1306,24 @@ static int post_sleep_hook (__attribute__((unused)) pingobj_t *ping) /* {{{ */
} /* }}} int post_sleep_hook */
#endif
+static size_t latency_to_bucket (ping_context_t *ctx, double latency) /* {{{ */
+{
+ size_t bucket;
+
+ /* latency is in ms, opt_interval is in s. */
+ bucket = (size_t) ((latency * (ctx->latency_histogram_size - 1))
+ / (1000.0 * opt_interval));
+ if (bucket >= ctx->latency_histogram_size)
+ bucket = ctx->latency_histogram_size - 1;
+
+ return (bucket);
+} /* }}} size_t latency_to_bucket */
+
static void update_context (ping_context_t *context, double latency) /* {{{ */
{
size_t bucket;
+ size_t i;
+ double num;
context->req_rcvd++;
context->latency_total += latency;
@@ -1235,15 +1334,19 @@ static void update_context (ping_context_t *context, double latency) /* {{{ */
if ((context->latency_min < 0.0) || (context->latency_min > latency))
context->latency_min = latency;
- if (context->latency_histogram == NULL)
- return;
+ bucket = latency_to_bucket (context, latency);
+ num = (double) context->req_rcvd;
- /* latency is in ms, opt_interval is in s. */
- bucket = (size_t) ((latency * (context->latency_histogram_size - 1))
- / (1000.0 * opt_interval));
- if (bucket >= context->latency_histogram_size)
- bucket = context->latency_histogram_size - 1;
- context->latency_histogram[bucket]++;
+ context->histogram_counters[bucket]++;
+
+ context->histogram_accumulated[0] = context->histogram_counters[0];
+ context->histogram_ratio[0] = ((double) context->histogram_accumulated[0]) / num;
+ for (i = 1; i < context->latency_histogram_size; i++)
+ {
+ context->histogram_accumulated[i] = context->histogram_accumulated[i - 1]
+ + context->histogram_counters[i];
+ context->histogram_ratio[i] = ((double) context->histogram_accumulated[i]) / num;
+ }
} /* }}} void update_context */
static void update_host_hook (pingobj_iter_t *iter, /* {{{ */
#if USE_NCURSES
if (has_colors () == TRUE)
{
+ size_t bucket;
+ double ratio_this;
+ double ratio_prev;
int color = OPING_GREEN;
- double average = context_get_average (context);
- double stddev = context_get_stddev (context);
- if ((latency < (average - (2 * stddev)))
- || (latency > (average + (2 * stddev))))
- color = OPING_RED;
- else if ((latency < (average - stddev))
- || (latency > (average + stddev)))
+ bucket = latency_to_bucket (context, latency);
+ ratio_this = context->histogram_ratio[bucket];
+ if (bucket > 0)
+ ratio_prev = context->histogram_ratio[bucket - 1];
+ else
+ ratio_prev = 0.0;
+
+ if ((ratio_this <= 0.5) ||
+ ((ratio_prev < 0.5) && (ratio_this > 0.5)))
+ color = OPING_GREEN;
+ else if ((ratio_this <= 0.95) ||
+ ((ratio_prev < 0.95) && (ratio_this > 0.95)))
color = OPING_YELLOW;
+ else
+ color = OPING_RED;
HOST_PRINTF ("%zu bytes from %s (%s): icmp_seq=%u ttl=%i ",
data_len, context->host, context->addr,