frontend: Moved all connection handling operations into connection.c.

[sysdb.git] / src / frontend / connection.c

diff --git a/src/frontend/connection.c b/src/frontend/connection.c
index 90361fe9a65b57a4ebaf8c855d3ca5d430b98f30..eb0ada71e0c6d5c3dc73cc3156396c3bb2690efa 100644 (file)
--- a/src/frontend/connection.c
+++ b/src/frontend/connection.c
@@ -27,16 +27,115 @@
 
 #include "sysdb.h"
 #include "core/error.h"
-#include "frontend/connection.h"
+#include "core/object.h"
+#include "frontend/connection-private.h"
 #include "utils/strbuf.h"
 
 #include <assert.h>
 #include <errno.h>
 
 #include <arpa/inet.h>
+#include <fcntl.h>
 
 #include <string.h>
 
+/*
+ * private data types
+ */
+
+/* name of connection objects */
+#define CONN_FD_PREFIX "conn#"
+#define CONN_FD_PLACEHOLDER "XXXXXXX"
+
+static int
+connection_init(sdb_object_t *obj, va_list ap)
+{
+       sdb_conn_t *conn;
+       int sock_fd;
+       int sock_fl;
+
+       assert(obj);
+       conn = CONN(obj);
+
+       sock_fd = va_arg(ap, int);
+
+       conn->buf = sdb_strbuf_create(/* size = */ 128);
+       if (! conn->buf) {
+               sdb_log(SDB_LOG_ERR, "frontend: Failed to allocate a read buffer "
+                               "for a new connection");
+               return -1;
+       }
+
+       conn->client_addr_len = sizeof(conn->client_addr);
+       conn->fd = accept(sock_fd, (struct sockaddr *)&conn->client_addr,
+                       &conn->client_addr_len);
+
+       if (conn->fd < 0) {
+               char buf[1024];
+               sdb_log(SDB_LOG_ERR, "frontend: Failed to accept remote "
+                               "connection: %s", sdb_strerror(errno,
+                                       buf, sizeof(buf)));
+               return -1;
+       }
+
+       if (conn->client_addr.ss_family != AF_UNIX) {
+               sdb_log(SDB_LOG_ERR, "frontend: Accepted connection using "
+                               "unexpected family type %d", conn->client_addr.ss_family);
+               return -1;
+       }
+
+       sock_fl = fcntl(conn->fd, F_GETFL);
+       if (fcntl(conn->fd, F_SETFL, sock_fl | O_NONBLOCK)) {
+               char buf[1024];
+               sdb_log(SDB_LOG_ERR, "frontend: Failed to switch connection conn#%i "
+                               "to non-blocking mode: %s", conn->fd,
+                               sdb_strerror(errno, buf, sizeof(buf)));
+               return -1;
+       }
+
+       sdb_log(SDB_LOG_DEBUG, "frontend: Accepted connection on fd=%i",
+                       conn->fd);
+
+       conn->cmd = CONNECTION_IDLE;
+       conn->cmd_len = 0;
+
+       /* update the object name */
+       snprintf(obj->name + strlen(CONN_FD_PREFIX),
+                       strlen(CONN_FD_PLACEHOLDER), "%i", conn->fd);
+       return 0;
+} /* connection_init */
+
+static void
+connection_destroy(sdb_object_t *obj)
+{
+       sdb_conn_t *conn;
+       size_t len;
+
+       assert(obj);
+       conn = CONN(obj);
+
+       if (conn->buf) {
+               len = sdb_strbuf_len(conn->buf);
+               if (len)
+                       sdb_log(SDB_LOG_INFO, "frontend: Discarding incomplete command "
+                                       "(%zu byte%s left in buffer)", len, len == 1 ? "" : "s");
+       }
+
+       sdb_log(SDB_LOG_DEBUG, "frontend: Closing connection on fd=%i",
+                       conn->fd);
+       close(conn->fd);
+       conn->fd = -1;
+
+       sdb_strbuf_destroy(conn->buf);
+       conn->buf = NULL;
+} /* connection_destroy */
+
+static sdb_type_t connection_type = {
+       /* size = */ sizeof(sdb_conn_t),
+       /* init = */ connection_init,
+       /* destroy = */ connection_destroy,
+};
+
 /*
  * connection handler functions
  */
@@ -139,49 +238,23 @@ connection_read(sdb_conn_t *conn)
  * public API
  */
 
-int
-sdb_connection_init(sdb_conn_t *conn)
+sdb_conn_t *
+sdb_connection_accept(int fd)
 {
-       if (conn->buf) {
-               sdb_log(SDB_LOG_WARNING, "frontend: Attempted to re-initialize "
-                               "a frontend connection");
-               return -1;
-       }
-
-       conn->buf = sdb_strbuf_create(/* size = */ 128);
-       if (! conn->buf) {
-               sdb_log(SDB_LOG_ERR, "frontend: Failed to allocate a read buffer "
-                               "for a new connection");
-               sdb_connection_close(conn);
-               return -1;
-       }
+       if (fd < 0)
+               return NULL;
 
-       conn->cmd = CONNECTION_IDLE;
-       conn->cmd_len = 0;
-       conn->fd = -1;
-       return 0;
-} /* sdb_connection_init */
+       /* the placeholder will be replaced with the accepted file
+        * descriptor when initializing the object */
+       return CONN(sdb_object_create(CONN_FD_PREFIX CONN_FD_PLACEHOLDER,
+                               connection_type, fd));
+} /* sdb_connection_create */
 
 void
 sdb_connection_close(sdb_conn_t *conn)
 {
-       size_t len;
-
-       if (conn->buf) {
-               len = sdb_strbuf_len(conn->buf);
-               if (len)
-                       sdb_log(SDB_LOG_INFO, "frontend: Discarding incomplete command "
-                                       "(%zu byte%s left in buffer)", len, len == 1 ? "" : "s");
-       }
-
-       sdb_log(SDB_LOG_DEBUG, "frontend: Closing connection on fd=%i",
-                       conn->fd);
-       close(conn->fd);
-       conn->fd = -1;
-
-       sdb_strbuf_destroy(conn->buf);
-       conn->buf = NULL;
-} /* sdb_connection_fini */
+       sdb_object_deref(SDB_OBJ(conn));
+} /* sdb_connection_close */
 
 ssize_t
 sdb_connection_read(sdb_conn_t *conn)