frontend: Clear the error buffer when initializing a new command.

[sysdb.git] / src / frontend / connection.c

diff --git a/src/frontend/connection.c b/src/frontend/connection.c
index 93829ab248dc3992eca7124b1c6a8f95bd035345..3d288410ee357ae4317477e255791afbc5bb5251 100644 (file)
--- a/src/frontend/connection.c
+++ b/src/frontend/connection.c
@@ -145,6 +145,10 @@ connection_destroy(sdb_object_t *obj)
                close(conn->fd);
        conn->fd = -1;
 
+       if (conn->username)
+               free(conn->username);
+       conn->username = NULL;
+
        sdb_strbuf_destroy(conn->buf);
        conn->buf = NULL;
        sdb_strbuf_destroy(conn->errbuf);
@@ -261,14 +265,12 @@ command_handle(sdb_conn_t *conn)
 
        if ((! conn->username) && (conn->cmd != CONNECTION_STARTUP)) {
                const char *errmsg = "Authentication required";
+               sdb_strbuf_sprintf(conn->errbuf, errmsg);
                sdb_connection_send(conn, CONNECTION_ERROR,
                                (uint32_t)strlen(errmsg), errmsg);
                return -1;
        }
 
-       /* reset */
-       sdb_strbuf_sprintf(conn->errbuf, "");
-
        switch (conn->cmd) {
                case CONNECTION_PING:
                        status = sdb_connection_ping(conn);
@@ -355,12 +357,6 @@ command_handle(sdb_conn_t *conn)
                sdb_connection_send(conn, CONNECTION_ERROR,
                                (uint32_t)sdb_strbuf_len(conn->errbuf),
                                sdb_strbuf_string(conn->errbuf));
-
-       /* remove the command from the buffer */
-       if (conn->cmd_len)
-               sdb_strbuf_skip(conn->buf, 0, conn->cmd_len);
-       conn->cmd = CONNECTION_IDLE;
-       conn->cmd_len = 0;
        return status;
 } /* command_handle */
 
@@ -372,6 +368,9 @@ command_init(sdb_conn_t *conn)
 
        assert(conn && (conn->cmd == CONNECTION_IDLE) && (! conn->cmd_len));
 
+       /* reset */
+       sdb_strbuf_sprintf(conn->errbuf, "");
+
        conn->cmd = connection_get_int32(conn, 0);
        conn->cmd_len = connection_get_int32(conn, sizeof(uint32_t));
 
@@ -464,9 +463,16 @@ sdb_connection_read(sdb_conn_t *conn)
                                && (sdb_strbuf_len(conn->buf) >= 2 * sizeof(int32_t)))
                        command_init(conn);
                if ((conn->cmd != CONNECTION_IDLE)
-                               && (sdb_strbuf_len(conn->buf) >= conn->cmd_len))
+                               && (sdb_strbuf_len(conn->buf) >= conn->cmd_len)) {
                        command_handle(conn);
 
+                       /* remove the command from the buffer */
+                       if (conn->cmd_len)
+                               sdb_strbuf_skip(conn->buf, 0, conn->cmd_len);
+                       conn->cmd = CONNECTION_IDLE;
+                       conn->cmd_len = 0;
+               }
+
                if (status <= 0)
                        break;