![[tokkee]](http://tokkee.org/images/avatar.png){kind=avatar}
diff --git a/plugins/check_tcp.c b/plugins/check_tcp.c
index e3fac22e103a49daa48ba0212529e6d8d9281b62..8a42a6439d28fc0b5499a7b789b239b10b54be4a 100644 (file)
--- a/plugins/check_tcp.c
+++ b/plugins/check_tcp.c
*
*****************************************************************************/
-#define PROGRAM check_tcp
#define REVISION "$Revision$"
#define DESCRIPTION "Check a TCP port"
#define AUTHOR "Ethan Galstad"
void print_usage (void);
void print_help (void);
-char *PROGNAME = NULL;
+char *progname = "check_tcp";
char *SERVICE = NULL;
char *SEND = NULL;
char *EXPECT = NULL;
double elapsed_time = 0;
int verbose = FALSE;
int use_ssl = FALSE;
-int sd;
+int sd = 0;
int
main (int argc, char **argv)
{
int result;
int i;
- char buffer[MAX_INPUT_BUFFER] = "";
+ char *buffer = "";
char *status = "";
- char *output = NULL;
- char *ptr = NULL;
struct timeval tv;
if (strstr (argv[0], "check_udp")) {
- PROGNAME = strscpy (PROGNAME, "check_udp");
- SERVICE = strscpy (SERVICE, "UDP");
+ asprintf (&progname, "check_udp");
+ asprintf (&SERVICE, "UDP");
SEND = NULL;
EXPECT = NULL;
QUIT = NULL;
PORT = 0;
}
else if (strstr (argv[0], "check_tcp")) {
- PROGNAME = strscpy (PROGNAME, "check_tcp");
- SERVICE = strscpy (SERVICE, "TCP");
+ asprintf (&progname, "check_tcp");
+ asprintf (&SERVICE, "TCP");
SEND = NULL;
EXPECT = NULL;
QUIT = NULL;
PORT = 0;
}
else if (strstr (argv[0], "check_ftp")) {
- PROGNAME = strscpy (PROGNAME, "check_ftp");
- SERVICE = strscpy (SERVICE, "FTP");
+ asprintf (&progname, "check_ftp");
+ asprintf (&SERVICE, "FTP");
SEND = NULL;
- EXPECT = strscpy (EXPECT, "220");
- QUIT = strscpy (QUIT, "QUIT\r\n");
+ asprintf (&EXPECT, "220");
+ asprintf (&QUIT, "QUIT\r\n");
PROTOCOL = TCP_PROTOCOL;
PORT = 21;
}
else if (strstr (argv[0], "check_smtp")) {
- PROGNAME = strscpy (PROGNAME, "check_smtp");
- SERVICE = strscpy (SERVICE, "SMTP");
+ asprintf (&progname, "check_smtp");
+ asprintf (&SERVICE, "SMTP");
SEND = NULL;
- EXPECT = strscpy (EXPECT, "220");
- QUIT = strscpy (QUIT, "QUIT\r\n");
+ asprintf (&EXPECT, "220");
+ asprintf (&QUIT, "QUIT\r\n");
PROTOCOL = TCP_PROTOCOL;
PORT = 25;
}
else if (strstr (argv[0], "check_pop")) {
- PROGNAME = strscpy (PROGNAME, "check_pop");
- SERVICE = strscpy (SERVICE, "POP");
+ asprintf (&progname, "check_pop");
+ asprintf (&SERVICE, "POP");
SEND = NULL;
- EXPECT = strscpy (EXPECT, "110");
- QUIT = strscpy (QUIT, "QUIT\r\n");
+ asprintf (&EXPECT, "+OK");
+ asprintf (&QUIT, "QUIT\r\n");
PROTOCOL = TCP_PROTOCOL;
PORT = 110;
}
else if (strstr (argv[0], "check_imap")) {
- PROGNAME = strscpy (PROGNAME, "check_imap");
- SERVICE = strscpy (SERVICE, "IMAP");
+ asprintf (&progname, "check_imap");
+ asprintf (&SERVICE, "IMAP");
SEND = NULL;
- EXPECT = strscpy (EXPECT, "* OK");
- QUIT = strscpy (QUIT, "a1 LOGOUT\r\n");
+ asprintf (&EXPECT, "* OK");
+ asprintf (&QUIT, "a1 LOGOUT\r\n");
PROTOCOL = TCP_PROTOCOL;
PORT = 143;
}
#ifdef HAVE_SSL
else if (strstr(argv[0],"check_simap")) {
- PROGNAME=strscpy(PROGNAME,"check_simap");
- SERVICE=strscpy(SERVICE,"SIMAP");
+ asprintf (&progname, "check_simap");
+ asprintf (&SERVICE, "SIMAP");
SEND=NULL;
- EXPECT=strscpy(EXPECT,"* OK");
- QUIT=strscpy(QUIT,"a1 LOGOUT\r\n");
+ asprintf (&EXPECT, "* OK");
+ asprintf (&QUIT, "a1 LOGOUT\r\n");
PROTOCOL=TCP_PROTOCOL;
use_ssl=TRUE;
PORT=993;
}
else if (strstr(argv[0],"check_spop")) {
- PROGNAME=strscpy(PROGNAME,"check_spop");
- SERVICE=strscpy(SERVICE,"SPOP");
+ asprintf (&progname, "check_spop");
+ asprintf (&SERVICE, "SPOP");
SEND=NULL;
- EXPECT=strscpy(EXPECT,"110");
- QUIT=strscpy(QUIT,"QUIT\r\n");
+ asprintf (&EXPECT, "+OK");
+ asprintf (&QUIT, "QUIT\r\n");
PROTOCOL=TCP_PROTOCOL;
use_ssl=TRUE;
PORT=995;
}
#endif
else if (strstr (argv[0], "check_nntp")) {
- PROGNAME = strscpy (PROGNAME, "check_nntp");
- SERVICE = strscpy (SERVICE, "NNTP");
+ asprintf (&progname, "check_nntp");
+ asprintf (&SERVICE, "NNTP");
SEND = NULL;
EXPECT = NULL;
server_expect = realloc (server_expect, ++server_expect_count);
- server_expect[server_expect_count - 1] = strscpy (EXPECT, "200");
+ asprintf (&server_expect[server_expect_count - 1], "200");
server_expect = realloc (server_expect, ++server_expect_count);
- server_expect[server_expect_count - 1] = strscpy (NULL, "201");
- QUIT = strscpy (QUIT, "QUIT\r\n");
+ asprintf (&server_expect[server_expect_count - 1], "201");
+ asprintf (&QUIT, "QUIT\r\n");
PROTOCOL = TCP_PROTOCOL;
PORT = 119;
}
usage ("ERROR: Generic check_tcp called with unknown service\n");
}
- server_address = strscpy (NULL, "127.0.0.1");
+ asprintf (&server_address, "127.0.0.1");
server_port = PORT;
server_send = SEND;
server_quit = QUIT;
/* use default expect if none listed in process_arguments() */
if (EXPECT && server_expect_count == 0) {
- server_expect = malloc (1);
+ server_expect = malloc (++server_expect_count);
server_expect[server_expect_count - 1] = EXPECT;
}
if (server_send || server_expect_count > 0) {
+ buffer = malloc (MAX_INPUT_BUFFER);
/* watch for the expect string */
#ifdef HAVE_SSL
- if (use_ssl && SSL_read (ssl, buffer, MAX_INPUT_BUFFER - 1)>=0)
+ if (use_ssl && SSL_read (ssl, buffer, MAX_INPUT_BUFFER - 1) > 0)
asprintf (&status, "%s%s", status, buffer);
else
#endif
- {
- if (recv (sd, buffer, MAX_INPUT_BUFFER - 1, 0) >= 0)
- asprintf (&status, "%s%s", status, buffer);
- }
- strip (status);
+ if (recv (sd, buffer, MAX_INPUT_BUFFER - 1, 0) > 0)
+ asprintf (&status, "%s%s", status, buffer);
/* return a CRITICAL status if we couldn't read any data */
if (status == NULL)
terminate (STATE_CRITICAL, "No data received from host\n");
+ strip (status);
+
if (status && verbose)
printf ("%s\n", status);
if (use_ssl) {
SSL_write (ssl, QUIT, strlen (QUIT));
SSL_shutdown (ssl);
- SSL_free (ssl);
- SSL_CTX_free (ctx);
+ SSL_free (ssl);
+ SSL_CTX_free (ctx);
}
else
#endif
send (sd, server_quit, strlen (server_quit), 0);
/* close the connection */
- close (sd);
+ if (sd)
+ close (sd);
elapsed_time = delta_time (tv);
SERVICE,
state_text (result), elapsed_time, server_port);
- if (strlen (status))
+ if (status && strlen(status) > 0)
printf (" [%s]", status);
printf ("|time=%7.3f\n", elapsed_time);
switch (c) {
case '?': /* print short usage statement if args not parsable */
- printf ("%s: Unknown argument: %s\n\n", my_basename (argv[0]), optarg);
+ printf ("%s: Unknown argument: %s\n\n", progname, optarg);
print_usage ();
exit (STATE_UNKNOWN);
case 'h': /* help */
print_help ();
exit (STATE_OK);
case 'V': /* version */
- print_revision (PROGNAME, "$Revision$");
+ print_revision (progname, "$Revision$");
exit (STATE_OK);
case 'v': /* verbose mode */
verbose = TRUE;
break;
case 'H': /* hostname */
if (is_host (optarg) == FALSE)
- usage ("Invalid host name/address\n");
+ usage2 ("invalid host name or address", optarg);
server_address = optarg;
break;
case 'c': /* critical */
{
printf
("Usage: %s -H host -p port [-w warn_time] [-c crit_time] [-s send]\n"
- " [-e expect] [-W wait] [-t to_sec] [-v]\n", PROGNAME);
+ " [-e expect] [-W wait] [-t to_sec] [-v]\n", progname);
}
void
print_help (void)
{
- print_revision (PROGNAME, "$Revision$");
+ print_revision (progname, "$Revision$");
printf
("Copyright (c) 1999 Ethan Galstad (nagios@nagios.org)\n\n"
"This plugin tests %s connections with the specified host.\n\n",