Code

cleanup to suppress various strict compiler warnings
[nagiosplug.git] / plugins / check_nt.c
index 65c4e693adb4945cd0da4d6da15b963351fc32da..9652fa6b04d322bc70ce3a8d6e1573de80e5ad36 100644 (file)
@@ -28,7 +28,6 @@
  *
  *****************************************************************************/
 
-//#include "stdlib.h"
 #include "config.h"
 #include "common.h"
 #include "netutils.h"
@@ -71,13 +70,11 @@ void preparelist(char *string);
 
 int main(int argc, char **argv){
        int result;
-       int return_code;
+       int return_code = STATE_UNKNOWN;
        char *send_buffer=NULL;
        char recv_buffer[MAX_INPUT_BUFFER];
        char *output_message=NULL;
-       char *temp_buffer=NULL;
        char *temp_string=NULL;
-       char *sep_string=NULL;
        char *description=NULL;
 
        double total_disk_space=0;
@@ -85,18 +82,15 @@ int main(int argc, char **argv){
        double percent_used_space=0;
        double mem_commitLimit=0;
        double mem_commitByte=0;
-       unsigned long current_connections=0;
        unsigned long utilization;
        unsigned long uptime;
-       unsigned long cache_hits;
-       unsigned long cache_buffers;
-       unsigned long lru_time;
        unsigned long age_in_minutes;
        double counter_value;
        int offset=0;
        int updays=0;
        int uphours=0;
        int upminutes=0;
+
        asprintf(&req_password,"None");
 
        if(process_arguments(argc,argv)==ERROR)
@@ -109,27 +103,32 @@ int main(int argc, char **argv){
        alarm(socket_timeout);
 
        if (vars_to_check==CHECK_CLIENTVERSION) {
-                       
+
                asprintf(&send_buffer,strcat(req_password,"&1"));
                result=process_tcp_request(server_address,server_port,send_buffer,recv_buffer,sizeof(recv_buffer));
                if(result!=STATE_OK)
                        return result;
                asprintf(&output_message,recv_buffer);
                return_code=STATE_OK;
+
        }
+
        else if(vars_to_check==CHECK_CPULOAD){
 
                if (check_value_list==TRUE) {                                                                                                                                                   
                        if (strtolarray(&lvalue_list,value_list,",")==TRUE) {
-                               // -l parameters is present with only integers
+                               /* -l parameters is present with only integers */
                                return_code=STATE_OK;
                                asprintf(&temp_string,"CPU Load");
-                               while (lvalue_list[0+offset]>0 && lvalue_list[0+offset]<=17280 && 
-                                                       lvalue_list[1+offset]>=0 && lvalue_list[1+offset]<=100 && 
-                                                       lvalue_list[2+offset]>=0 && lvalue_list[2+offset]<=100) {
-                                       // loop until one of the parameters is wrong or not present
-
-                                       // Send request and retrieve data
+                               while (lvalue_list[0+offset]>(unsigned long)0 &&
+                                      lvalue_list[0+offset]<=(unsigned long)17280 && 
+                                      lvalue_list[1+offset]>=(unsigned long)0 &&
+                                      lvalue_list[1+offset]<=(unsigned long)100 && 
+                                      lvalue_list[2+offset]>=(unsigned long)0 &&
+                                      lvalue_list[2+offset]<=(unsigned long)100) {
+                                       /* loop until one of the parameters is wrong or not present */
+
+                                       /* Send request and retrieve data */
                                        asprintf(&send_buffer,"%s&2&%lu",req_password,lvalue_list[0+offset]);
                                        result=process_tcp_request(server_address,server_port,send_buffer,recv_buffer,sizeof(recv_buffer));
                                        if(result!=STATE_OK)
@@ -142,18 +141,18 @@ int main(int argc, char **argv){
 
                                        utilization=strtoul(recv_buffer,NULL,10);
 
-                                       // Check if any of the request is in a warning or critical state
+                                       /* Check if any of the request is in a warning or critical state */
                                        if(utilization >= lvalue_list[2+offset])
                                                return_code=STATE_CRITICAL;
                                        else if(utilization >= lvalue_list[1+offset] && return_code<STATE_WARNING)
                                                return_code=STATE_WARNING;
 
-                                       asprintf(&output_message," (%lu min. %lu%)",lvalue_list[0+offset], utilization);
+                                       asprintf(&output_message," %lu%% (%lu min average)", utilization, lvalue_list[0+offset]);
                                        asprintf(&temp_string,"%s%s",temp_string,output_message);
-                                       offset+=3;      //move accross the array 
+                                       offset+=3;      /* move across the array */
                                }               
                                if (strlen(temp_string)>10) {
-                                       // we had at least on loop
+                                       /* we had at least on loop */
                                        asprintf(&output_message,"%s",temp_string);
                                }       
                                else
@@ -236,7 +235,7 @@ int main(int argc, char **argv){
        else if(vars_to_check==CHECK_SERVICESTATE || vars_to_check==CHECK_PROCSTATE){
 
                if (check_value_list==TRUE) {
-                       preparelist(value_list);                // replace , between services with & to send the request
+                       preparelist(value_list);                /* replace , between services with & to send the request */
                        asprintf(&send_buffer,"%s&%u&%s&%s", req_password,(vars_to_check==CHECK_SERVICESTATE)?5:6,
                                (show_all==TRUE)?"ShowAll":"ShowFail",value_list);
                        result=process_tcp_request(server_address,server_port,send_buffer,recv_buffer,sizeof(recv_buffer));
@@ -286,7 +285,7 @@ int main(int argc, char **argv){
        else if(vars_to_check==CHECK_COUNTER) {
 
                if (check_value_list==TRUE) {                                                                                                                                                   
-                       preparelist(value_list);                // replace , between services with & to send the request
+                       preparelist(value_list);                /* replace , between services with & to send the request */
                        asprintf(&send_buffer,"%s&8&%s", req_password,value_list);
                        result=process_tcp_request(server_address,server_port,send_buffer,recv_buffer,sizeof(recv_buffer));
                        if (result!=STATE_OK)
@@ -297,7 +296,7 @@ int main(int argc, char **argv){
                                exit(STATE_UNKNOWN);
                        }
 
-                       strtok(value_list,"&");                 // burn the first parameters
+                       strtok(value_list,"&");                 /* burn the first parameters */
                        description = strtok(NULL,"&");
                        counter_value = atof(recv_buffer);
                        if (description == NULL) 
@@ -306,7 +305,7 @@ int main(int argc, char **argv){
                                asprintf(&output_message, description, counter_value);
        
                        if (critical_value > warning_value) {
-                               // Normal thresholds            
+                               /* Normal thresholds */
                                if(check_critical_value==TRUE && counter_value >= critical_value)
                                        return_code=STATE_CRITICAL;
                                else if (check_warning_value==TRUE && counter_value >= warning_value)
@@ -315,7 +314,7 @@ int main(int argc, char **argv){
                                        return_code=STATE_OK;   
                        } 
                        else {
-                               // inverse thresholds           
+                               /* inverse thresholds */
                                if(check_critical_value==TRUE && counter_value <= critical_value)
                                        return_code=STATE_CRITICAL;
                                else if (check_warning_value==TRUE && counter_value <= warning_value)
@@ -333,7 +332,7 @@ int main(int argc, char **argv){
        else if(vars_to_check==CHECK_FILEAGE) {
 
                if (check_value_list==TRUE) {                                                                                                                                                   
-                       preparelist(value_list);                // replace , between services with & to send the request
+                       preparelist(value_list);                /* replace , between services with & to send the request */
                        asprintf(&send_buffer,"%s&9&%s", req_password,value_list);
                        result=process_tcp_request(server_address,server_port,send_buffer,recv_buffer,sizeof(recv_buffer));
                        if (result!=STATE_OK)
@@ -349,7 +348,7 @@ int main(int argc, char **argv){
                        asprintf(&output_message, description);
        
                        if (critical_value > warning_value) {
-                               // Normal thresholds            
+                               /* Normal thresholds */
                                if(check_critical_value==TRUE && age_in_minutes >= critical_value)
                                        return_code=STATE_CRITICAL;
                                else if (check_warning_value==TRUE && age_in_minutes >= warning_value)
@@ -358,7 +357,7 @@ int main(int argc, char **argv){
                                        return_code=STATE_OK;   
                        } 
                        else {
-                               // inverse thresholds           
+                               /* inverse thresholds */
                                if(check_critical_value==TRUE && age_in_minutes <= critical_value)
                                        return_code=STATE_CRITICAL;
                                else if (check_warning_value==TRUE && age_in_minutes <= warning_value)
@@ -387,7 +386,6 @@ int main(int argc, char **argv){
 int process_arguments(int argc, char **argv){
        int c;
 
-#ifdef HAVE_GETOPT_H
        int option_index = 0;
        static struct option long_options[] =
        { 
@@ -401,7 +399,6 @@ int process_arguments(int argc, char **argv){
                {"help",     no_argument,      0,'h'},
                {0,0,0,0}
        };
-#endif
 
        /* no options were supplied */
        if(argc<2) return ERROR;
@@ -424,11 +421,7 @@ int process_arguments(int argc, char **argv){
        }
 
        while (1){
-#ifdef HAVE_GETOPT_H
                c = getopt_long(argc,argv,"+hVH:t:c:w:p:v:l:s:d:",long_options,&option_index);
-#else
-               c = getopt(argc,argv,"+hVH:t:c:w:p:v:l:s:d:");
-#endif
 
                if (c==-1||c==EOF||c==1)
                        break;
@@ -505,67 +498,93 @@ int process_arguments(int argc, char **argv){
 
        }
 
+       if (vars_to_check==CHECK_NONE)
+               return ERROR;
+
        return OK;
 }
 
 
 void print_usage(void)
 {
-       printf("Usage: %s -H host [-p port] [-v variable] [-w warning] [-c critical] [-l params] [-d SHOWALL] [-t timeout]\n",progname);
+       printf("Usage: %s -H host -v variable [-p port] [-w warning] [-c critical] [-l params] [-d SHOWALL] [-t timeout]\n",progname);
 }
 
 
 void print_help(void)
 {
        print_revision(progname,"$Revision$");
-       printf
-               ("Copyright (c) 2000 Yves Rubin (rubiyz@yahoo.com)\n\n"
-                "This plugin attempts to contact the NSClient service running on a Windows NT/2000/XP server to\n"
-                "gather the requested system information.\n\n");
+       printf ("\
+Copyright (c) 2000 Yves Rubin (rubiyz@yahoo.com)\n\n\
+This plugin collects data from the NSClient service running on a\n\
+Windows NT/2000/XP server.\n\n");
        print_usage();
-  printf
-               ("\nOptions:\n"
-                "-H, --hostname=HOST\n"
-                "   Name of the host to check\n"
-                "-p, --port=INTEGER\n"
-                "   Optional port number (default: %d)\n"
-                "-s <password>\n"
-                "   Password needed for the request\n"
-                "-v, --variable=STRING\n"
-                "   Variable to check.  Valid variables are:\n"
-                "      CLIENTVERSION = Get the NSClient version\n"
-                "      CPULOAD = Average CPU load on last x minutes. Request a -l parameter with the following syntax:\n"
-                "        -l <minutes range>,<warning threshold>,<critical threshold>. <minute range> should be less than 24*60.\n"
-                "        Thresholds are percentage and up to 10 requests can be done in one shot. ie: -l 60,90,95,120,90,95\n"
-                "      UPTIME = Get the uptime of the machine. No specific parameters. No warning or critical threshold\n"
-                "      USEDDISKSPACE = Size and percentage of disk use. Request a -l parameter containing the drive letter only.\n"
-                "                      Warning and critical thresholds can be specified with -w and -c.\n"
-                "      MEMUSE = Memory use. Warning and critical thresholds can be specified with -w and -c.\n" 
-                "      SERVICESTATE = Check the state of one or several services. Request a -l parameters with the following syntax:\n"
-                "        -l <service1>,<service2>,<service3>,... You can specify -d SHOWALL in case you want to see working services\n"
-                "        in the returned string.\n"
-                "      PROCSTATE = Check if one or several process are running. Same syntax as SERVICESTATE.\n"
-                "      COUNTER = Check any performance counter of Windows NT/2000. Request a -l parameters with the following syntax:\n"
-                "        -l \"\\\\<performance object>\\\\counter\",\"<description>\"  The <description> parameter is optional and \n"
-                "        is given to a printf output command which require a float parameters. Some examples:\n"
-                "          \"Paging file usage is %%.2f %%%%\" or \"%%.f %%%% paging file used.\"\n"
-                " -w, --warning=INTEGER\n"
-                "   Threshold which will result in a warning status\n"
-                " -c, --critical=INTEGER\n"
-                "   Threshold which will result in a critical status\n"
-                " -t, --timeout=INTEGER\n"
-                "   Seconds before connection attempt times out (default: %d)\n"
-                "-h, --help\n"
-                "   Print this help screen\n"
-                "-V, --version\n"
-                "   Print version information\n\n"
-                "Notes:\n"
-                " - The NSClient service should be running on the server to get any information.\n"
-                " - Critical thresholds should be lower than warning thresholds\n", PORT, DEFAULT_SOCKET_TIMEOUT);
+  printf ("\nOptions:\n\
+-H, --hostname=HOST\n\
+  Name of the host to check\n\
+-p, --port=INTEGER\n\
+  Optional port number (default: %d)\n\
+-s <password>\n\
+  Password needed for the request\n\
+-w, --warning=INTEGER\n\
+  Threshold which will result in a warning status\n\
+-c, --critical=INTEGER\n\
+  Threshold which will result in a critical status\n\
+-t, --timeout=INTEGER\n\
+  Seconds before connection attempt times out (default: %d)\n\
+-h, --help\n\
+  Print this help screen\n\
+-V, --version\n\
+  Print version information\n",
+               PORT, DEFAULT_SOCKET_TIMEOUT);
+  printf ("\
+-v, --variable=STRING\n\
+  Variable to check.  Valid variables are:\n");
+  printf ("\
+   CLIENTVERSION = Get the NSClient version\n");
+  printf ("\
+   CPULOAD = Average CPU load on last x minutes.\n\
+     Request a -l parameter with the following syntax:\n\
+     -l <minutes range>,<warning threshold>,<critical threshold>.\n\
+     <minute range> should be less than 24*60.\n\
+     Thresholds are percentage and up to 10 requests can be done in one shot.\n\
+     ie: -l 60,90,95,120,90,95\n");
+  printf ("\
+   UPTIME = Get the uptime of the machine.\n\
+     No specific parameters. No warning or critical threshold\n");
+  printf ("\
+   USEDDISKSPACE = Size and percentage of disk use.\n\
+     Request a -l parameter containing the drive letter only.\n\
+     Warning and critical thresholds can be specified with -w and -c.\n");
+  printf ("\
+   MEMUSE = Memory use.\n\
+     Warning and critical thresholds can be specified with -w and -c.\n");
+  printf ("\
+   SERVICESTATE = Check the state of one or several services.\n\
+     Request a -l parameters with the following syntax:\n\
+     -l <service1>,<service2>,<service3>,...\n\
+     You can specify -d SHOWALL in case you want to see working services\n\
+                in the returned string.\n");
+  printf ("\
+   PROCSTATE = Check if one or several process are running.\n\
+     Same syntax as SERVICESTATE.\n");
+  printf ("\
+   COUNTER = Check any performance counter of Windows NT/2000.\n\
+     Request a -l parameters with the following syntax:\n\
+                -l \"\\\\<performance object>\\\\counter\",\"<description>\n\
+     The <description> parameter is optional and \n\
+     is given to a printf output command which require a float parameters.\n\
+     Some examples:\n\
+       \"Paging file usage is %%.2f %%%%\"\n\
+       \"%%.f %%%% paging file used.\"\n");
+       printf ("Notes:\n\
+ - The NSClient service should be running on the server to get any information\n\
+   (http://nsclient.ready2run.nl).\n\
+ - Critical thresholds should be lower than warning thresholds\n");
 }
 
 int strtolarray(unsigned long *array, char *string, char *delim) {
-       // split a <delim> delimited string into a long array
+       /* split a <delim> delimited string into a long array */
        int idx=0;
        char *t1;
 
@@ -584,10 +603,10 @@ int strtolarray(unsigned long *array, char *string, char *delim) {
 }
 
 void preparelist(char *string) {
-       // Replace all , with & which is the delimiter for the request
+       /* Replace all , with & which is the delimiter for the request */
        int i;
 
-       for (i = 0; i < strlen(string); i++)
+       for (i = 0; (size_t)i < strlen(string); i++)
                if (string[i] == ',') {
                        string[i]='&';
                }