fixes from richard brodie (tracker id 1216576)

[nagiosplug.git] / plugins / check_mrtgtraf.c

diff --git a/plugins/check_mrtgtraf.c b/plugins/check_mrtgtraf.c
index b9c277b36684d6432513e66cf73b5fbbcdf88737..877072ce2e89f72582815b6924747717bed0658e 100644 (file)
--- a/plugins/check_mrtgtraf.c
+++ b/plugins/check_mrtgtraf.c
@@ -23,7 +23,7 @@
 
 const char *progname = "check_mrtgtraf";
 const char *revision = "$Revision$";
-const char *copyright = "1999-2003";
+const char *copyright = "1999-2004";
 const char *email = "nagiosplug-devel@lists.sourceforge.net";
 
 int process_arguments (int, char **);
@@ -43,7 +43,7 @@ unsigned long outgoing_critical_threshold = 0L;
 int
 main (int argc, char **argv)
 {
-       int result = STATE_OK;
+       int result = STATE_UNKNOWN;
        FILE *fp;
        int line;
        char input_buffer[MAX_INPUT_BUFFER];
@@ -62,13 +62,13 @@ main (int argc, char **argv)
        char incoming_speed_rating[8];
        char outgoing_speed_rating[8];
 
-       if (process_arguments (argc, argv) != OK)
-               usage (_("check_ldap: could not parse arguments\n"));
+       if (process_arguments (argc, argv) == ERROR)
+               usage4 (_("Could not parse arguments"));
 
        /* open the MRTG log file for reading */
        fp = fopen (log_file, "r");
        if (fp == NULL)
-               usage (_("Unable to open MRTG log file\n"));
+               usage4 (_("Unable to open MRTG log file"));
 
        line = 0;
        while (fgets (input_buffer, MAX_INPUT_BUFFER - 1, fp)) {
@@ -110,7 +110,7 @@ main (int argc, char **argv)
 
        /* if we couldn't read enough data, return an unknown error */
        if (line <= 2)
-               usage (_("Unable to process MRTG log file\n"));
+               usage4 (_("Unable to process MRTG log file"));
 
        /* make sure the MRTG data isn't too old */
        time (&current_time);
@@ -260,9 +260,7 @@ process_arguments (int argc, char **argv)
                        print_help ();
                        exit (STATE_OK);
                case '?':                                                                       /* help */
-                       printf (_("%s: Unknown argument: %s\n\n"), progname, optarg);
-                       print_usage ();
-                       exit (STATE_UNKNOWN);
+                       usage2 (_("Unknown argument"), optarg);
                }
        }
 
@@ -304,7 +302,6 @@ process_arguments (int argc, char **argv)
 }
 
 
-
 int
 validate_arguments (void)
 {
@@ -312,7 +309,6 @@ validate_arguments (void)
 }
 
 
-
 void
 print_help (void)
 {
@@ -321,6 +317,14 @@ print_help (void)
        printf ("Copyright (c) 1999 Ethan Galstad <nagios@nagios.org>\n");
        printf (COPYRIGHT, copyright, email);
 
+       printf (_("\n\
+This plugin will check the incoming/outgoing transfer rates of a router,\n\
+switch, etc recorded in an MRTG log.  If the newest log entry is older\n\
+than <expire_minutes>, a WARNING status is returned. If either the\n\
+incoming or outgoing rates exceed the <icl> or <ocl> thresholds (in\n\
+Bytes/sec), a CRITICAL status results.  If either of the rates exceed\n\
+the <iwl> or <owl> thresholds (in Bytes/sec), a WARNING status results.\n\n"));
+
        print_usage ();
 
        printf (_(UT_HELP_VRSN));
@@ -337,14 +341,6 @@ print_help (void)
  -c, --critical\n\
    Critical threshold pair \"<incoming>,<outgoing>\"\n"));
 
-       printf (_("\n\
-This plugin will check the incoming/outgoing transfer rates of a router,\n\
-switch, etc recorded in an MRTG log.  If the newest log entry is older\n\
-than <expire_minutes>, a WARNING status is returned. If either the\n\
-incoming or outgoing rates exceed the <icl> or <ocl> thresholds (in\n\
-Bytes/sec), a CRITICAL status results.  If either of the rates exceed\n\
-the <iwl> or <owl> thresholds (in Bytes/sec), a WARNING status results.\n\n"));
-
        printf (_("Notes:\n\
 - MRTG stands for Multi Router Traffic Grapher. It can be downloaded from\n\
   http://ee-staff.ethz.ch/~oetiker/webtools/mrtg/mrtg.html\n\
@@ -359,12 +355,10 @@ the <iwl> or <owl> thresholds (in Bytes/sec), a WARNING status results.\n\n"));
 
 
 
-
 void
 print_usage (void)
 {
-       printf (_("\
-Usage: %s -F <log_file> -a <AVG | MAX> -v <variable> -w <warning_pair> -c <critical_pair>\n\
-  [-e expire_minutes] [-t timeout] [-v]\n"), progname);
-       printf (_(UT_HLP_VRS), progname, progname);
+       printf ("\
+Usage: %s -F <log_file> -a <AVG | MAX> -v <variable> -w <warning_pair>\n\
+                      -c <critical_pair> [-e expire_minutes] [-t timeout] [-v]\n", progname);
 }