![[tokkee]](http://tokkee.org/images/avatar.png){kind=avatar}
diff --git a/plugins/check_ldap.c b/plugins/check_ldap.c
index d3f061589028957b80c07e0c45f9d4dc2935d310..ac11c58f03975fd0de85fc1d08ae5e064818b881 100644 (file)
--- a/plugins/check_ldap.c
+++ b/plugins/check_ldap.c
*
*****************************************************************************/
-#define PROGNAME "check_ldap"
-#define REVISION "$Revision$"
+const char *progname = "check_ldap";
+const char *revision = "$Revision$";
#include "config.h"
#include "common.h"
#include <lber.h>
#include <ldap.h>
-#define UNKNOWN -1
+enum {
+ UNDEFINED = -1,
+ DEFAULT_PORT = 389
+};
int process_arguments (int, char **);
-int call_getopt (int, char **);
int validate_arguments (void);
-static void print_help (void);
-static void print_usage (void);
+void print_help (void);
+void print_usage (void);
char ld_defattr[] = "(objectclass=*)";
char *ld_attr = ld_defattr;
-char *ld_host = NULL, *ld_base = NULL, *ld_passwd = NULL, *ld_binddn = NULL;
-unsigned int ld_port = 389;
-int warn_time = UNKNOWN, crit_time = UNKNOWN;
+char *ld_host = "";
+char *ld_base = "";
+char *ld_passwd = NULL;
+char *ld_binddn = NULL;
+unsigned int ld_port = DEFAULT_PORT;
+int warn_time = UNDEFINED;
+int crit_time = UNDEFINED;
int
main (int argc, char *argv[])
/* get the finish time */
time (&time1);
- /* calcutate the elapsed time */
+ /* calcutate the elapsed time and compare to thresholds */
t_diff = time1 - time0;
- /* check if warn_time or crit_time was exceeded */
- if ((t_diff >= warn_time) && (t_diff < crit_time)) {
- printf ("LDAP warning - %i seconds response time\n", t_diff);
- return STATE_WARNING;
- }
- if (t_diff >= crit_time) {
+ if (crit_time!=UNDEFINED && t_diff>=crit_time) {
printf ("LDAP critical - %i seconds response time\n", t_diff);
return STATE_CRITICAL;
}
+ if (warn_time!=UNDEFINED && t_diff>=warn_time) {
+ printf ("LDAP warning - %i seconds response time\n", t_diff);
+ return STATE_WARNING;
+ }
+
/* print out the result */
printf ("LDAP ok - %i seconds response time\n", t_diff);
{
int c;
- if (argc < 2)
- return ERROR;
-
- for (c = 1; c < argc; c++) {
- if (strcmp ("-to", argv[c]) == 0)
- strcpy (argv[c], "-t");
- }
-
- c = 0;
- while (c += (call_getopt (argc - c, &argv[c]))) {
- if (argc <= c)
- break;
- if (ld_host[0] == 0) {
- strncpy (ld_host, argv[c], sizeof (ld_host) - 1);
- ld_host[sizeof (ld_host) - 1] = 0;
- }
- }
-
- return c;
-}
-
-int
-call_getopt (int argc, char **argv)
-{
- int c, i = 1;
#ifdef HAVE_GETOPT_H
int option_index = 0;
/* initialize the long option struct */
- static struct option long_options[] = {
+ static struct option longopts[] = {
{"help", no_argument, 0, 'h'},
{"version", no_argument, 0, 'V'},
{"timeout", required_argument, 0, 't'},
};
#endif
- for (c = 1; c < argc; c++)
+ if (argc < 2)
+ return ERROR;
+
+ for (c = 1; c < argc; c++) {
if (strcmp ("-to", argv[c]) == 0)
strcpy (argv[c], "-t");
+ }
while (1) {
#ifdef HAVE_GETOPT_H
- c =
- getopt_long (argc, argv, "+hVt:c:w:H:b:p:a:D:P:", long_options,
- &option_index);
+ c = getopt_long (argc, argv, "hVt:c:w:H:b:p:a:D:P:", longopts, &option_index);
#else
c = getopt (argc, argv, "+?hVt:c:w:H:b:p:a:D:P:");
#endif
if (c == -1 || c == EOF)
break;
- i++;
- switch (c) {
- case 't':
- case 'c':
- case 'w':
- case 'H':
- case 'b':
- case 'p':
- case 'a':
- case 'D':
- case 'P':
- i++;
- }
-
switch (c) {
case 'h': /* help */
print_help ();
exit (STATE_OK);
case 'V': /* version */
- print_revision (PROGNAME, REVISION);
+ print_revision (progname, revision);
exit (STATE_OK);
case 't': /* timeout period */
if (!is_intnonneg (optarg))
- usage2 ("timeout interval must be an integer", optarg);
+ usage2 ("timeout interval must be a positive integer", optarg);
socket_timeout = atoi (optarg);
break;
case 'H':
break;
}
}
- return i;
+
+ if (ld_host[0] == 0) {
+ asprintf (&ld_host, "%s", argv[c]);
+ }
+
+ return validate_arguments ();
}
int
validate_arguments ()
{
- if (ld_host[0] == 0 ||
- ld_base[0] == 0 ||
- ld_port == UNKNOWN || warn_time == UNKNOWN || crit_time == UNKNOWN) {
- return ERROR;
- }
- else {
+ if (strlen(ld_host) == 0)
+ usage ("please specify the host name\n");
+
+ if (strlen(ld_base) == 0)
+ usage ("please specify the LDAP base\n");
+
+ else
return OK;
- }
+
}
\f
/* function print_help */
-static void
+void
print_help ()
{
- print_revision (PROGNAME, REVISION);
+ print_revision (progname, revision);
printf
("Copyright (c) 1999 Didi Rieder (adrieder@sbox.tu-graz.ac.at)\n"
"License: GPL\n" "\n");
"\t-b [--base] ... ldap base (eg. ou=my unit, o=my org, c=at)\n"
"\t-D [--bind] ... ldap bind DN (if required)\n"
"\t-P [--pass] ... ldap password (if required)\n"
- "\t-p [--port] ... ldap port (normaly 389)\n"
+ "\t-p [--port] ... ldap port (default: %d)\n"
"\t-w [--warn] ... time in secs. - if the exceeds <warn> the STATE_WARNING will be returned\n"
"\t-c [--crit] ... time in secs. - if the exceeds <crit> the STATE_CRITICAL will be returned\n"
- "\n");
+ "\n", DEFAULT_PORT);
}
-static void
+void
print_usage ()
{
printf
- ("Usage: %s -H <host> -b <base_dn> -p <port> [-a <attr>] [-D <binddn>]\n"
+ ("Usage: %s -H <host> -b <base_dn> [-p <port>] [-a <attr>] [-D <binddn>]\n"
" [-P <password>] [-w <warn_time>] [-c <crit_time>] [-t timeout]\n"
- "(Note: all times are in seconds.)\n", PROGNAME);
+ "(Note: all times are in seconds.)\n", progname);
}