Code

fix a variety of compiler warnings about qualifier discards and other pedantic stuff
[nagiosplug.git] / plugins / check_dig.c
index e4f86321d2e46aaaecead0812d8278499c047b07..7c39a243c507c5adc8812255eedcf5de15b30885 100644 (file)
@@ -1,63 +1,72 @@
-/******************************************************************************
- *
- * Program: SNMP plugin for Nagios
- * License: GPL
- *
- * License Information:
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
- *****************************************************************************/
-
-#include "config.h"
+/*****************************************************************************
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 2 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program; if not, write to the Free Software
+ Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+
+*****************************************************************************/
+
 #include "common.h"
+#include "netutils.h"
 #include "utils.h"
 #include "popen.h"
 
-#define PROGNAME "check_dig"
-#define REVISION "$Revision$"
-#define COPYRIGHT "2000-2002"
-#define AUTHOR "Karl DeBisschop"
-#define EMAIL "karl@debisschop.net"
-#define SUMMARY "Test the DNS service on the specified host using dig\n"
-
 int process_arguments (int, char **);
 int validate_arguments (void);
 void print_help (void);
 void print_usage (void);
 
+const char *progname = "check_dig";
+const char *revision = "$Revision$";
+const char *copyright = "2002-2003";
+const char *email = "nagiosplug-devel@lists.sourceforge.net";
+
+enum {
+       DEFAULT_PORT = 53
+};
+
 char *query_address = NULL;
 char *dns_server = NULL;
 int verbose = FALSE;
+int server_port = DEFAULT_PORT;
+int warning_interval = -1;
+int critical_interval = -1;
 
+
+
+
+
+\f
 int
 main (int argc, char **argv)
 {
        char input_buffer[MAX_INPUT_BUFFER];
-       char *command_line = NULL;
-       char *output = "";
+       char *command_line;
+       char *output;
        int result = STATE_UNKNOWN;
 
+       output = strdup ("");
+
        /* Set signal handling and alarm */
        if (signal (SIGALRM, popen_timeout_alarm_handler) == SIG_ERR)
-               usage ("Cannot catch SIGALRM\n");
+               usage (_("Cannot catch SIGALRM\n"));
 
        if (process_arguments (argc, argv) != OK)
-               usage ("Could not parse arguments\n");
+               usage (_("Could not parse arguments\n"));
 
        /* get the command to run */
-       asprintf (&command_line, "%s @%s %s", PATH_TO_DIG, dns_server, query_address);
+       asprintf (&command_line, "%s @%s -p %d %s",
+                 PATH_TO_DIG, dns_server, server_port, query_address);
 
        alarm (timeout_interval);
        time (&start_time);
@@ -67,13 +76,13 @@ main (int argc, char **argv)
        /* run the command */
        child_process = spopen (command_line);
        if (child_process == NULL) {
-               printf ("Could not open pipe: %s\n", command_line);
+               printf (_("Could not open pipe: %s\n"), command_line);
                return STATE_UNKNOWN;
        }
 
        child_stderr = fdopen (child_stderr_array[fileno (child_process)], "r");
        if (child_stderr == NULL)
-               printf ("Could not open stderr for %s\n", command_line);
+               printf (_("Could not open stderr for %s\n"), command_line);
 
        while (fgets (input_buffer, MAX_INPUT_BUFFER - 1, child_process)) {
 
@@ -92,7 +101,7 @@ main (int argc, char **argv)
                                result = STATE_OK;
                        }
                        else {
-                               asprintf (&output, "Server not found in ANSWER SECTION");
+                               asprintf (&output, _("Server not found in ANSWER SECTION"));
                                result = STATE_WARNING;
                        }
 
@@ -102,7 +111,7 @@ main (int argc, char **argv)
        }
 
        if (result != STATE_OK) {
-               asprintf (&output, "No ANSWER SECTION found");
+               asprintf (&output, _("No ANSWER SECTION found"));
        }
 
        while (fgets (input_buffer, MAX_INPUT_BUFFER - 1, child_stderr)) {
@@ -119,34 +128,38 @@ main (int argc, char **argv)
        if (spclose (child_process)) {
                result = max_state (result, STATE_WARNING);
                if (strlen (output) == 0)
-                       asprintf (&output, "dig returned error status");
+                       asprintf (&output, _("dig returned error status"));
        }
 
        (void) time (&end_time);
 
        if (output == NULL || strlen (output) == 0)
-               asprintf (&output, " Probably a non-existent host/domain");
+               asprintf (&output, _(" Probably a non-existent host/domain"));
 
        if (result == STATE_OK)
-               printf ("DNS ok - %d seconds response time (%s)\n",
+               printf (_("DNS OK - %d seconds response time (%s)\n"),
                                                (int) (end_time - start_time), output);
        else if (result == STATE_WARNING)
-               printf ("DNS WARNING - %s\n", output);
+               printf (_("DNS WARNING - %s\n"), output);
        else if (result == STATE_CRITICAL)
-               printf ("DNS CRITICAL - %s\n", output);
+               printf (_("DNS CRITICAL - %s\n"), output);
        else
-               printf ("DNS problem - %s\n", output);
+               printf (_("DNS problem - %s\n"), output);
 
        return result;
 }
 
+
+
+
+
+\f
 /* process command-line arguments */
 int
 process_arguments (int argc, char **argv)
 {
        int c;
 
-#ifdef HAVE_GETOPT_H
        int option_index = 0;
        static struct option long_options[] = {
                {"hostname", required_argument, 0, 'H'},
@@ -156,52 +169,71 @@ process_arguments (int argc, char **argv)
                {"help", no_argument, 0, 'h'},
                {0, 0, 0, 0}
        };
-#endif
 
        if (argc < 2)
                return ERROR;
 
        while (1) {
-#ifdef HAVE_GETOPT_H
                c = getopt_long (argc, argv, "hVvt:l:H:", long_options, &option_index);
-#else
-               c = getopt (argc, argv, "hVvt:l:H:");
-#endif
 
                if (c == -1 || c == EOF)
                        break;
 
                switch (c) {
                case '?':                                                                       /* help */
-                       usage3 ("Unknown argument", optopt);
+                       usage3 (_("Unknown argument"), optopt);
+               case 'h':                                                                       /* help */
+                       print_help ();
+                       exit (STATE_OK);
+               case 'V':                                                                       /* version */
+                       print_revision (progname, "$Revision$");
+                       exit (STATE_OK);
                case 'H':                                                                       /* hostname */
                        if (is_host (optarg)) {
                                dns_server = optarg;
                        }
                        else {
-                               usage ("Invalid host name\n");
+                               usage2 (_("Invalid host name"), optarg);
+                       }
+                       break;
+               case 'p':
+                       if (is_intpos (optarg)) {
+                               server_port = atoi (optarg);
+                       }
+                       else {
+                               usage2 (_("Server port must be a nonnegative integer\n"), optarg);
                        }
                        break;
                case 'l':                                                                       /* username */
                        query_address = optarg;
                        break;
-               case 'v':                                                                       /* verbose */
-                       verbose = TRUE;
+               case 'w':                                                                       /* timeout */
+                       if (is_intnonneg (optarg)) {
+                               warning_interval = atoi (optarg);
+                       }
+                       else {
+                               usage2 (_("Warning interval must be a nonnegative integer\n"), optarg);
+                       }
+                       break;
+               case 'c':                                                                       /* timeout */
+                       if (is_intnonneg (optarg)) {
+                               critical_interval = atoi (optarg);
+                       }
+                       else {
+                               usage2 (_("Critical interval must be a nonnegative integer\n"), optarg);
+                       }
                        break;
                case 't':                                                                       /* timeout */
                        if (is_intnonneg (optarg)) {
                                timeout_interval = atoi (optarg);
                        }
                        else {
-                               usage ("Time interval must be a nonnegative integer\n");
+                               usage2 (_("Time interval must be a nonnegative integer\n"), optarg);
                        }
                        break;
-               case 'V':                                                                       /* version */
-                       print_revision (PROGNAME, "$Revision$");
-                       exit (STATE_OK);
-               case 'h':                                                                       /* help */
-                       print_help ();
-                       exit (STATE_OK);
+               case 'v':                                                                       /* verbose */
+                       verbose = TRUE;
+                       break;
                }
        }
 
@@ -212,11 +244,11 @@ process_arguments (int argc, char **argv)
                                dns_server = argv[c];
                        }
                        else {
-                               usage ("Invalid host name");
+                               usage2 (_("Invalid host name"), argv[c]);
                        }
                }
                else {
-                       asprintf (&dns_server, "127.0.0.1");
+                       dns_server = strdup ("127.0.0.1");
                }
        }
 
@@ -237,40 +269,50 @@ validate_arguments (void)
 
 
 
+
+\f
 void
 print_help (void)
 {
-       print_revision (PROGNAME, "$Revision$");
-       printf
-               ("Copyright (c) %s %s <%s>\n\n%s\n",
-                COPYRIGHT, AUTHOR, EMAIL, SUMMARY);
+       char *myport;
+
+       asprintf (&myport, "%d", DEFAULT_PORT);
+
+       print_revision (progname, revision);
+
+       printf (_(COPYRIGHT), copyright, email);
+
+       printf (_("Test the DNS service on the specified host using dig\n\n"));
+
        print_usage ();
-       printf
-               ("\nOptions:\n"
-                " -H, --hostname=STRING or IPADDRESS\n"
-                "   Check server on the indicated host\n"
-                " -l, --lookup=STRING\n"
-                "   machine name to lookup\n"
-                " -t, --timeout=INTEGER\n"
-                "   Seconds before connection attempt times out (default: %d)\n"
-                " -v, --verbose\n"
-                "   Print extra information (command-line use only)\n"
-                " -h, --help\n"
-                "   Print detailed help screen\n"
-                " -V, --version\n"
-                "   Print version information\n\n", DEFAULT_SOCKET_TIMEOUT);
+
+       printf (_(UT_HELP_VRSN));
+
+       printf (_(UT_HOST_PORT), 'P', myport);
+
+       printf (_("\
+ -l, --lookup=STRING\n\
+   machine name to lookup\n"));
+
+       printf (_(UT_WARN_CRIT));
+
+       printf (_(UT_TIMEOUT), DEFAULT_SOCKET_TIMEOUT);
+
+       printf (_(UT_VERBOSE));
+
        support ();
 }
 
 
 
 
-
 void
 print_usage (void)
 {
-       printf
-               ("Usage: %s -H host -l lookup [-t timeout] [-v]\n"
-                "       %s --help\n"
-                "       %s --version\n", PROGNAME, PROGNAME, PROGNAME);
+       printf (_("\
+Usage: %s -H host -l lookup [-p <server port>] [-w <warning interval>]\n\
+         [-c <critical interval>] [-t <timeout>] [-v]\n"),
+               progname);
+       printf ("       %s (-h|--help)\n", progname);
+       printf ("       %s (-V|--version)\n", progname);
 }