Code

tig.git
10 years agoget_author_initials: various fixes master
Pierre Habouzit [Mon, 2 May 2011 11:10:28 +0000 (13:10 +0200)]
get_author_initials: various fixes

Do not pull partial multi-byte sequences.

Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Signed-off-by: Jonas Fonseca <fonseca@diku.dk>
10 years agoUse locale-unaware methods for case conversion
Ozan Çağlayan [Tue, 19 Apr 2011 05:38:40 +0000 (08:38 +0300)]
Use locale-unaware methods for case conversion

Problem:
 On a tr_TR.UTF-8 locale, adding a key binding to tigrc can not be
 correctly parsed if the keymap contains 'i' like main, generic, etc.
 as they are wrongly converted to upper case.

In languages like Turkish, 'i' is not converted to 'I' as they're
different characters. So one should never use locale-aware conversion
methods which will break things in some locales.

See:
 http://www.mattryall.net/blog/2009/02/the-infamous-turkish-locale-bug

Signed-off-by: Jonas Fonseca <fonseca@diku.dk>
10 years agoRevert change to put %(ref):%(file) in the blame view title
Jonas Fonseca [Thu, 14 Apr 2011 02:33:58 +0000 (22:33 -0400)]
Revert change to put %(ref):%(file) in the blame view title

10 years agoSimplify blame argv formatting
Jonas Fonseca [Thu, 14 Apr 2011 02:30:42 +0000 (22:30 -0400)]
Simplify blame argv formatting

10 years agoReload the blame view when changing the ref and file variables
Jonas Fonseca [Thu, 14 Apr 2011 02:29:47 +0000 (22:29 -0400)]
Reload the blame view when changing the ref and file variables

Fixes regression introduced in recent refactorings.

10 years agoUse mkauthor in grep functions
Jonas Fonseca [Thu, 14 Apr 2011 00:36:19 +0000 (20:36 -0400)]
Use mkauthor in grep functions

10 years agoFix problem with empty space when the author field is disabled
Jonas Fonseca [Thu, 14 Apr 2011 00:35:40 +0000 (20:35 -0400)]
Fix problem with empty space when the author field is disabled

10 years agoUnify enum map declarations through a common utility
Jonas Fonseca [Sun, 10 Apr 2011 23:19:59 +0000 (19:19 -0400)]
Unify enum map declarations through a common utility

10 years agoAccept 'utf-8' for the line-graphics option as indicated in the docs
Jonas Fonseca [Sun, 10 Apr 2011 16:19:10 +0000 (12:19 -0400)]
Accept 'utf-8' for the line-graphics option as indicated in the docs

Reported by Bernhard Walle.

10 years agoFix regression where new content in the stage view does not reset the position
Jonas Fonseca [Sun, 10 Apr 2011 03:40:10 +0000 (23:40 -0400)]
Fix regression where new content in the stage view does not reset the position

10 years agoRefactor mkmode from draw_mode
Jonas Fonseca [Sun, 10 Apr 2011 03:39:49 +0000 (23:39 -0400)]
Refactor mkmode from draw_mode

10 years agoRefactor mkauthor from draw_author
Jonas Fonseca [Sun, 10 Apr 2011 03:39:01 +0000 (23:39 -0400)]
Refactor mkauthor from draw_author

10 years agoRefactor draw_refs out from main_draw
Jonas Fonseca [Sun, 10 Apr 2011 03:18:40 +0000 (23:18 -0400)]
Refactor draw_refs out from main_draw

10 years agoMerge prepare_update into open_argv; make open_file call open_argv
Jonas Fonseca [Sat, 9 Apr 2011 18:26:20 +0000 (14:26 -0400)]
Merge prepare_update into open_argv; make open_file call open_argv

10 years agoUse begin_update to load data in the tree and branch views
Jonas Fonseca [Sat, 9 Apr 2011 18:19:56 +0000 (14:19 -0400)]
Use begin_update to load data in the tree and branch views

Deletes the now unused start_update.

10 years agoFix blame view regression
Jonas Fonseca [Sat, 9 Apr 2011 18:18:35 +0000 (14:18 -0400)]
Fix blame view regression

Makes it possible to use begin_update to load extra view data, which
allows the argv argument to be properly formatted.

10 years agoio_run: make it possible to open file
Jonas Fonseca [Sat, 9 Apr 2011 18:13:58 +0000 (14:13 -0400)]
io_run: make it possible to open file

10 years agoSimplify format_argv to always replace
Jonas Fonseca [Fri, 18 Mar 2011 12:32:21 +0000 (08:32 -0400)]
Simplify format_argv to always replace

10 years agoRename prepare_io to prepare_update and make it more specialized
Jonas Fonseca [Thu, 17 Mar 2011 01:45:28 +0000 (21:45 -0400)]
Rename prepare_io to prepare_update and make it more specialized

10 years agoMove view splitting code to separate split_view
Jonas Fonseca [Fri, 11 Mar 2011 04:34:05 +0000 (23:34 -0500)]
Move view splitting code to separate split_view

10 years agoopen_view: Use maximize_view to prepare non-split displays
Jonas Fonseca [Fri, 11 Mar 2011 04:30:35 +0000 (23:30 -0500)]
open_view: Use maximize_view to prepare non-split displays

10 years agoopen_view: gather split view code in the same branch
Jonas Fonseca [Fri, 11 Mar 2011 04:27:22 +0000 (23:27 -0500)]
open_view: gather split view code in the same branch

10 years agoIntroduce refresh_view based on load_view
Jonas Fonseca [Wed, 16 Mar 2011 01:46:50 +0000 (21:46 -0400)]
Introduce refresh_view based on load_view

10 years agoRefactor view loading from open_view into load_view
Jonas Fonseca [Wed, 16 Mar 2011 01:28:46 +0000 (21:28 -0400)]
Refactor view loading from open_view into load_view

10 years agoAdd open_argv and open_file to wrap update preparation and open_view call
Jonas Fonseca [Fri, 11 Mar 2011 13:24:40 +0000 (08:24 -0500)]
Add open_argv and open_file to wrap update preparation and open_view call

10 years agoEnhance prepare_update_file to add support for refreshable file IO
Jonas Fonseca [Fri, 11 Mar 2011 03:44:54 +0000 (22:44 -0500)]
Enhance prepare_update_file to add support for refreshable file IO

10 years agoSimplify draw_author and draw_date logic
Jonas Fonseca [Sat, 12 Jun 2010 23:00:23 +0000 (19:00 -0400)]
Simplify draw_author and draw_date logic

10 years agoMake the low-level drawing functions update the view column
Jonas Fonseca [Sat, 12 Mar 2011 00:24:36 +0000 (19:24 -0500)]
Make the low-level drawing functions update the view column

10 years agoAdd specialized open methods for each view
Jonas Fonseca [Tue, 15 Mar 2011 01:35:53 +0000 (21:35 -0400)]
Add specialized open methods for each view

... which provide the argv to begin_update

10 years agoConvert tree_prepare to tree_open
Jonas Fonseca [Tue, 15 Mar 2011 01:06:28 +0000 (21:06 -0400)]
Convert tree_prepare to tree_open

10 years agoConvert begin_update to act as a view_ops open function
Jonas Fonseca [Tue, 15 Mar 2011 00:55:40 +0000 (20:55 -0400)]
Convert begin_update to act as a view_ops open function

10 years agoExtend open() view ops to accept the open flags as an argument
Jonas Fonseca [Tue, 15 Mar 2011 00:45:04 +0000 (20:45 -0400)]
Extend open() view ops to accept the open flags as an argument

10 years agoAdd VIEW_MAX_LEN macro to aid when drawing
Jonas Fonseca [Sat, 12 Jun 2010 14:27:03 +0000 (10:27 -0400)]
Add VIEW_MAX_LEN macro to aid when drawing

10 years agoRemove support for the deprecated TIG_{MAIN,DIFF,LOG,TREE,BLOB}_CMD env vars
Jonas Fonseca [Sat, 12 Jun 2010 16:37:44 +0000 (12:37 -0400)]
Remove support for the deprecated TIG_{MAIN,DIFF,LOG,TREE,BLOB}_CMD env vars

10 years agoDo not install test-graph
Jonas Fonseca [Thu, 10 Mar 2011 02:14:09 +0000 (21:14 -0500)]
Do not install test-graph

10 years agoImprove parsing of the set command and variable arguments options
Jonas Fonseca [Thu, 10 Mar 2011 02:11:44 +0000 (21:11 -0500)]
Improve parsing of the set command and variable arguments options

10 years ago[GH-6] Make blame configurable via options from ~/.tigrc and the command line
Jonas Fonseca [Wed, 9 Mar 2011 23:15:49 +0000 (18:15 -0500)]
[GH-6] Make blame configurable via options from ~/.tigrc and the command line

10 years agotigrc(5): sort options alphabetically
Jonas Fonseca [Wed, 9 Mar 2011 23:04:39 +0000 (18:04 -0500)]
tigrc(5): sort options alphabetically

10 years agoUpdate and fix a few NEWS entries
Jonas Fonseca [Wed, 9 Mar 2011 01:06:08 +0000 (20:06 -0500)]
Update and fix a few NEWS entries

10 years ago[GH-3] Expand %(directory) to . for the root directory
Jonas Fonseca [Wed, 9 Mar 2011 01:03:02 +0000 (20:03 -0500)]
[GH-3] Expand %(directory) to . for the root directory

10 years agotig-0.17
Jonas Fonseca [Mon, 7 Mar 2011 01:49:41 +0000 (20:49 -0500)]
tig-0.17

10 years agoRewrite the revision graph renderer
Jonas Fonseca [Fri, 11 Dec 2009 22:05:23 +0000 (17:05 -0500)]
Rewrite the revision graph renderer

The new renderer is more 'square' but comes with three modes: UTF-8,
ncurses (using chtype graphical characters), and ASCII. The three modes
can be toggled. Enable revision graph rendering by default.

10 years agoMove IO API to src/io.[ch]
Jonas Fonseca [Mon, 22 Mar 2010 02:16:58 +0000 (22:16 -0400)]
Move IO API to src/io.[ch]

10 years agoMove includes, macros and core utilities to tig.h
Jonas Fonseca [Fri, 19 Mar 2010 12:56:43 +0000 (08:56 -0400)]
Move includes, macros and core utilities to tig.h

10 years agoInitialise views and screens with nonzero size.
Loui Chang [Sun, 27 Feb 2011 21:29:35 +0000 (16:29 -0500)]
Initialise views and screens with nonzero size.

This fixes problems with ncurses 2.8

Signed-off-by: Loui Chang <louipc.ist@gmail.com>
Signed-off-by: Jonas Fonseca <fonseca@diku.dk>
11 years agoRemove draw_text()s trim parameter
Jonas Fonseca [Sat, 16 Oct 2010 01:54:10 +0000 (21:54 -0400)]
Remove draw_text()s trim parameter

... it's TRUE at all call sites.

11 years agoRemove unnecessary braces
Jonas Fonseca [Sun, 3 Oct 2010 23:59:17 +0000 (19:59 -0400)]
Remove unnecessary braces

11 years agoReduce the number of windows to max two by sharing them between all views
Jonas Fonseca [Sun, 3 Oct 2010 04:55:53 +0000 (00:55 -0400)]
Reduce the number of windows to max two by sharing them between all views

11 years agoUse AX_WITH_CURSES from GNU autoconf archive to detect ncurses
Jonas Fonseca [Sun, 3 Oct 2010 03:12:38 +0000 (23:12 -0400)]
Use AX_WITH_CURSES from GNU autoconf archive to detect ncurses

11 years agoconfigure.ac: Set value-if-not-found, don't check for program 'false'
Loui Chang [Sat, 2 Oct 2010 01:34:09 +0000 (21:34 -0400)]
configure.ac: Set value-if-not-found, don't check for program 'false'

Signed-off-by: Loui Chang <louipc.ist@gmail.com>
Signed-off-by: Jonas Fonseca <fonseca@diku.dk>
11 years agoUnify option toggling
Jonas Fonseca [Sat, 2 Oct 2010 15:01:17 +0000 (11:01 -0400)]
Unify option toggling

11 years agoRefactor option parsing error handling to use error codes
Jonas Fonseca [Mon, 27 Sep 2010 00:27:36 +0000 (20:27 -0400)]
Refactor option parsing error handling to use error codes

11 years agoAdd possiblity to pass data to io_load property reader
Jonas Fonseca [Mon, 27 Sep 2010 00:13:39 +0000 (20:13 -0400)]
Add possiblity to pass data to io_load property reader

11 years agoRename opt_*_args to opt_*_argv
Jonas Fonseca [Mon, 27 Sep 2010 00:10:06 +0000 (20:10 -0400)]
Rename opt_*_args to opt_*_argv

11 years agoImprove viewing of diffs when browsing branches
Jonas Fonseca [Sun, 26 Sep 2010 22:23:05 +0000 (18:23 -0400)]
Improve viewing of diffs when browsing branches

11 years agotig-0.16.2
Jonas Fonseca [Tue, 21 Sep 2010 12:43:35 +0000 (08:43 -0400)]
tig-0.16.2

11 years agoFix 'tig show <commit>' fix which causes empty tree views
Jonas Fonseca [Tue, 21 Sep 2010 12:38:11 +0000 (08:38 -0400)]
Fix 'tig show <commit>' fix which causes empty tree views

Introduced by 80e97cdd456dfe71d0dbf32d77a73bb5a2ab158e.

11 years agoCheck the ncurses version before using set_tabsize
Kumar Appaiah [Mon, 20 Sep 2010 23:10:11 +0000 (18:10 -0500)]
Check the ncurses version before using set_tabsize

This patch checks the ncurses patch level to decide if set_tabsize is
to be used in place of the TABSIZE macro, for setting the tab size.

Signed-off-by: Jonas Fonseca <fonseca@diku.dk>
11 years agotig-0.16.1
Jonas Fonseca [Sun, 19 Sep 2010 18:22:26 +0000 (14:22 -0400)]
tig-0.16.1

11 years agoFix tig show by replacing %(commit) with %(revargs) on first display
Jonas Fonseca [Sun, 19 Sep 2010 15:09:41 +0000 (11:09 -0400)]
Fix tig show by replacing %(commit) with %(revargs) on first display

Broken in commit 53c089443cd9885fa677becee4bf7ffd56c3c357.

11 years agoUse function set_tabsize()
Stefan Naewe [Sun, 12 Sep 2010 09:03:52 +0000 (11:03 +0200)]
Use function set_tabsize()

this fixes the following compile error on cygwin:
tig.c: In function `init_display':
tig.c:7112: error: invalid lvalue in assignment

Signed-off-by: Stefan Naewe <stefan.naewe@googlemail.com>
Signed-off-by: Jonas Fonseca <fonseca@diku.dk>
11 years agoDon't show out-of-sight tildes
Jonathan Neuschäfer [Thu, 16 Sep 2010 01:01:10 +0000 (21:01 -0400)]
Don't show out-of-sight tildes

Signed-off-by: Jonas Fonseca <fonseca@diku.dk>
11 years agoAdd an option to ignore unknown directories contents in the status view
Pierre Habouzit [Mon, 28 Jun 2010 08:26:17 +0000 (10:26 +0200)]
Add an option to ignore unknown directories contents in the status view

Similar to git ls-files --directory

Signed-off-by: Jonas Fonseca <fonseca@diku.dk>
11 years agoRemove remains from the obsoleted toggle-date-short action
Jonas Fonseca [Sat, 26 Jun 2010 21:59:58 +0000 (17:59 -0400)]
Remove remains from the obsoleted toggle-date-short action

The default keybinding and handling code was removed in commit
b9247a4639adcfa4e8f816d75c62917575757619

11 years agoActually add the ^D binding to move-page-down
Pierre Habouzit [Sat, 26 Jun 2010 21:15:47 +0000 (23:15 +0200)]
Actually add the ^D binding to move-page-down

Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Signed-off-by: Jonas Fonseca <fonseca@diku.dk>
11 years agoAdd a scroll-first-col command
Pierre Habouzit [Thu, 24 Jun 2010 15:24:24 +0000 (17:24 +0200)]
Add a scroll-first-col command

Signed-off-by: Pierre Habouzit <madcoder@debian.org>
[ jf: fix built-in description and add entry to the manual ]

Signed-off-by: Jonas Fonseca <fonseca@diku.dk>
11 years agoAdd vi-like ^ bindings
Pierre Habouzit [Thu, 24 Jun 2010 15:24:23 +0000 (17:24 +0200)]
Add vi-like ^ bindings

^N/^P for previous/next
^Y/^E for scroll_up/scroll_down
^D/^U for page_up/page_down
^L    for redraw

Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Signed-off-by: Jonas Fonseca <fonseca@diku.dk>
11 years agoAllow tig to parse control-modified chars in tigrc
Pierre Habouzit [Thu, 24 Jun 2010 15:24:22 +0000 (17:24 +0200)]
Allow tig to parse control-modified chars in tigrc

Signed-off-by: Pierre Habouzit <madcoder@debian.org>
[ jf: s/0x32/0x20/ per request from Pierre ]

Signed-off-by: Jonas Fonseca <fonseca@diku.dk>
11 years agoFix segfault when starting tig in pager mode
Jonas Fonseca [Sat, 26 Jun 2010 00:01:07 +0000 (20:01 -0400)]
Fix segfault when starting tig in pager mode

Thanks to Pierre Habouzit and Tobias Heinlein for reporting this.

11 years agoFall back to retry if no diff will be shown
Jonas Fonseca [Wed, 23 Jun 2010 02:52:58 +0000 (22:52 -0400)]
Fall back to retry if no diff will be shown

This can happen if a file spec was passed on the command line and
the diff view is opened from the blame view with a different path.

11 years agoRefactor argv_size out from argv_append
Jonas Fonseca [Wed, 23 Jun 2010 02:23:35 +0000 (22:23 -0400)]
Refactor argv_size out from argv_append

11 years agotig-0.16
Jonas Fonseca [Sat, 12 Jun 2010 15:38:24 +0000 (11:38 -0400)]
tig-0.16

11 years agoFix missing ID reference
Jonas Fonseca [Sat, 12 Jun 2010 15:29:32 +0000 (11:29 -0400)]
Fix missing ID reference

... the original ID was removed in commit
b00784cc39b2d7b6069d382a2405fb3e117386d1.

11 years agoRename {diff,file,rev}-args to {diff,file,rev}args
Jonas Fonseca [Sat, 12 Jun 2010 14:36:28 +0000 (10:36 -0400)]
Rename {diff,file,rev}-args to {diff,file,rev}args

11 years agoLoad diff arguments from TIG_DIFF_OPTS if defined and no diff args was passed
Jonas Fonseca [Fri, 11 Jun 2010 00:02:39 +0000 (20:02 -0400)]
Load diff arguments from TIG_DIFF_OPTS if defined and no diff args was passed

This is the missing part of 53c089443cd9885fa677becee4bf7ffd56c3c357.

11 years agoMove application of string_expand to draw_text
Jonas Fonseca [Thu, 10 Jun 2010 23:43:48 +0000 (19:43 -0400)]
Move application of string_expand to draw_text

... fixes bug which truncated long lines to a fixed number of chars.

11 years agoImprove parent blame to handle line-jumping for renames better
Jeff King [Thu, 10 Jun 2010 01:27:27 +0000 (21:27 -0400)]
Improve parent blame to handle line-jumping for renames better

... by using git diff to compare directly the current and parent blob.

Signed-off-by: Jonas Fonseca <fonseca@diku.dk>
11 years agoImprove parent blame to detect renames by using the previous information
Jonas Fonseca [Sat, 5 Jun 2010 19:35:17 +0000 (15:35 -0400)]
Improve parent blame to detect renames by using the previous information

From git commit 96e117099c0e4f7d508eb071f60b6275038f6f37:

 It gives the parent commit of the blamed commit, _and_ a path in that
 parent commit that corresponds to the blamed path --- in short, it is
 the origin that would have been blamed (or passed blame through) for
 the line _if_ the blamed commit did not change that line.

This functionality was released in git version 1.6.3 in 2009-05-06.

11 years agoFree blame view data when reloading view
Jonas Fonseca [Wed, 9 Jun 2010 03:10:08 +0000 (23:10 -0400)]
Free blame view data when reloading view

11 years agoFix clearing of the loading flag in the input select loop
Jonas Fonseca [Tue, 8 Jun 2010 00:06:42 +0000 (20:06 -0400)]
Fix clearing of the loading flag in the input select loop

The bug was introduced in 33e10c2599e16ff6690e7b0bbdd7a95e7f97c886.

11 years agoDeprecate use of TIG_{MAIN,DIFF,LOG,TREE,BLOB}_CMD environment variables
Jonas Fonseca [Sat, 5 Jun 2010 04:23:09 +0000 (00:23 -0400)]
Deprecate use of TIG_{MAIN,DIFF,LOG,TREE,BLOB}_CMD environment variables

11 years agoAdd support for splitting command line arguments
Jonas Fonseca [Wed, 2 Jun 2010 11:45:01 +0000 (07:45 -0400)]
Add support for splitting command line arguments

11 years agoMake the branch view always prepare how the main view is loaded
Jonas Fonseca [Fri, 4 Jun 2010 22:55:01 +0000 (18:55 -0400)]
Make the branch view always prepare how the main view is loaded

11 years agoCleanup initialization of built-in run requests
Jonas Fonseca [Fri, 4 Jun 2010 22:40:46 +0000 (18:40 -0400)]
Cleanup initialization of built-in run requests

11 years agoMake view and run request argv members flexible and allocated
Jonas Fonseca [Fri, 4 Jun 2010 13:20:54 +0000 (09:20 -0400)]
Make view and run request argv members flexible and allocated

11 years agoFurther cleanup IO startup and initialization; fix io_run_append
Jonas Fonseca [Thu, 3 Jun 2010 11:48:24 +0000 (07:48 -0400)]
Further cleanup IO startup and initialization; fix io_run_append

11 years agoCleanup IO struct initialization
Jonas Fonseca [Thu, 3 Jun 2010 01:33:57 +0000 (21:33 -0400)]
Cleanup IO struct initialization

11 years agoMake argv_copy always allocate its members
Jonas Fonseca [Wed, 2 Jun 2010 20:29:12 +0000 (16:29 -0400)]
Make argv_copy always allocate its members

11 years agoMove struct io's argv and dir members to struct view
Jonas Fonseca [Wed, 2 Jun 2010 20:15:24 +0000 (16:15 -0400)]
Move struct io's argv and dir members to struct view

11 years agoRemove format_flags enum and its companion format_argv forward declaration
Jonas Fonseca [Thu, 3 Jun 2010 01:11:31 +0000 (21:11 -0400)]
Remove format_flags enum and its companion format_argv forward declaration

11 years agoMove and rewrite io_format to become prepare_io
Jonas Fonseca [Wed, 2 Jun 2010 16:10:20 +0000 (12:10 -0400)]
Move and rewrite io_format to become prepare_io

11 years agoMake argv_copy support allocating argv members
Jonas Fonseca [Wed, 2 Jun 2010 15:58:35 +0000 (11:58 -0400)]
Make argv_copy support allocating argv members

11 years agoPlug another memory leak and cleanup update start code while at it
Jonas Fonseca [Wed, 2 Jun 2010 15:51:03 +0000 (11:51 -0400)]
Plug another memory leak and cleanup update start code while at it

11 years agoMark the argument array as freed in argv_free
Jonas Fonseca [Wed, 2 Jun 2010 20:07:08 +0000 (16:07 -0400)]
Mark the argument array as freed in argv_free

11 years agoRefactor io_complete into a single backend for {back,fore}ground and append IO
Jonas Fonseca [Tue, 1 Jun 2010 12:40:31 +0000 (08:40 -0400)]
Refactor io_complete into a single backend for {back,fore}ground and append IO

11 years agoIntroduce io_prepare as a fix to plug memory leaks related to argv formatting
Jonas Fonseca [Tue, 1 Jun 2010 12:36:57 +0000 (08:36 -0400)]
Introduce io_prepare as a fix to plug memory leaks related to argv formatting

11 years agoInternalize format flags in the IO layer
Jonas Fonseca [Tue, 1 Jun 2010 00:37:49 +0000 (20:37 -0400)]
Internalize format flags in the IO layer

11 years agoMake the blame view format its own command arguments
Jonas Fonseca [Tue, 1 Jun 2010 12:19:17 +0000 (08:19 -0400)]
Make the blame view format its own command arguments

11 years agoUse view_request to unconditionally refresh views after run requests
Jonas Fonseca [Mon, 17 May 2010 03:31:34 +0000 (23:31 -0400)]
Use view_request to unconditionally refresh views after run requests

11 years agoAdd view_request to call the view request method
Jonas Fonseca [Sun, 9 May 2010 21:43:06 +0000 (17:43 -0400)]
Add view_request to call the view request method