From c2f349fcd25cf12ce89e73072f7d0f7876f50606 Mon Sep 17 00:00:00 2001 From: Sebastian Harl Date: Thu, 20 Feb 2014 22:52:02 +0100 Subject: [PATCH] data_test: Compare return values of format() and strlen(). This is to check that sdb_data_strlen() reports sane numbers. --- t/core/data_test.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/t/core/data_test.c b/t/core/data_test.c index 4d2efed..f6f9b48 100644 --- a/t/core/data_test.c +++ b/t/core/data_test.c @@ -167,6 +167,11 @@ START_TEST(test_format) "sdb_data_format(type=%s) used wrong format: %s; expected: %s", SDB_TYPE_TO_STRING(datum->type), buf, golden_data[i].expected); + fail_unless((size_t)check <= sizeof(buf) - 2, + "sdb_data_format(type=%s) wrote %d bytes; " + "expected <= %zu based on sdb_data_strlen()", + SDB_TYPE_TO_STRING(datum->type), check, sizeof(buf) - 2); + fail_unless(buf[sizeof(buf) - 2] == '\0', "sdb_data_format(type=%s) did not nul-terminate the buffer", SDB_TYPE_TO_STRING(datum->type)); -- 2.30.2