From: Sebastian Harl <sh@tokkee.org>
Date: Fri, 2 May 2014 15:13:15 +0000 (+0200)
Subject: integration tests: Use LD_PRELOAD only when running SysDB tools.
X-Git-Tag: sysdb-0.1.0~45
X-Git-Url: https://git.tokkee.org/?p=sysdb.git;a=commitdiff_plain;h=d8077043c91f5a519f20afa97b5c8720ac703f21

integration tests: Use LD_PRELOAD only when running SysDB tools.

Just as a cleanup.
---

diff --git a/t/integration/simple_config.sh b/t/integration/simple_config.sh
index e6daddc..177d934 100755
--- a/t/integration/simple_config.sh
+++ b/t/integration/simple_config.sh
@@ -37,7 +37,7 @@ cat <<EOF > "$SYSDBD_CONF"
 Listen "invalid://address"
 EOF
 
-if $SYSDBD -D -C "$SYSDBD_CONF"; then
+if run_sysdbd -D -C "$SYSDBD_CONF"; then
 	echo 'SysDBd accepted invalid listen address; expected: failure' >&2
 	exit 1
 fi
@@ -46,7 +46,7 @@ cat <<EOF > "$SYSDBD_CONF"
 Listen "$SOCKET_FILE"
 EOF
 
-$SYSDBD -D -C "$SYSDBD_CONF" &
+run_sysdbd -D -C "$SYSDBD_CONF" &
 sysdbd_pid=$!
 
 wait_for_sysdbd
diff --git a/t/integration/simple_query.sh b/t/integration/simple_query.sh
index e711897..3be0065 100755
--- a/t/integration/simple_query.sh
+++ b/t/integration/simple_query.sh
@@ -43,18 +43,18 @@ LoadBackend mock_plugin
 </Backend>
 EOF
 
-$SYSDBD -D -C "$SYSDBD_CONF" &
+run_sysdbd -D -C "$SYSDBD_CONF" &
 sysdbd_pid=$!
 
 wait_for_sysdbd
 sleep 3
 
 # On parse errors, expect a non-zero exit code.
-output="$( $SYSDB -H "$SOCKET_FILE" -c INVALID )" && exit 1
+output="$( run_sysdb -H "$SOCKET_FILE" -c INVALID )" && exit 1
 echo "$output" | grep "Failed to parse query 'INVALID'"
 echo "$output" | grep "parse error: syntax error"
 
-output="$( $SYSDB -H "$SOCKET_FILE" -c LIST )"
+output="$( run_sysdb -H "$SOCKET_FILE" -c LIST )"
 echo "$output" \
 	| grep -F '"host1.example.com"' \
 	| grep -F '"host2.example.com"' \
@@ -62,7 +62,7 @@ echo "$output" \
 	| grep -F '"other.host.name"' \
 	| grep -F '"some.host.name"'
 
-output="$( $SYSDB -H "$SOCKET_FILE" -c "FETCH 'host1.example.com'" )"
+output="$( run_sysdb -H "$SOCKET_FILE" -c "FETCH 'host1.example.com'" )"
 echo "$output" \
 	| grep -F '"host1.example.com"' \
 	| grep -F '"mock service"' \
@@ -73,11 +73,11 @@ echo "$output" | grep -F 'other.host.name' && exit 1
 echo "$output" | grep -F 'some.host.name' && exit 1
 
 # When requesting information for unknown hosts, expect a non-zero exit code.
-output="$( $SYSDB -H "$SOCKET_FILE" -c "FETCH 'does.not.exist'" )" \
+output="$( run_sysdb -H "$SOCKET_FILE" -c "FETCH 'does.not.exist'" )" \
 	&& exit 1
 echo "$output" | grep -F 'not found'
 
-output="$( $SYSDB -H "$SOCKET_FILE" \
+output="$( run_sysdb -H "$SOCKET_FILE" \
 	-c "LOOKUP hosts WHERE attribute.architecture = 'x42'" )"
 echo "$output" \
 	| grep -F '"host1.example.com"' \
@@ -86,7 +86,7 @@ echo "$output" | grep -F 'localhost' && exit 1
 echo "$output" | grep -F 'other.host.name' && exit 1
 echo "$output" | grep -F 'some.host.name' && exit 1
 
-output="$( $SYSDB -H "$SOCKET_FILE" \
+output="$( run_sysdb -H "$SOCKET_FILE" \
 	-c "LOOKUP hosts WHERE attribute.name != 'architecture'" )"
 echo "$output" \
 	| grep -F '"some.host.name"' \
@@ -95,7 +95,7 @@ echo "$output" | grep -F 'other.host.name' && exit 1
 echo "$output" | grep -F 'host1.example.com' && exit 1
 echo "$output" | grep -F 'host2.example.com' && exit 1
 
-output="$( $SYSDB -H "$SOCKET_FILE" \
+output="$( run_sysdb -H "$SOCKET_FILE" \
 	-c "LOOKUP hosts WHERE service.name = 'sysdbd'" )"
 echo "$output" | grep -F '"localhost"'
 echo "$output" | grep -F 'some.host.name' && exit 1
@@ -103,7 +103,7 @@ echo "$output" | grep -F 'other.host.name' && exit 1
 echo "$output" | grep -F 'host1.example.com' && exit 1
 echo "$output" | grep -F 'host2.example.com' && exit 1
 
-output="$( $SYSDB -H "$SOCKET_FILE" \
+output="$( run_sysdb -H "$SOCKET_FILE" \
 	-c "LOOKUP hosts WHERE host.name =~ 'example.com'" )"
 echo "$output" \
 	| grep -F '"host1.example.com"' \
@@ -113,7 +113,7 @@ echo "$output" | grep -F 'other.host.name' && exit 1
 echo "$output" | grep -F 'localhost' && exit 1
 
 # When querying hosts that don't exist, expect a zero exit code.
-output="$( $SYSDB -H "$SOCKET_FILE" \
+output="$( run_sysdb -H "$SOCKET_FILE" \
 	-c "LOOKUP hosts WHERE attribute.invalid = 'none'" )"
 echo $output | grep -E '^\[\]$'
 
diff --git a/t/integration/test_lib.sh b/t/integration/test_lib.sh
index 6386b20..7bba151 100644
--- a/t/integration/test_lib.sh
+++ b/t/integration/test_lib.sh
@@ -49,10 +49,14 @@ SYSDBD_CONF="$TESTDIR/sysdbd.conf"
 SOCKET_FILE="$TESTDIR/sock"
 PLUGIN_DIR="$TESTDIR"
 
-SYSDB="$MEMCHECK $TESTDIR/sysdb -U mockuser"
-SYSDBD="$MEMCHECK $TESTDIR/sysdbd"
+function run_sysdb() {
+	LD_PRELOAD=$TESTDIR/libsysdbclient.so $MEMCHECK \
+		"$TESTDIR/sysdb" -U mockuser "$@"
+}
 
-export LD_PRELOAD=$TESTDIR/libsysdbclient.so:$TESTDIR/libsysdb.so
+function run_sysdbd() {
+	LD_PRELOAD=$TESTDIR/libsysdb.so $MEMCHECK "$TESTDIR/sysdbd" "$@"
+}
 
 function wait_for_sysdbd() {
 	local i