frontend: Treat CONNECTION_IDLE as an invalid command.

This is only meant for internal use; don't silently ignore it.

diff --git a/src/frontend/connection.c b/src/frontend/connection.c
index a146e29711c3aa1cc4de78f59672d43ee52091e6..923f000743db5f3694698ffbecdb9a0a033ec4b4 100644 (file)
--- a/src/frontend/connection.c
+++ b/src/frontend/connection.c
@@ -376,6 +376,10 @@ command_init(sdb_conn_t *conn)
 
        len = 2 * sizeof(uint32_t);
        if (conn->cmd == CONNECTION_IDLE) {
+               const char *errmsg = "Invalid command 0";
+               sdb_strbuf_sprintf(conn->errbuf, errmsg);
+               sdb_connection_send(conn, CONNECTION_ERROR,
+                               (uint32_t)strlen(errmsg), errmsg);
                len += conn->cmd_len;
                conn->cmd_len = 0;
        }

diff --git a/t/unit/frontend/connection_test.c b/t/unit/frontend/connection_test.c
index 125bb56fffb9eb2c3d8f6753fcf5e9fd4b50644f..da94f06ec3cfd1bf5b1391e7249b98dd6b9a0f20 100644 (file)
--- a/t/unit/frontend/connection_test.c
+++ b/t/unit/frontend/connection_test.c
@@ -210,13 +210,13 @@ START_TEST(test_conn_setup)
                const char *err;
        } golden_data[] = {
                { UINT32_MAX,         NULL,       NULL },
-               { CONNECTION_IDLE,    "fakedata", NULL },
+               { CONNECTION_IDLE,    "fakedata", "Invalid command 0" },
                { CONNECTION_PING,    NULL,       "Authentication required" },
                { CONNECTION_STARTUP, "fakeuser", NULL },
                { CONNECTION_PING,    NULL,       NULL },
-               { CONNECTION_IDLE,    NULL,       NULL },
+               { CONNECTION_IDLE,    NULL,       "Invalid command 0" },
                { CONNECTION_PING,    "fakedata", NULL },
-               { CONNECTION_IDLE,    NULL,       NULL },
+               { CONNECTION_IDLE,    NULL,       "Invalid command 0" },
        };
 
        size_t i;