X-Git-Url: https://git.tokkee.org/?p=sysdb.git;a=blobdiff_plain;f=src%2Fcore%2Fstore.c;h=be8f9fa259406af1e31a2783560da81ca21776de;hp=1396669e4b58e53dd427f76ec5119f1ab1d7d669;hb=db527d05f4a9a790a09037c80a9465856ed89f1a;hpb=e04534362b8993b5400e0859aae9a38cfcc08aa6

diff --git a/src/core/store.c b/src/core/store.c
index 1396669..be8f9fa 100644
--- a/src/core/store.c
+++ b/src/core/store.c
@@ -50,17 +50,14 @@
  * private variables
  */
 
-typedef struct {
+struct sdb_store {
 	sdb_object_t super;
 
 	/* hosts are the top-level entries and
 	 * reference everything else */
 	sdb_avltree_t *hosts;
 	pthread_rwlock_t host_lock;
-} sdb_store_t;
-#define ST(obj) ((sdb_store_t *)(obj))
-
-sdb_store_t *global_store = NULL;
+};
 
 /*
  * private types
@@ -75,9 +72,10 @@ static int
 store_init(sdb_object_t *obj, va_list __attribute__((unused)) ap)
 {
 	int err;
-	if (! (ST(obj)->hosts = sdb_avltree_create()))
+	if (! (SDB_STORE(obj)->hosts = sdb_avltree_create()))
 		return -1;
-	if ((err = pthread_rwlock_init(&ST(obj)->host_lock, /* attr = */ NULL))) {
+	if ((err = pthread_rwlock_init(&SDB_STORE(obj)->host_lock,
+					/* attr = */ NULL))) {
 		char errbuf[128];
 		sdb_log(SDB_LOG_ERR, "store: Failed to initialize lock: %s",
 				sdb_strerror(err, errbuf, sizeof(errbuf)));
@@ -90,14 +88,14 @@ static void
 store_destroy(sdb_object_t *obj)
 {
 	int err;
-	if ((err = pthread_rwlock_destroy(&ST(obj)->host_lock))) {
+	if ((err = pthread_rwlock_destroy(&SDB_STORE(obj)->host_lock))) {
 		char errbuf[128];
 		sdb_log(SDB_LOG_ERR, "store: Failed to destroy lock: %s",
 				sdb_strerror(err, errbuf, sizeof(errbuf)));
 		return;
 	}
-	sdb_avltree_destroy(ST(obj)->hosts);
-	ST(obj)->hosts = NULL;
+	sdb_avltree_destroy(SDB_STORE(obj)->hosts);
+	SDB_STORE(obj)->hosts = NULL;
 } /* store_destroy */
 
 static int
@@ -299,28 +297,6 @@ static sdb_type_t attribute_type = {
  * private helper functions
  */
 
-static sdb_host_t *
-lookup_host(sdb_store_t *st, const char *name, bool canonicalize)
-{
-	sdb_host_t *host;
-	char *cname;
-
-	assert(name);
-	if (! canonicalize)
-		return HOST(sdb_avltree_lookup(st->hosts, name));
-
-	cname = strdup(name);
-	cname = sdb_plugin_cname(cname);
-	if (! cname) {
-		sdb_log(SDB_LOG_ERR, "store: strdup failed");
-		return NULL;
-	}
-
-	host = HOST(sdb_avltree_lookup(st->hosts, cname));
-	free(cname);
-	return host;
-} /* lookup_host */
-
 static int
 record_backend(sdb_store_obj_t *obj)
 {
@@ -582,7 +558,7 @@ store_attribute(const char *hostname,
 		const char *key, const sdb_data_t *value,
 		sdb_time_t last_update, sdb_object_t *user_data)
 {
-	sdb_store_t *st = ST(user_data);
+	sdb_store_t *st = SDB_STORE(user_data);
 
 	sdb_host_t *host;
 	sdb_avltree_t *attrs;
@@ -592,7 +568,7 @@ store_attribute(const char *hostname,
 		return -1;
 
 	pthread_rwlock_wrlock(&st->host_lock);
-	host = lookup_host(st, hostname, /* canonicalize = */ 1);
+	host = HOST(sdb_avltree_lookup(st->hosts, hostname));
 	attrs = get_host_children(host, SDB_ATTRIBUTE);
 	if (! attrs) {
 		sdb_log(SDB_LOG_ERR, "store: Failed to store attribute '%s' - "
@@ -612,26 +588,17 @@ store_attribute(const char *hostname,
 static int
 store_host(const char *name, sdb_time_t last_update, sdb_object_t *user_data)
 {
-	sdb_store_t *st = ST(user_data);
-
-	char *cname = NULL;
+	sdb_store_t *st = SDB_STORE(user_data);
 	int status = 0;
 
 	if (! name)
 		return -1;
 
-	cname = sdb_plugin_cname(strdup(name));
-	if (! cname) {
-		sdb_log(SDB_LOG_ERR, "store: strdup failed");
-		return -1;
-	}
-
 	pthread_rwlock_wrlock(&st->host_lock);
 	status = store_obj(NULL, st->hosts,
-			SDB_HOST, cname, last_update, NULL);
+			SDB_HOST, name, last_update, NULL);
 	pthread_rwlock_unlock(&st->host_lock);
 
-	free(cname);
 	return status;
 } /* store_host */
 
@@ -640,7 +607,7 @@ store_service_attr(const char *hostname, const char *service,
 		const char *key, const sdb_data_t *value, sdb_time_t last_update,
 		sdb_object_t *user_data)
 {
-	sdb_store_t *st = ST(user_data);
+	sdb_store_t *st = SDB_STORE(user_data);
 
 	sdb_host_t *host;
 	sdb_service_t *svc;
@@ -651,7 +618,7 @@ store_service_attr(const char *hostname, const char *service,
 		return -1;
 
 	pthread_rwlock_wrlock(&st->host_lock);
-	host = lookup_host(st, hostname, /* canonicalize = */ 1);
+	host = HOST(sdb_avltree_lookup(st->hosts, hostname));
 	services = get_host_children(host, SDB_SERVICE);
 	sdb_object_deref(SDB_OBJ(host));
 	if (! services) {
@@ -683,7 +650,7 @@ static int
 store_service(const char *hostname, const char *name,
 		sdb_time_t last_update, sdb_object_t *user_data)
 {
-	sdb_store_t *st = ST(user_data);
+	sdb_store_t *st = SDB_STORE(user_data);
 
 	sdb_host_t *host;
 	sdb_avltree_t *services;
@@ -695,7 +662,7 @@ store_service(const char *hostname, const char *name,
 		return -1;
 
 	pthread_rwlock_wrlock(&st->host_lock);
-	host = lookup_host(st, hostname, /* canonicalize = */ 1);
+	host = HOST(sdb_avltree_lookup(st->hosts, hostname));
 	services = get_host_children(host, SDB_SERVICE);
 	if (! services) {
 		sdb_log(SDB_LOG_ERR, "store: Failed to store service '%s' - "
@@ -726,7 +693,7 @@ store_metric_attr(const char *hostname, const char *metric,
 		const char *key, const sdb_data_t *value, sdb_time_t last_update,
 		sdb_object_t *user_data)
 {
-	sdb_store_t *st = ST(user_data);
+	sdb_store_t *st = SDB_STORE(user_data);
 
 	sdb_avltree_t *metrics;
 	sdb_host_t *host;
@@ -737,7 +704,7 @@ store_metric_attr(const char *hostname, const char *metric,
 		return -1;
 
 	pthread_rwlock_wrlock(&st->host_lock);
-	host = lookup_host(st, hostname, /* canonicalize = */ 1);
+	host = HOST(sdb_avltree_lookup(st->hosts, hostname));
 	metrics = get_host_children(host, SDB_METRIC);
 	sdb_object_deref(SDB_OBJ(host));
 	if (! metrics) {
@@ -770,7 +737,7 @@ store_metric(const char *hostname, const char *name,
 		sdb_metric_store_t *store, sdb_time_t last_update,
 		sdb_object_t *user_data)
 {
-	sdb_store_t *st = ST(user_data);
+	sdb_store_t *st = SDB_STORE(user_data);
 
 	sdb_store_obj_t *obj = NULL;
 	sdb_host_t *host;
@@ -792,7 +759,7 @@ store_metric(const char *hostname, const char *name,
 	}
 
 	pthread_rwlock_wrlock(&st->host_lock);
-	host = lookup_host(st, hostname, /* canonicalize = */ 1);
+	host = HOST(sdb_avltree_lookup(st->hosts, hostname));
 	metrics = get_host_children(host, SDB_METRIC);
 	if (! metrics) {
 		sdb_log(SDB_LOG_ERR, "store: Failed to store metric '%s' - "
@@ -826,104 +793,96 @@ store_metric(const char *hostname, const char *name,
 	return status;
 } /* store_metric */
 
-static sdb_store_writer_t store_writer = {
+sdb_store_writer_t sdb_store_writer = {
 	store_host, store_service, store_metric,
 	store_attribute, store_service_attr, store_metric_attr,
 };
 
-/*
- * public API
- */
+static sdb_object_t *
+prepare_query(sdb_ast_node_t *ast,
+		sdb_strbuf_t __attribute__((unused)) *errbuf,
+		sdb_object_t __attribute__((unused)) *user_data)
+{
+	return SDB_OBJ(sdb_store_query_prepare(ast));
+} /* prepare_query */
 
-int
-sdb_store_init(void)
+static int
+execute_query(sdb_object_t *q,
+		sdb_strbuf_t *buf, sdb_strbuf_t *errbuf,
+		sdb_object_t *user_data)
 {
-	if (global_store)
-		return 0;
+	return sdb_store_query_execute(SDB_STORE(user_data),
+			QUERY(q), buf, errbuf);
+} /* execute_query */
 
-	global_store = ST(sdb_object_create("store", store_type));
-	if (! global_store) {
-		sdb_log(SDB_LOG_ERR, "store: Failed to allocate store");
-		return -1;
-	}
-	return sdb_plugin_register_writer("memstore",
-			&store_writer, SDB_OBJ(global_store));
-} /* sdb_store_init */
+sdb_store_reader_t sdb_store_reader = {
+	prepare_query, execute_query,
+};
 
-void
-sdb_store_clear(void)
+/*
+ * public API
+ */
+
+sdb_store_t *
+sdb_store_create(void)
 {
-	if (! global_store)
-		return;
-	sdb_avltree_clear(global_store->hosts);
-} /* sdb_store_clear */
+	return SDB_STORE(sdb_object_create("store", store_type));
+} /* sdb_store_create */
 
 int
-sdb_store_host(const char *name, sdb_time_t last_update)
+sdb_store_host(sdb_store_t *store, const char *name, sdb_time_t last_update)
 {
-	return sdb_plugin_store_host(name, last_update);
+	return store_host(name, last_update, SDB_OBJ(store));
 } /* sdb_store_host */
 
 int
-sdb_store_attribute(const char *hostname,
-		const char *key, const sdb_data_t *value,
+sdb_store_service(sdb_store_t *store, const char *hostname, const char *name,
 		sdb_time_t last_update)
 {
-	return sdb_plugin_store_attribute(hostname, key, value, last_update);
-} /* sdb_store_attribute */
+	return store_service(hostname, name, last_update, SDB_OBJ(store));
+} /* sdb_store_service */
 
 int
-sdb_store_service(const char *hostname, const char *name,
-		sdb_time_t last_update)
+sdb_store_metric(sdb_store_t *store, const char *hostname, const char *name,
+		sdb_metric_store_t *metric_store, sdb_time_t last_update)
 {
-	return sdb_plugin_store_service(hostname, name, last_update);
-} /* sdb_store_service */
+	return store_metric(hostname, name, metric_store, last_update, SDB_OBJ(store));
+} /* sdb_store_metric */
 
 int
-sdb_store_service_attr(const char *hostname, const char *service,
+sdb_store_attribute(sdb_store_t *store, const char *hostname,
 		const char *key, const sdb_data_t *value, sdb_time_t last_update)
 {
-	return sdb_plugin_store_service_attribute(hostname, service,
-			key, value, last_update);
-} /* sdb_store_service_attr */
+	return store_attribute(hostname, key, value, last_update, SDB_OBJ(store));
+} /* sdb_store_attribute */
 
 int
-sdb_store_metric(const char *hostname, const char *name,
-		sdb_metric_store_t *store, sdb_time_t last_update)
+sdb_store_service_attr(sdb_store_t *store, const char *hostname,
+		const char *service, const char *key, const sdb_data_t *value,
+		sdb_time_t last_update)
 {
-	return sdb_plugin_store_metric(hostname, name, store, last_update);
-} /* sdb_store_metric */
+	return store_service_attr(hostname, service, key, value,
+			last_update, SDB_OBJ(store));
+} /* sdb_store_service_attr */
 
 int
-sdb_store_metric_attr(const char *hostname, const char *metric,
-		const char *key, const sdb_data_t *value, sdb_time_t last_update)
+sdb_store_metric_attr(sdb_store_t *store, const char *hostname,
+		const char *metric, const char *key, const sdb_data_t *value,
+		sdb_time_t last_update)
 {
-	return sdb_plugin_store_metric_attribute(hostname, metric,
-			key, value, last_update);
+	return store_metric_attr(hostname, metric, key, value,
+			last_update, SDB_OBJ(store));
 } /* sdb_store_metric_attr */
 
-bool
-sdb_store_has_host(const char *name)
-{
-	sdb_host_t *host;
-
-	if ((! global_store) || (! name))
-		return false;
-
-	host = lookup_host(global_store, name, /* canonicalize = */ 0);
-	sdb_object_deref(SDB_OBJ(host));
-	return host != NULL;
-} /* sdb_store_has_host */
-
 sdb_store_obj_t *
-sdb_store_get_host(const char *name)
+sdb_store_get_host(sdb_store_t *store, const char *name)
 {
 	sdb_host_t *host;
 
-	if ((! global_store) || (! name))
+	if ((! store) || (! name))
 		return NULL;
 
-	host = lookup_host(global_store, name, /* canonicalize = */ 0);
+	host = HOST(sdb_avltree_lookup(store->hosts, name));
 	if (! host)
 		return NULL;
 
@@ -1034,8 +993,11 @@ sdb_store_get_attr(sdb_store_obj_t *obj, const char *name, sdb_data_t *res,
 	return 0;
 } /* sdb_store_get_attr */
 
+/* TODO: sdb_store_fetch_timeseries should move into the plugin module */
+
 int
-sdb_store_fetch_timeseries(const char *hostname, const char *metric,
+sdb_store_fetch_timeseries(sdb_store_t *store,
+		const char *hostname, const char *metric,
 		sdb_timeseries_opts_t *opts, sdb_strbuf_t *buf)
 {
 	sdb_avltree_t *metrics;
@@ -1046,17 +1008,17 @@ sdb_store_fetch_timeseries(const char *hostname, const char *metric,
 
 	int status = 0;
 
-	if ((! global_store) || (! hostname) || (! metric) || (! opts) || (! buf))
+	if ((! store) || (! hostname) || (! metric) || (! opts) || (! buf))
 		return -1;
 
-	pthread_rwlock_rdlock(&global_store->host_lock);
-	host = lookup_host(global_store, hostname, /* canonicalize = */ 1);
+	pthread_rwlock_rdlock(&store->host_lock);
+	host = HOST(sdb_avltree_lookup(store->hosts, hostname));
 	metrics = get_host_children(host, SDB_METRIC);
 	sdb_object_deref(SDB_OBJ(host));
 	if (! metrics) {
 		sdb_log(SDB_LOG_ERR, "store: Failed to fetch time-series '%s/%s' "
 				"- host '%s' not found", hostname, metric, hostname);
-		pthread_rwlock_unlock(&global_store->host_lock);
+		pthread_rwlock_unlock(&store->host_lock);
 		return -1;
 	}
 
@@ -1064,7 +1026,7 @@ sdb_store_fetch_timeseries(const char *hostname, const char *metric,
 	if (! m) {
 		sdb_log(SDB_LOG_ERR, "store: Failed to fetch time-series '%s/%s' "
 				"- metric '%s' not found", hostname, metric, metric);
-		pthread_rwlock_unlock(&global_store->host_lock);
+		pthread_rwlock_unlock(&store->host_lock);
 		return -1;
 	}
 
@@ -1073,7 +1035,7 @@ sdb_store_fetch_timeseries(const char *hostname, const char *metric,
 				"- no data-store configured for the stored metric",
 				hostname, metric);
 		sdb_object_deref(SDB_OBJ(m));
-		pthread_rwlock_unlock(&global_store->host_lock);
+		pthread_rwlock_unlock(&store->host_lock);
 		return -1;
 	}
 
@@ -1083,7 +1045,7 @@ sdb_store_fetch_timeseries(const char *hostname, const char *metric,
 
 		strncpy(type, m->store.type, sizeof(type));
 		strncpy(id, m->store.id, sizeof(id));
-		pthread_rwlock_unlock(&global_store->host_lock);
+		pthread_rwlock_unlock(&store->host_lock);
 
 		ts = sdb_plugin_fetch_timeseries(type, id, opts);
 		if (! ts) {
@@ -1101,13 +1063,14 @@ sdb_store_fetch_timeseries(const char *hostname, const char *metric,
 } /* sdb_store_fetch_timeseries */
 
 int
-sdb_store_scan(int type, sdb_store_matcher_t *m, sdb_store_matcher_t *filter,
+sdb_store_scan(sdb_store_t *store, int type,
+		sdb_store_matcher_t *m, sdb_store_matcher_t *filter,
 		sdb_store_lookup_cb cb, void *user_data)
 {
 	sdb_avltree_iter_t *host_iter = NULL;
 	int status = 0;
 
-	if ((! global_store) || (! cb))
+	if ((! store) || (! cb))
 		return -1;
 
 	if ((type != SDB_HOST) && (type != SDB_SERVICE) && (type != SDB_METRIC)) {
@@ -1115,8 +1078,8 @@ sdb_store_scan(int type, sdb_store_matcher_t *m, sdb_store_matcher_t *filter,
 		return -1;
 	}
 
-	pthread_rwlock_rdlock(&global_store->host_lock);
-	host_iter = sdb_avltree_get_iter(global_store->hosts);
+	pthread_rwlock_rdlock(&store->host_lock);
+	host_iter = sdb_avltree_get_iter(store->hosts);
 	if (! host_iter)
 		status = -1;
 
@@ -1166,7 +1129,7 @@ sdb_store_scan(int type, sdb_store_matcher_t *m, sdb_store_matcher_t *filter,
 	}
 
 	sdb_avltree_iter_destroy(host_iter);
-	pthread_rwlock_unlock(&global_store->host_lock);
+	pthread_rwlock_unlock(&store->host_lock);
 	return status;
 } /* sdb_store_scan */