![[tokkee]](http://tokkee.org/images/avatar.png){kind=avatar}
diff --git a/src/core/store.c b/src/core/store.c
index f6c65bcf7cd2604ac78889688186ebf3d2133b18..7671e9800f13a0ac0a81e2b24817d95b0f0a83ef 100644 (file)
--- a/src/core/store.c
+++ b/src/core/store.c
} /* ts_tojson */
/*
- * public API
+ * store writer API
*/
-int
-sdb_store_init(void)
+static int
+store_attribute(const char *hostname,
+ const char *key, const sdb_data_t *value,
+ sdb_time_t last_update, sdb_object_t *user_data)
{
- if (global_store)
- return 0;
+ sdb_store_t *st = ST(user_data);
- global_store = ST(sdb_object_create("store", store_type));
- if (! global_store) {
- sdb_log(SDB_LOG_ERR, "store: Failed to allocate store");
+ sdb_host_t *host;
+ sdb_avltree_t *attrs;
+ int status = 0;
+
+ if ((! hostname) || (! key))
return -1;
+
+ pthread_rwlock_wrlock(&st->host_lock);
+ host = lookup_host(st, hostname, /* canonicalize = */ 1);
+ attrs = get_host_children(host, SDB_ATTRIBUTE);
+ if (! attrs) {
+ sdb_log(SDB_LOG_ERR, "store: Failed to store attribute '%s' - "
+ "host '%s' not found", key, hostname);
+ status = -1;
}
- return 0;
-} /* sdb_store_init */
-void
-sdb_store_clear(void)
-{
- if (! global_store)
- return;
- sdb_avltree_clear(global_store->hosts);
-} /* sdb_store_clear */
+ if (! status)
+ status = store_attr(STORE_OBJ(host), attrs, key, value, last_update);
-int
-sdb_store_host(const char *name, sdb_time_t last_update)
+ sdb_object_deref(SDB_OBJ(host));
+ pthread_rwlock_unlock(&st->host_lock);
+
+ return status;
+} /* store_attribute */
+
+static int
+store_host(const char *name, sdb_time_t last_update, sdb_object_t *user_data)
{
+ sdb_store_t *st = ST(user_data);
+
char *cname = NULL;
int status = 0;
- if ((! global_store) || (! name))
+ if (! name)
return -1;
cname = sdb_plugin_cname(strdup(name));
return -1;
}
- pthread_rwlock_wrlock(&global_store->host_lock);
- status = store_obj(NULL, global_store->hosts,
+ pthread_rwlock_wrlock(&st->host_lock);
+ status = store_obj(NULL, st->hosts,
SDB_HOST, cname, last_update, NULL);
- pthread_rwlock_unlock(&global_store->host_lock);
-
- if (sdb_plugin_store_host(name, last_update))
- status = -1;
+ pthread_rwlock_unlock(&st->host_lock);
free(cname);
return status;
-} /* sdb_store_host */
-
-bool
-sdb_store_has_host(const char *name)
-{
- sdb_host_t *host;
-
- if ((! global_store) || (! name))
- return false;
+} /* store_host */
- host = lookup_host(global_store, name, /* canonicalize = */ 0);
- sdb_object_deref(SDB_OBJ(host));
- return host != NULL;
-} /* sdb_store_has_host */
-
-sdb_store_obj_t *
-sdb_store_get_host(const char *name)
+static int
+store_service_attr(const char *hostname, const char *service,
+ const char *key, const sdb_data_t *value, sdb_time_t last_update,
+ sdb_object_t *user_data)
{
- sdb_host_t *host;
+ sdb_store_t *st = ST(user_data);
- if ((! global_store) || (! name))
- return NULL;
-
- host = lookup_host(global_store, name, /* canonicalize = */ 0);
- if (! host)
- return NULL;
-
- return STORE_OBJ(host);
-} /* sdb_store_get_host */
-
-int
-sdb_store_attribute(const char *hostname,
- const char *key, const sdb_data_t *value,
- sdb_time_t last_update)
-{
sdb_host_t *host;
- sdb_avltree_t *attrs;
+ sdb_service_t *svc;
+ sdb_avltree_t *services;
int status = 0;
- if ((! global_store) || (! hostname) || (! key))
+ if ((! hostname) || (! service) || (! key))
return -1;
- pthread_rwlock_wrlock(&global_store->host_lock);
- host = lookup_host(global_store, hostname, /* canonicalize = */ 1);
- attrs = get_host_children(host, SDB_ATTRIBUTE);
- if (! attrs) {
+ pthread_rwlock_wrlock(&st->host_lock);
+ host = lookup_host(st, hostname, /* canonicalize = */ 1);
+ services = get_host_children(host, SDB_SERVICE);
+ sdb_object_deref(SDB_OBJ(host));
+ if (! services) {
+ sdb_log(SDB_LOG_ERR, "store: Failed to store attribute '%s' "
+ "for service '%s' - host '%ss' not found",
+ key, service, hostname);
+ pthread_rwlock_unlock(&st->host_lock);
+ return -1;
+ }
+
+ svc = SVC(sdb_avltree_lookup(services, service));
+ if (! svc) {
sdb_log(SDB_LOG_ERR, "store: Failed to store attribute '%s' - "
- "host '%s' not found", key, hostname);
+ "service '%s/%s' not found", key, hostname, service);
status = -1;
}
if (! status)
- status = store_attr(STORE_OBJ(host), attrs, key, value, last_update);
+ status = store_attr(STORE_OBJ(svc), svc->attributes,
+ key, value, last_update);
- sdb_object_deref(SDB_OBJ(host));
- pthread_rwlock_unlock(&global_store->host_lock);
+ sdb_object_deref(SDB_OBJ(svc));
+ pthread_rwlock_unlock(&st->host_lock);
- if (sdb_plugin_store_attribute(hostname, key, value, last_update))
- status = -1;
return status;
-} /* sdb_store_attribute */
+} /* store_service_attr */
-int
-sdb_store_service(const char *hostname, const char *name,
- sdb_time_t last_update)
+static int
+store_service(const char *hostname, const char *name,
+ sdb_time_t last_update, sdb_object_t *user_data)
{
+ sdb_store_t *st = ST(user_data);
+
sdb_host_t *host;
sdb_avltree_t *services;
sdb_data_t d;
int status = 0;
- if ((! global_store) || (! hostname) || (! name))
+ if ((! hostname) || (! name))
return -1;
- pthread_rwlock_wrlock(&global_store->host_lock);
- host = lookup_host(global_store, hostname, /* canonicalize = */ 1);
+ pthread_rwlock_wrlock(&st->host_lock);
+ host = lookup_host(st, hostname, /* canonicalize = */ 1);
services = get_host_children(host, SDB_SERVICE);
if (! services) {
sdb_log(SDB_LOG_ERR, "store: Failed to store service '%s' - "
name, last_update, NULL);
sdb_object_deref(SDB_OBJ(host));
- pthread_rwlock_unlock(&global_store->host_lock);
+ pthread_rwlock_unlock(&st->host_lock);
if (status)
return status;
- if (sdb_plugin_store_service(hostname, name, last_update))
- status = -1;
-
/* record the hostname as an attribute */
d.type = SDB_TYPE_STRING;
d.data.string = SDB_OBJ(host)->name;
- if (sdb_store_service_attr(hostname, name, "hostname", &d, last_update))
+ if (store_service_attr(hostname, name, "hostname", &d, last_update, user_data))
status = -1;
return status;
-} /* sdb_store_service */
+} /* store_service */
-int
-sdb_store_service_attr(const char *hostname, const char *service,
- const char *key, const sdb_data_t *value, sdb_time_t last_update)
+static int
+store_metric_attr(const char *hostname, const char *metric,
+ const char *key, const sdb_data_t *value, sdb_time_t last_update,
+ sdb_object_t *user_data)
{
+ sdb_store_t *st = ST(user_data);
+
+ sdb_avltree_t *metrics;
sdb_host_t *host;
- sdb_service_t *svc;
- sdb_avltree_t *services;
+ sdb_metric_t *m;
int status = 0;
- if ((! global_store) || (! hostname) || (! service) || (! key))
+ if ((! hostname) || (! metric) || (! key))
return -1;
- pthread_rwlock_wrlock(&global_store->host_lock);
- host = lookup_host(global_store, hostname, /* canonicalize = */ 1);
- services = get_host_children(host, SDB_SERVICE);
+ pthread_rwlock_wrlock(&st->host_lock);
+ host = lookup_host(st, hostname, /* canonicalize = */ 1);
+ metrics = get_host_children(host, SDB_METRIC);
sdb_object_deref(SDB_OBJ(host));
- if (! services) {
+ if (! metrics) {
sdb_log(SDB_LOG_ERR, "store: Failed to store attribute '%s' "
- "for service '%s' - host '%ss' not found",
- key, service, hostname);
- pthread_rwlock_unlock(&global_store->host_lock);
+ "for metric '%s' - host '%s' not found",
+ key, metric, hostname);
+ pthread_rwlock_unlock(&st->host_lock);
return -1;
}
- svc = SVC(sdb_avltree_lookup(services, service));
- if (! svc) {
+ m = METRIC(sdb_avltree_lookup(metrics, metric));
+ if (! m) {
sdb_log(SDB_LOG_ERR, "store: Failed to store attribute '%s' - "
- "service '%s/%s' not found", key, hostname, service);
+ "metric '%s/%s' not found", key, hostname, metric);
status = -1;
}
if (! status)
- status = store_attr(STORE_OBJ(svc), svc->attributes,
+ status = store_attr(STORE_OBJ(m), m->attributes,
key, value, last_update);
- sdb_object_deref(SDB_OBJ(svc));
- pthread_rwlock_unlock(&global_store->host_lock);
+ sdb_object_deref(SDB_OBJ(m));
+ pthread_rwlock_unlock(&st->host_lock);
- if (sdb_plugin_store_service_attribute(hostname, service,
- key, value, last_update))
- status = -1;
return status;
-} /* sdb_store_service_attr */
+} /* store_metric_attr */
-int
-sdb_store_metric(const char *hostname, const char *name,
- sdb_metric_store_t *store, sdb_time_t last_update)
+static int
+store_metric(const char *hostname, const char *name,
+ sdb_metric_store_t *store, sdb_time_t last_update,
+ sdb_object_t *user_data)
{
+ sdb_store_t *st = ST(user_data);
+
sdb_store_obj_t *obj = NULL;
sdb_host_t *host;
sdb_metric_t *metric;
int status = 0;
- if ((! global_store) || (! hostname) || (! name))
+ if ((! hostname) || (! name))
return -1;
if (store) {
store = NULL;
}
- pthread_rwlock_wrlock(&global_store->host_lock);
- host = lookup_host(global_store, hostname, /* canonicalize = */ 1);
+ pthread_rwlock_wrlock(&st->host_lock);
+ host = lookup_host(st, hostname, /* canonicalize = */ 1);
metrics = get_host_children(host, SDB_METRIC);
if (! metrics) {
sdb_log(SDB_LOG_ERR, "store: Failed to store metric '%s' - "
sdb_object_deref(SDB_OBJ(host));
if (status) {
- pthread_rwlock_unlock(&global_store->host_lock);
+ pthread_rwlock_unlock(&st->host_lock);
return status;
}
if (store)
if (store_metric_store(metric, store))
status = -1;
- pthread_rwlock_unlock(&global_store->host_lock);
-
- if (sdb_plugin_store_metric(hostname, name, store, last_update))
- status = -1;
+ pthread_rwlock_unlock(&st->host_lock);
/* record the hostname as an attribute */
d.type = SDB_TYPE_STRING;
d.data.string = SDB_OBJ(host)->name;
- if (sdb_store_metric_attr(hostname, name, "hostname", &d, last_update))
+ if (store_metric_attr(hostname, name, "hostname", &d, last_update, user_data))
status = -1;
return status;
-} /* sdb_store_metric */
+} /* store_metric */
-int
-sdb_store_metric_attr(const char *hostname, const char *metric,
- const char *key, const sdb_data_t *value, sdb_time_t last_update)
+static sdb_store_writer_t store_writer = {
+ store_host, store_service, store_metric,
+ store_attribute, store_service_attr, store_metric_attr,
+};
+
+/*
+ * TODO: let prepare and execute accept a store object as their user_data
+ * object
+ */
+
+static sdb_object_t *
+prepare_query(sdb_ast_node_t *ast,
+ sdb_strbuf_t __attribute__((unused)) *errbuf,
+ sdb_object_t __attribute__((unused)) *user_data)
{
- sdb_avltree_t *metrics;
- sdb_host_t *host;
- sdb_metric_t *m;
- int status = 0;
+ return SDB_OBJ(sdb_store_query_prepare(ast));
+} /* prepare_query */
- if ((! global_store) || (! hostname) || (! metric) || (! key))
- return -1;
+static int
+execute_query(sdb_object_t *q,
+ sdb_strbuf_t *buf, sdb_strbuf_t *errbuf,
+ sdb_object_t __attribute__((unused)) *user_data)
+{
+ return sdb_store_query_execute(QUERY(q), buf, errbuf);
+} /* execute_query */
- pthread_rwlock_wrlock(&global_store->host_lock);
- host = lookup_host(global_store, hostname, /* canonicalize = */ 1);
- metrics = get_host_children(host, SDB_METRIC);
- sdb_object_deref(SDB_OBJ(host));
- if (! metrics) {
- sdb_log(SDB_LOG_ERR, "store: Failed to store attribute '%s' "
- "for metric '%s' - host '%s' not found",
- key, metric, hostname);
- pthread_rwlock_unlock(&global_store->host_lock);
+static sdb_store_reader_t store_reader = {
+ prepare_query, execute_query,
+};
+
+/*
+ * public API
+ */
+
+int
+sdb_store_init(void)
+{
+ if (global_store)
+ return 0;
+
+ global_store = ST(sdb_object_create("store", store_type));
+ if (! global_store) {
+ sdb_log(SDB_LOG_ERR, "store: Failed to allocate store");
return -1;
}
+ if (sdb_plugin_register_writer("memstore",
+ &store_writer, SDB_OBJ(global_store)))
+ return -1;
+ return sdb_plugin_register_reader("memstore",
+ &store_reader, SDB_OBJ(global_store));
+} /* sdb_store_init */
- m = METRIC(sdb_avltree_lookup(metrics, metric));
- if (! m) {
- sdb_log(SDB_LOG_ERR, "store: Failed to store attribute '%s' - "
- "metric '%s/%s' not found", key, hostname, metric);
- status = -1;
- }
+void
+sdb_store_clear(void)
+{
+ if (! global_store)
+ return;
+ sdb_avltree_clear(global_store->hosts);
+} /* sdb_store_clear */
- if (! status)
- status = store_attr(STORE_OBJ(m), m->attributes,
- key, value, last_update);
+sdb_store_obj_t *
+sdb_store_get_host(const char *name)
+{
+ sdb_host_t *host;
- sdb_object_deref(SDB_OBJ(m));
- pthread_rwlock_unlock(&global_store->host_lock);
+ if ((! global_store) || (! name))
+ return NULL;
- if (sdb_plugin_store_metric_attribute(hostname, metric,
- key, value, last_update))
- status = -1;
- return status;
-} /* sdb_store_metric_attr */
+ host = lookup_host(global_store, name, /* canonicalize = */ 0);
+ if (! host)
+ return NULL;
+
+ return STORE_OBJ(host);
+} /* sdb_store_get_host */
sdb_store_obj_t *
sdb_store_get_child(sdb_store_obj_t *host, int type, const char *name)
return STORE_OBJ(sdb_avltree_lookup(children, name));
} /* sdb_store_get_child */
-int
-sdb_store_fetch_timeseries(const char *hostname, const char *metric,
- sdb_timeseries_opts_t *opts, sdb_strbuf_t *buf)
-{
- sdb_avltree_t *metrics;
- sdb_host_t *host;
- sdb_metric_t *m;
-
- sdb_timeseries_t *ts;
-
- int status = 0;
-
- if ((! global_store) || (! hostname) || (! metric) || (! opts) || (! buf))
- return -1;
-
- pthread_rwlock_rdlock(&global_store->host_lock);
- host = lookup_host(global_store, hostname, /* canonicalize = */ 1);
- metrics = get_host_children(host, SDB_METRIC);
- sdb_object_deref(SDB_OBJ(host));
- if (! metrics) {
- sdb_log(SDB_LOG_ERR, "store: Failed to fetch time-series '%s/%s' "
- "- host '%s' not found", hostname, metric, hostname);
- pthread_rwlock_unlock(&global_store->host_lock);
- return -1;
- }
-
- m = METRIC(sdb_avltree_lookup(metrics, metric));
- if (! m) {
- sdb_log(SDB_LOG_ERR, "store: Failed to fetch time-series '%s/%s' "
- "- metric '%s' not found", hostname, metric, metric);
- pthread_rwlock_unlock(&global_store->host_lock);
- return -1;
- }
-
- if ((! m->store.type) || (! m->store.id)) {
- sdb_log(SDB_LOG_ERR, "store: Failed to fetch time-series '%s/%s' "
- "- no data-store configured for the stored metric",
- hostname, metric);
- sdb_object_deref(SDB_OBJ(m));
- pthread_rwlock_unlock(&global_store->host_lock);
- return -1;
- }
-
- {
- char type[strlen(m->store.type) + 1];
- char id[strlen(m->store.id) + 1];
-
- strncpy(type, m->store.type, sizeof(type));
- strncpy(id, m->store.id, sizeof(id));
- pthread_rwlock_unlock(&global_store->host_lock);
-
- ts = sdb_plugin_fetch_timeseries(type, id, opts);
- if (! ts) {
- sdb_log(SDB_LOG_ERR, "store: Failed to fetch time-series '%s/%s' "
- "- %s fetcher callback returned no data for '%s'",
- hostname, metric, type, id);
- status = -1;
- }
- }
-
- ts_tojson(ts, buf);
- sdb_object_deref(SDB_OBJ(m));
- sdb_timeseries_destroy(ts);
- return status;
-} /* sdb_store_fetch_timeseries */
-
int
sdb_store_get_field(sdb_store_obj_t *obj, int field, sdb_data_t *res)
{
return 0;
} /* sdb_store_get_attr */
+/* TODO: sdb_store_fetch_timeseries should move into the plugin module */
+
+int
+sdb_store_fetch_timeseries(const char *hostname, const char *metric,
+ sdb_timeseries_opts_t *opts, sdb_strbuf_t *buf)
+{
+ sdb_avltree_t *metrics;
+ sdb_host_t *host;
+ sdb_metric_t *m;
+
+ sdb_timeseries_t *ts;
+
+ int status = 0;
+
+ if ((! global_store) || (! hostname) || (! metric) || (! opts) || (! buf))
+ return -1;
+
+ pthread_rwlock_rdlock(&global_store->host_lock);
+ host = lookup_host(global_store, hostname, /* canonicalize = */ 1);
+ metrics = get_host_children(host, SDB_METRIC);
+ sdb_object_deref(SDB_OBJ(host));
+ if (! metrics) {
+ sdb_log(SDB_LOG_ERR, "store: Failed to fetch time-series '%s/%s' "
+ "- host '%s' not found", hostname, metric, hostname);
+ pthread_rwlock_unlock(&global_store->host_lock);
+ return -1;
+ }
+
+ m = METRIC(sdb_avltree_lookup(metrics, metric));
+ if (! m) {
+ sdb_log(SDB_LOG_ERR, "store: Failed to fetch time-series '%s/%s' "
+ "- metric '%s' not found", hostname, metric, metric);
+ pthread_rwlock_unlock(&global_store->host_lock);
+ return -1;
+ }
+
+ if ((! m->store.type) || (! m->store.id)) {
+ sdb_log(SDB_LOG_ERR, "store: Failed to fetch time-series '%s/%s' "
+ "- no data-store configured for the stored metric",
+ hostname, metric);
+ sdb_object_deref(SDB_OBJ(m));
+ pthread_rwlock_unlock(&global_store->host_lock);
+ return -1;
+ }
+
+ {
+ char type[strlen(m->store.type) + 1];
+ char id[strlen(m->store.id) + 1];
+
+ strncpy(type, m->store.type, sizeof(type));
+ strncpy(id, m->store.id, sizeof(id));
+ pthread_rwlock_unlock(&global_store->host_lock);
+
+ ts = sdb_plugin_fetch_timeseries(type, id, opts);
+ if (! ts) {
+ sdb_log(SDB_LOG_ERR, "store: Failed to fetch time-series '%s/%s' "
+ "- %s fetcher callback returned no data for '%s'",
+ hostname, metric, type, id);
+ status = -1;
+ }
+ }
+
+ ts_tojson(ts, buf);
+ sdb_object_deref(SDB_OBJ(m));
+ sdb_timeseries_destroy(ts);
+ return status;
+} /* sdb_store_fetch_timeseries */
+
int
sdb_store_scan(int type, sdb_store_matcher_t *m, sdb_store_matcher_t *filter,
sdb_store_lookup_cb cb, void *user_data)