X-Git-Url: https://git.tokkee.org/?p=rrdtool.git;a=blobdiff_plain;f=src%2Frrd_graph_helper.c;fp=src%2Frrd_graph_helper.c;h=912dea6c73b226c6dc060524c3c374943cebbdf5;hp=086f5c6f34a295925473fcb2ce499f76d953b1e7;hb=07c12ec4a3094cedd00628d33ca077338c60e96b;hpb=2a5dc89618904fdcbc2bd4db19ab3ce1be8fcd7c

diff --git a/src/rrd_graph_helper.c b/src/rrd_graph_helper.c
index 086f5c6..912dea6 100644
--- a/src/rrd_graph_helper.c
+++ b/src/rrd_graph_helper.c
@@ -73,17 +73,16 @@ char* checkUnusedValues(parsedargs_t* pa){
   char *res=NULL;
   for(int i=0;i<pa->kv_cnt;i++) {
     if (!pa->kv_args[i].flag) {
-      int len=0;
-      if (res) {len=strlen(res); }
-      char* t=realloc(res,len+3
-		      +strlen(pa->kv_args[i].key)
-		      +strlen(pa->kv_args[i].value)
-		      );
+      const size_t klen = strlen(pa->kv_args[i].key);
+      const size_t vlen = strlen(pa->kv_args[i].value);
+      const size_t len = res ? strlen(res) : 0;
+
+      char *t = realloc(res,len + 3 + klen + vlen);
       if (! t) { return res; }
       res=t;
-      strcat(res,pa->kv_args[i].key);
+      strncat(res,pa->kv_args[i].key, klen);
       strcat(res,"=");
-      strcat(res,pa->kv_args[i].value);
+      strncat(res,pa->kv_args[i].value, vlen);
       strcat(res,":");
     }
   }