Code

ncmpc.git
12 years agoncmpc version 0.20 release-0.20 v0.20
Avuton Olrich [Sun, 5 Feb 2012 19:25:25 +0000 (11:25 -0800)]
ncmpc version 0.20

12 years agoconfigure.ac: Don't add CURSES_LIB to AM_CPPFLAGS
Jonathan Neuschäfer [Sat, 21 Jan 2012 23:00:06 +0000 (00:00 +0100)]
configure.ac: Don't add CURSES_LIB to AM_CPPFLAGS

12 years agoscreen_keydef: don't crash on Ctrl-Space
Jonathan Neuschäfer [Fri, 3 Feb 2012 18:44:33 +0000 (19:44 +0100)]
screen_keydef: don't crash on Ctrl-Space

12 years agocommand: don't crash on Ctrl-Space
Jonathan Neuschäfer [Fri, 3 Feb 2012 18:43:46 +0000 (19:43 +0100)]
command: don't crash on Ctrl-Space

12 years agoscreen_keydef: use inline functions instead of macros for non-constants
Jonathan Neuschäfer [Wed, 4 Jan 2012 20:08:26 +0000 (21:08 +0100)]
screen_keydef: use inline functions instead of macros for non-constants

12 years agoconf.c: return void in read_configuration
Jonathan Neuschäfer [Thu, 29 Dec 2011 13:23:06 +0000 (14:23 +0100)]
conf.c: return void in read_configuration

12 years agoshow the path of the config files in --version output
Jonathan Neuschäfer [Wed, 4 Jan 2012 19:36:05 +0000 (20:36 +0100)]
show the path of the config files in --version output

fixes http://musicpd.org/mantis/view.php?id=3354

12 years agoconf: helper functions to build config file names
Jonathan Neuschäfer [Wed, 4 Jan 2012 19:36:05 +0000 (20:36 +0100)]
conf: helper functions to build config file names

12 years agoconf: rename get_user_key_binding_filename to build_*
Jonathan Neuschäfer [Wed, 4 Jan 2012 19:36:04 +0000 (20:36 +0100)]
conf: rename get_user_key_binding_filename to build_*

This name is consistent with g_build_filename and it better reflects
the fact that memory is allocatd by this function.

12 years agoncmpc.1: update --version documentation
Jonathan Neuschäfer [Wed, 4 Jan 2012 19:36:04 +0000 (20:36 +0100)]
ncmpc.1: update --version documentation

12 years agoMerge remote branches 'jn/keydef' and 'jn/dev'
Max Kellermann [Wed, 4 Jan 2012 19:21:11 +0000 (20:21 +0100)]
Merge remote branches 'jn/keydef' and 'jn/dev'

12 years agoscreen_keydef: join two short-ish lines
Jonathan Neuschäfer [Wed, 28 Dec 2011 22:39:26 +0000 (23:39 +0100)]
screen_keydef: join two short-ish lines

12 years agoscreen_keydef: support CMD_GO_ROOT_DIRECTORY
Jonathan Neuschäfer [Wed, 28 Dec 2011 22:37:00 +0000 (23:37 +0100)]
screen_keydef: support CMD_GO_ROOT_DIRECTORY

Maybe a bit pointless, but some user might want that.

12 years agoscreen_keydef: support adding keys with CMD_ADD
Jonathan Neuschäfer [Wed, 28 Dec 2011 22:18:51 +0000 (23:18 +0100)]
screen_keydef: support adding keys with CMD_ADD

12 years agoAUTHORS: fix some grammar ("whom"/"who")
Jonathan Neuschäfer [Sat, 29 Oct 2011 14:05:03 +0000 (16:05 +0200)]
AUTHORS: fix some grammar ("whom"/"who")

This commit lacks a good description.

12 years agompdclient: add G_GNUC_PURE to _is_connected()/_get_current_song()
Jonathan Neuschäfer [Wed, 4 Jan 2012 17:50:28 +0000 (18:50 +0100)]
mpdclient: add G_GNUC_PURE to _is_connected()/_get_current_song()

12 years agoscreen_queue: fix indentation after #ifndef block
Jonathan Neuschäfer [Fri, 30 Dec 2011 11:14:07 +0000 (12:14 +0100)]
screen_queue: fix indentation after #ifndef block

12 years agoconf: make "hardware-cursor" a macro
Jonathan Neuschäfer [Thu, 29 Dec 2011 21:04:13 +0000 (22:04 +0100)]
conf: make "hardware-cursor" a macro

12 years agoremove obsolete str_pool.c and str_pool.h
Jonathan Neuschäfer [Thu, 29 Dec 2011 20:17:43 +0000 (21:17 +0100)]
remove obsolete str_pool.c and str_pool.h

12 years agocommand.c: remove obsolete DEBUG_KEYS and DK()
Jonathan Neuschäfer [Thu, 29 Dec 2011 13:53:24 +0000 (14:53 +0100)]
command.c: remove obsolete DEBUG_KEYS and DK()

12 years agoconf.c: use g_mkdir for WIN32 compatibility
Jonathan Neuschäfer [Tue, 27 Dec 2011 23:08:53 +0000 (00:08 +0100)]
conf.c: use g_mkdir for WIN32 compatibility

This patch is a follow-up to release-0.19-59-g3aea924.

12 years agoscreen_keydef: save lw->start when switching view modes
Jonathan Neuschäfer [Wed, 28 Dec 2011 22:14:27 +0000 (23:14 +0100)]
screen_keydef: save lw->start when switching view modes

12 years agoscreen_keydef: split out code to switch views
Jonathan Neuschäfer [Wed, 28 Dec 2011 22:04:36 +0000 (23:04 +0100)]
screen_keydef: split out code to switch views

12 years agoscreen_keydef: better distinction of adding and replacing keys
Jonathan Neuschäfer [Sat, 24 Dec 2011 17:28:06 +0000 (18:28 +0100)]
screen_keydef: better distinction of adding and replacing keys

12 years agoscreen_keydef: don't assign a key twice to one command
Jonathan Neuschäfer [Sat, 24 Dec 2011 17:28:06 +0000 (18:28 +0100)]
screen_keydef: don't assign a key twice to one command

12 years agoscreen_keydef: show command descriptions
Jonathan Neuschäfer [Sat, 24 Dec 2011 17:28:06 +0000 (18:28 +0100)]
screen_keydef: show command descriptions

12 years agoscreen_keydef: rework the list length / item position logic
Jonathan Neuschäfer [Sat, 24 Dec 2011 17:28:05 +0000 (18:28 +0100)]
screen_keydef: rework the list length / item position logic

12 years agoscreen_keydef: clean up keydef_cmd return values
Jonathan Neuschäfer [Sat, 24 Dec 2011 17:28:05 +0000 (18:28 +0100)]
screen_keydef: clean up keydef_cmd return values

12 years agoscreen_keydef: remove LIST_ITEM_{SAVE,APPLY}_LABEL
Jonathan Neuschäfer [Sat, 24 Dec 2011 17:28:04 +0000 (18:28 +0100)]
screen_keydef: remove LIST_ITEM_{SAVE,APPLY}_LABEL

These macros were only being used in one place.

12 years agoscreen_keydef: get rid of the BUFSIZE constant
Jonathan Neuschäfer [Sat, 24 Dec 2011 17:28:04 +0000 (18:28 +0100)]
screen_keydef: get rid of the BUFSIZE constant

It was only used in one function. Use sizeof(buf) instead.

12 years agoscreen_keydef: document delete_key
Jonathan Neuschäfer [Sat, 24 Dec 2011 17:28:04 +0000 (18:28 +0100)]
screen_keydef: document delete_key

12 years agooptions: get_key_names: use bool
Jonathan Neuschäfer [Thu, 22 Dec 2011 21:13:04 +0000 (22:13 +0100)]
options: get_key_names: use bool

(And true/false in calls to it)

12 years agocommand.c: set_key_flags: return void
Jonathan Neuschäfer [Thu, 22 Dec 2011 21:07:02 +0000 (22:07 +0100)]
command.c: set_key_flags: return void

The return value was unused

12 years agoconfig.sample: add the "timeout" option
Jonathan Neuschäfer [Thu, 22 Dec 2011 21:39:57 +0000 (22:39 +0100)]
config.sample: add the "timeout" option

12 years agoncmpc.1: the default connection timeout is 5 seconds
Jonathan Neuschäfer [Thu, 22 Dec 2011 13:45:41 +0000 (14:45 +0100)]
ncmpc.1: the default connection timeout is 5 seconds

12 years agochange CMD_LYRICS_EDIT to CMD_EDIT
Jonathan Neuschäfer [Wed, 21 Dec 2011 18:55:10 +0000 (19:55 +0100)]
change CMD_LYRICS_EDIT to CMD_EDIT

This allows other screens to implement edit funtionality

12 years agoscreen_lyrics: optionally ask before starting an editor
Jonathan Neuschäfer [Sat, 17 Dec 2011 20:58:01 +0000 (21:58 +0100)]
screen_lyrics: optionally ask before starting an editor

12 years agouse screen_get_yesno
Jonathan Neuschäfer [Sat, 17 Dec 2011 21:54:46 +0000 (22:54 +0100)]
use screen_get_yesno

12 years agoscreen_utils: add function screen_get_yesno
Jonathan Neuschäfer [Sat, 17 Dec 2011 21:24:42 +0000 (22:24 +0100)]
screen_utils: add function screen_get_yesno

12 years agooptions: don't use "editor" as the default editor
Jonathan Neuschäfer [Wed, 21 Dec 2011 19:14:04 +0000 (20:14 +0100)]
options: don't use "editor" as the default editor

Just leave it unconfigured for as long as the editor fallback
machanism isn't yet implemented.

12 years agooptions: don't leak options.text_editor
Jonathan Neuschäfer [Sat, 17 Dec 2011 16:08:36 +0000 (17:08 +0100)]
options: don't leak options.text_editor

12 years agoNEWS: mention the lyrics_screen edit functionality
Jonathan Neuschäfer [Thu, 22 Dec 2011 11:54:39 +0000 (12:54 +0100)]
NEWS: mention the lyrics_screen edit functionality

12 years agodoc: remove obsolete --exit documentation
Jon Sailor [Thu, 22 Dec 2011 11:14:42 +0000 (12:14 +0100)]
doc: remove obsolete --exit documentation

12 years agooptions: configurable timeout for MPD connections
Jon Sailor [Thu, 22 Dec 2011 11:08:00 +0000 (12:08 +0100)]
options: configurable timeout for MPD connections

12 years agocommand.c: comment an #endif
Jonathan Neuschäfer [Wed, 21 Dec 2011 20:40:53 +0000 (21:40 +0100)]
command.c: comment an #endif

12 years agocommand.c: change find_key_command for MAX_COMMAND_KEYS != 3
Jonathan Neuschäfer [Wed, 21 Dec 2011 20:40:52 +0000 (21:40 +0100)]
command.c: change find_key_command for MAX_COMMAND_KEYS != 3

The performance penalty shouldn't be too high (loop unrolling could
help here).

12 years agocommand.c: turn while loops into for loops
Jonathan Neuschäfer [Wed, 21 Dec 2011 20:40:52 +0000 (21:40 +0100)]
command.c: turn while loops into for loops

12 years agocommand.c: rework loop logic in find_key_command
Jonathan Neuschäfer [Wed, 21 Dec 2011 20:40:52 +0000 (21:40 +0100)]
command.c: rework loop logic in find_key_command

12 years agoscreen_interface: document the cmd callback
Jonathan Neuschäfer [Wed, 21 Dec 2011 20:40:51 +0000 (21:40 +0100)]
screen_interface: document the cmd callback

12 years agocommand: make Ctrl-X/Alt-X/F1 etc. translatable
Jonathan Neuschäfer [Wed, 21 Dec 2011 20:40:51 +0000 (21:40 +0100)]
command: make Ctrl-X/Alt-X/F1 etc. translatable

12 years agoscreen_lyrics: new key to edit lyrics
Jonathan Neuschäfer [Sun, 11 Dec 2011 11:50:02 +0000 (12:50 +0100)]
screen_lyrics: new key to edit lyrics

Thanks for the idea and an initial patch go to Jitka Novotna <jitka@ucw.cz>

12 years agoscreen_lyrics: put code for reloading in a function
Jonathan Neuschäfer [Sat, 17 Dec 2011 14:54:47 +0000 (15:54 +0100)]
screen_lyrics: put code for reloading in a function

12 years agoAdd option "text-editor"
Jonathan Neuschäfer [Sat, 17 Dec 2011 16:08:36 +0000 (17:08 +0100)]
Add option "text-editor"

The lyrics screen is going to spawn a text editor to edit lyrics.
Put the infrastructure in place to make it configurable.

12 years agoMerge remote branches 'jn/cosmetics', 'jn/doxygen' and 'jn/renames'
Max Kellermann [Fri, 2 Dec 2011 11:10:46 +0000 (12:10 +0100)]
Merge remote branches 'jn/cosmetics', 'jn/doxygen' and 'jn/renames'

12 years agoscreen_song: make Path a proper label
Jonathan Neuschäfer [Tue, 22 Nov 2011 22:33:01 +0000 (23:33 +0100)]
screen_song: make Path a proper label

12 years agocommand.c: use for instead of while in check_key_bindings
Jonathan Neuschäfer [Tue, 22 Nov 2011 22:09:35 +0000 (23:09 +0100)]
command.c: use for instead of while in check_key_bindings

12 years agocommand.c: put curly braces around a single large statement
Jonathan Neuschäfer [Tue, 22 Nov 2011 22:03:05 +0000 (23:03 +0100)]
command.c: put curly braces around a single large statement

12 years agomain: don't show "connecting to (null)"
Jonathan Neuschäfer [Sat, 19 Nov 2011 23:52:15 +0000 (00:52 +0100)]
main: don't show "connecting to (null)"

This patch is a follow-up to commit b774eac8d9 ("main: don't show
(null) as the server name").

12 years agoscreen_song: don't show unknown kbit rates
Jonathan Neuschäfer [Sat, 19 Nov 2011 01:33:43 +0000 (02:33 +0100)]
screen_song: don't show unknown kbit rates

(calling mpd_status_get_kbit_rate twice in a row shouldn't impact
performance, it's declared as "pure")

12 years agorename screen_message to screen_status
Jonathan Neuschäfer [Tue, 22 Nov 2011 21:54:55 +0000 (22:54 +0100)]
rename screen_message to screen_status

Its two functions are screen_status_message and screen_status_printf
so this just seems logical to me.

12 years agodoxygen: don't sort functions in the file documentation
Jonathan Neuschäfer [Thu, 3 Nov 2011 23:02:51 +0000 (00:02 +0100)]
doxygen: don't sort functions in the file documentation

12 years agoadd doc/doxygen.conf and doc/api/ to .gitignore
Jonathan Neuschäfer [Fri, 14 Oct 2011 20:24:39 +0000 (22:24 +0200)]
add doc/doxygen.conf and doc/api/ to .gitignore

12 years agomention doxygen support in NEWS
Jonathan Neuschäfer [Fri, 4 Nov 2011 20:54:08 +0000 (21:54 +0100)]
mention doxygen support in NEWS

12 years agoadd doxygen support
Jonathan Neuschäfer [Fri, 14 Oct 2011 20:21:22 +0000 (22:21 +0200)]
add doxygen support

12 years agouse mpdclient_finish_command at the obvious places
Jonathan Neuschäfer [Thu, 3 Nov 2011 23:20:45 +0000 (00:20 +0100)]
use mpdclient_finish_command at the obvious places

12 years agompdclient: export mpdclient_finish_command
Jonathan Neuschäfer [Mon, 31 Oct 2011 00:23:15 +0000 (01:23 +0100)]
mpdclient: export mpdclient_finish_command

(and include mpdclient.h in mpdclient.c, so it can be used there)

12 years agooptions.c: rewrite two #ifndefs as one #if
Jonathan Neuschäfer [Mon, 14 Nov 2011 05:49:52 +0000 (06:49 +0100)]
options.c: rewrite two #ifndefs as one #if

12 years agoconfigure.ac: (default: enabled) -> [default=yes]
Jonathan Neuschäfer [Sat, 5 Nov 2011 22:49:40 +0000 (23:49 +0100)]
configure.ac: (default: enabled) -> [default=yes]

12 years agoapply whitespace cosmetics to the license comments
Jonathan Neuschäfer [Sat, 5 Nov 2011 10:10:25 +0000 (11:10 +0100)]
apply whitespace cosmetics to the license comments

12 years agoncmpc.h: document sigstop
Jonathan Neuschäfer [Thu, 3 Nov 2011 22:47:28 +0000 (23:47 +0100)]
ncmpc.h: document sigstop

12 years agoMakefile.am: Add @CURSES_LIB@ to link the test program
Avuton Olrich [Sat, 12 Nov 2011 14:29:33 +0000 (06:29 -0800)]
Makefile.am: Add @CURSES_LIB@ to link the test program

12 years agompdclient: define MPD_IDLE_ALL
Jonathan Neuschäfer [Fri, 4 Nov 2011 00:01:37 +0000 (01:01 +0100)]
mpdclient: define MPD_IDLE_ALL

12 years agoconfigure.ac: Remove duplicate output screen merge error.
Avuton Olrich [Fri, 4 Nov 2011 01:09:01 +0000 (18:09 -0700)]
configure.ac: Remove duplicate output screen merge error.

12 years agoconfigure.ac: Change to the more correct variable for wide support.
Avuton Olrich [Fri, 4 Nov 2011 01:05:09 +0000 (18:05 -0700)]
configure.ac: Change to the more correct variable for wide support.

12 years agoscreen_list: use G_N_ELEMENTS()
Jonathan Neuschäfer [Tue, 11 Oct 2011 21:14:40 +0000 (23:14 +0200)]
screen_list: use G_N_ELEMENTS()

12 years agoMerge remote branches 'avuton/master' and 'jn/dev'
Max Kellermann [Thu, 3 Nov 2011 16:42:07 +0000 (17:42 +0100)]
Merge remote branches 'avuton/master' and 'jn/dev'

12 years agom4: Add robust curses detection and support
Avuton Olrich [Thu, 3 Nov 2011 09:20:51 +0000 (02:20 -0700)]
m4: Add robust curses detection and support

This commit adds the ax_with_curses.m4 macro from the autoconf-archive
project. This also adds support for more plain curses, proper color detection
and compartmentalizes the curses autoconf stuff.

12 years agoscreen.c: Add pdcurses mouse support
Avuton Olrich [Sun, 30 Oct 2011 04:30:12 +0000 (21:30 -0700)]
screen.c: Add pdcurses mouse support

12 years agoconfigure.ac: Add proper CFLAG checking and appending
Avuton Olrich [Thu, 3 Nov 2011 02:42:04 +0000 (19:42 -0700)]
configure.ac: Add proper CFLAG checking and appending

Add proper CFLAG checking and appending using standard autoconf macros. This
fixes the warnings generated during autoconf.

12 years agowreadln.c: Win32 doesn't support polling, so disable this for now
Avuton Olrich [Sun, 30 Oct 2011 02:36:39 +0000 (19:36 -0700)]
wreadln.c: Win32 doesn't support polling, so disable this for now

Win32 doesn't support polling, disabling it for now. Not exactly sure
what this breaks, but win32 appears to run fine with this code disabled.

12 years agomain.c: Don't try to compile signal support on win32
Avuton Olrich [Sun, 30 Oct 2011 02:34:57 +0000 (19:34 -0700)]
main.c: Don't try to compile signal support on win32

12 years agoconf.c: When on win32, mkdir() doesn't use permissions
Avuton Olrich [Sun, 30 Oct 2011 01:23:30 +0000 (18:23 -0700)]
conf.c: When on win32, mkdir() doesn't use permissions

12 years agoscreen.c: If compiling with PDCURSES, use resize_term() to resize
Avuton Olrich [Sun, 30 Oct 2011 01:21:44 +0000 (18:21 -0700)]
screen.c: If compiling with PDCURSES, use resize_term() to resize

12 years agogidle.c: Removed unused header
Avuton Olrich [Sun, 30 Oct 2011 01:12:12 +0000 (18:12 -0700)]
gidle.c: Removed unused header

12 years agoconfigure.ac: Link to winsock when compiling on win32
Avuton Olrich [Thu, 3 Nov 2011 02:13:21 +0000 (19:13 -0700)]
configure.ac: Link to winsock when compiling on win32

12 years agoconfigure.ac: Replace AM_CONFIG_HEADER deprecated macro
Avuton Olrich [Sat, 29 Oct 2011 13:18:00 +0000 (06:18 -0700)]
configure.ac: Replace AM_CONFIG_HEADER deprecated macro

12 years agoconfigure.ac: Remove disabled browse screen options
Avuton Olrich [Thu, 3 Nov 2011 02:08:47 +0000 (19:08 -0700)]
configure.ac: Remove disabled browse screen options

12 years agoconfigure.ac: Add AC_MSG_RESULT for outputs screen
Avuton Olrich [Sat, 29 Oct 2011 12:53:45 +0000 (05:53 -0700)]
configure.ac: Add AC_MSG_RESULT for outputs screen

12 years agoconfigure.ac: Amend -Werror using the cflag framework
Avuton Olrich [Sat, 29 Oct 2011 12:50:42 +0000 (05:50 -0700)]
configure.ac: Amend -Werror using the cflag framework

12 years agom4: Update nls.m4
Avuton Olrich [Wed, 26 Oct 2011 02:46:41 +0000 (19:46 -0700)]
m4: Update nls.m4

12 years agoconfigure.ac: AC_HELP_STRING depreciated, move to AS_HELP_STRING
Avuton Olrich [Thu, 3 Nov 2011 01:54:24 +0000 (18:54 -0700)]
configure.ac: AC_HELP_STRING depreciated, move to AS_HELP_STRING

12 years agolist_window: scroll down exactly one page at PGDN
Jonathan Neuschäfer [Tue, 1 Nov 2011 21:40:13 +0000 (22:40 +0100)]
list_window: scroll down exactly one page at PGDN

12 years agomain: use mpdclient_is_connected in assert
Jonathan Neuschäfer [Sat, 29 Oct 2011 12:49:26 +0000 (14:49 +0200)]
main: use mpdclient_is_connected in assert

12 years agoscreen: restore newline character
Jonathan Neuschäfer [Sat, 29 Oct 2011 13:10:20 +0000 (15:10 +0200)]
screen: restore newline character

It was removed in commit 389a1ad8:
- fprintf(stderr, _("Error: Screen to small\n"));
+ fprintf(stderr, "%s", _("Error: Screen too small"));
exit(EXIT_FAILURE);

12 years agompdclient: handle mpd_send_add's return value
Jonathan Neuschäfer [Sat, 29 Oct 2011 13:19:02 +0000 (15:19 +0200)]
mpdclient: handle mpd_send_add's return value

12 years agoconfigure.ac: add missing AC_MSG_RESULT
Jonathan Neuschäfer [Thu, 27 Oct 2011 00:02:49 +0000 (02:02 +0200)]
configure.ac: add missing AC_MSG_RESULT

12 years agompdclient_connect: fix parenthesis style
Jonathan Neuschäfer [Mon, 24 Oct 2011 13:04:00 +0000 (15:04 +0200)]
mpdclient_connect: fix parenthesis style

12 years agoscreen_outputs.c: fix indentation
Jonathan Neuschäfer [Sun, 23 Oct 2011 23:04:13 +0000 (01:04 +0200)]
screen_outputs.c: fix indentation

12 years agotitle_bar.c: include config.h directly
Jonathan Neuschäfer [Tue, 11 Oct 2011 22:18:57 +0000 (00:18 +0200)]
title_bar.c: include config.h directly

12 years agooptions: remove double-semicolon
Jonathan Neuschäfer [Sat, 3 Sep 2011 12:42:09 +0000 (14:42 +0200)]
options: remove double-semicolon