Code

screen_*: eliminate redundant wrefresh() calls
[ncmpc.git] / src / screen_file.c
index ed3d26a2610bba51ed1364fab640da84792566e1..5399c85d3bfe5c7fed1aea468321e2b8a23e813e 100644 (file)
@@ -1,33 +1,36 @@
 /* ncmpc (Ncurses MPD Client)
- * (c) 2004-2009 The Music Player Daemon Project
+ * (c) 2004-2017 The Music Player Daemon Project
  * Project homepage: http://musicpd.org
-
+ *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation; either version 2 of the License, or
  * (at your option) any later version.
-
+ *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
-
+ *
  * You should have received a copy of the GNU General Public License along
  * with this program; if not, write to the Free Software Foundation, Inc.,
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
-*/
+ */
 
+#include "screen_file.h"
+#include "screen_browser.h"
+#include "screen_interface.h"
+#include "screen_status.h"
+#include "screen_queue.h"
+#include "screen.h"
 #include "config.h"
 #include "i18n.h"
-#include "options.h"
 #include "charset.h"
 #include "mpdclient.h"
 #include "filelist.h"
-#include "command.h"
-#include "screen.h"
 #include "screen_utils.h"
-#include "screen_browser.h"
-#include "screen_play.h"
+#include "screen_client.h"
+#include "options.h"
 
 #include <mpd/client.h>
 
@@ -40,71 +43,50 @@ static struct screen_browser browser;
 static char *current_path;
 
 static void
-browse_paint(void);
-
-static void
-file_repaint(void)
+screen_file_load_list(struct mpdclient *c, struct filelist *filelist)
 {
-       browse_paint();
-       wrefresh(browser.lw->w);
-}
+       struct mpd_connection *connection;
 
-static void
-file_repaint_if_active(void)
-{
-       if (screen_is_visible(&screen_browse))
-               file_repaint();
-}
+       connection = mpdclient_get_connection(c);
+       if (connection == NULL)
+               return;
 
-static void
-file_reload(struct mpdclient *c)
-{
-       if (browser.filelist != NULL)
-               filelist_free(browser.filelist);
+       mpd_send_list_meta(connection, current_path);
+       filelist_recv(filelist, connection);
 
-       browser.filelist = mpdclient_filelist_get(c, current_path);
+       if (mpdclient_finish_command(c))
+               filelist_sort_dir_play(filelist, compare_filelist_entry_path);
 }
 
-/* the db has changed -> update the filelist */
 static void
-file_changed_callback(struct mpdclient *c, G_GNUC_UNUSED int event,
-                     G_GNUC_UNUSED gpointer data)
+screen_file_reload(struct mpdclient *c)
 {
-       file_reload(c);
-
-#ifndef NCMPC_MINI
-       sync_highlights(c, browser.filelist);
-#endif
-       list_window_check_selected(browser.lw, filelist_length(browser.filelist));
+       if (browser.filelist != NULL)
+               filelist_free(browser.filelist);
 
-       file_repaint_if_active();
-}
+       browser.filelist = filelist_new();
+       if (*current_path != 0)
+               /* add a dummy entry for ./.. */
+               filelist_append(browser.filelist, NULL);
 
-#ifndef NCMPC_MINI
-/* the playlist has been updated -> fix highlights */
-static void
-playlist_changed_callback(struct mpdclient *c, int event, gpointer data)
-{
-       browser_playlist_changed(&browser, c, event, data);
+       screen_file_load_list(c, browser.filelist);
 
-       file_repaint_if_active();
+       list_window_set_length(browser.lw,
+                              filelist_length(browser.filelist));
 }
-#endif
 
 /**
  * Change to the specified absolute directory.
  */
 static bool
-file_change_directory(struct mpdclient *c, const char *new_path)
+change_directory(struct mpdclient *c, const char *new_path)
 {
        g_free(current_path);
        current_path = g_strdup(new_path);
 
-       file_reload(c);
+       screen_file_reload(c);
 
-#ifndef NCMPC_MINI
-       sync_highlights(c, browser.filelist);
-#endif
+       screen_browser_sync_highlights(browser.filelist, &c->playlist);
 
        list_window_reset(browser.lw);
 
@@ -115,32 +97,27 @@ file_change_directory(struct mpdclient *c, const char *new_path)
  * Change to the parent directory of the current directory.
  */
 static bool
-file_change_to_parent(struct mpdclient *c)
+change_to_parent(struct mpdclient *c)
 {
        char *parent = g_path_get_dirname(current_path);
-       char *old_path;
-       int idx;
-       bool success;
-
        if (strcmp(parent, ".") == 0)
                parent[0] = '\0';
 
-       old_path = current_path;
+       char *old_path = current_path;
        current_path = NULL;
 
-       success = file_change_directory(c, parent);
+       bool success = change_directory(c, parent);
        g_free(parent);
 
-       idx = success
+       int idx = success
                ? filelist_find_directory(browser.filelist, old_path)
                : -1;
        g_free(old_path);
 
        if (success && idx >= 0) {
                /* set the cursor on the previous working directory */
-               list_window_set_selected(browser.lw, idx);
-               list_window_center(browser.lw,
-                                  filelist_length(browser.filelist), idx);
+               list_window_set_cursor(browser.lw, idx);
+               list_window_center(browser.lw, idx);
        }
 
        return success;
@@ -151,44 +128,42 @@ file_change_to_parent(struct mpdclient *c)
  * object.
  */
 static bool
-file_change_to_entry(struct mpdclient *c, const struct filelist_entry *entry)
+change_to_entry(struct mpdclient *c, const struct filelist_entry *entry)
 {
        assert(entry != NULL);
 
        if (entry->entity == NULL)
-               return file_change_to_parent(c);
+               return change_to_parent(c);
        else if (mpd_entity_get_type(entry->entity) == MPD_ENTITY_TYPE_DIRECTORY)
-               return file_change_directory(c, mpd_directory_get_path(mpd_entity_get_directory(entry->entity)));
+               return change_directory(c, mpd_directory_get_path(mpd_entity_get_directory(entry->entity)));
        else
                return false;
 }
 
 static bool
-file_handle_enter(struct mpdclient *c)
+screen_file_handle_enter(struct mpdclient *c)
 {
        const struct filelist_entry *entry = browser_get_selected_entry(&browser);
 
        if (entry == NULL)
                return false;
 
-       return file_change_to_entry(c, entry);
+       return change_to_entry(c, entry);
 }
 
-static int
+static void
 handle_save(struct mpdclient *c)
 {
-       struct filelist_entry *entry;
+       struct list_window_range range;
        const char *defaultname = NULL;
-       char *defaultname_utf8 = NULL;
-       int ret;
-       unsigned selected;
 
-       if (browser.lw->selected >= filelist_length(browser.filelist))
-               return -1;
+       list_window_get_range(browser.lw, &range);
+       if (range.start == range.end)
+               return;
 
-       for(selected = browser.lw->selected_start; selected <= browser.lw->selected_end; ++selected)
-       {
-               entry = filelist_get(browser.filelist, selected);
+       for (unsigned i = range.start; i < range.end; ++i) {
+               struct filelist_entry *entry =
+                       filelist_get(browser.filelist, i);
                if( entry && entry->entity ) {
                        struct mpd_entity *entity = entry->entity;
                        if (mpd_entity_get_type(entity) == MPD_ENTITY_TYPE_PLAYLIST) {
@@ -199,34 +174,30 @@ handle_save(struct mpdclient *c)
                }
        }
 
+       char *defaultname_utf8 = NULL;
        if(defaultname)
                defaultname_utf8 = utf8_to_locale(defaultname);
-       ret = playlist_save(c, NULL, defaultname_utf8);
+       playlist_save(c, NULL, defaultname_utf8);
        g_free(defaultname_utf8);
-
-       return ret;
 }
 
-static int
+static void
 handle_delete(struct mpdclient *c)
 {
-       struct filelist_entry *entry;
-       struct mpd_entity *entity;
-       const struct mpd_playlist *playlist;
-       char *str, *buf;
-       int key;
-       unsigned selected;
-
-       for(selected = browser.lw->selected_start; selected <= browser.lw->selected_end; ++selected)
-       {
-               if (selected >= filelist_length(browser.filelist))
-                       return -1;
-
-               entry = filelist_get(browser.filelist, selected);
+       struct mpd_connection *connection = mpdclient_get_connection(c);
+
+       if (connection == NULL)
+               return;
+
+       struct list_window_range range;
+       list_window_get_range(browser.lw, &range);
+       for (unsigned i = range.start; i < range.end; ++i) {
+               struct filelist_entry *entry =
+                       filelist_get(browser.filelist, i);
                if( entry==NULL || entry->entity==NULL )
                        continue;
 
-               entity = entry->entity;
+               struct mpd_entity *entity = entry->entity;
 
                if (mpd_entity_get_type(entity) != MPD_ENTITY_TYPE_PLAYLIST) {
                        /* translators: the "delete" command is only possible
@@ -237,45 +208,49 @@ handle_delete(struct mpdclient *c)
                        continue;
                }
 
-               playlist = mpd_entity_get_playlist(entity);
-               str = utf8_to_locale(g_basename(mpd_playlist_get_path(playlist)));
-               buf = g_strdup_printf(_("Delete playlist %s [%s/%s] ? "), str, YES, NO);
+               const struct mpd_playlist *playlist = mpd_entity_get_playlist(entity);
+               char *str = utf8_to_locale(g_basename(mpd_playlist_get_path(playlist)));
+               char *buf = g_strdup_printf(_("Delete playlist %s [%s/%s] ? "), str, YES, NO);
                g_free(str);
-               key = tolower(screen_getch(screen.status_window.w, buf));
+               bool delete = screen_get_yesno(buf, false);
                g_free(buf);
-               if( key != YES[0] ) {
+
+               if (!delete) {
                        /* translators: a dialog was aborted by the user */
                        screen_status_printf(_("Aborted"));
-                       return 0;
+                       return;
                }
 
-               if (mpdclient_cmd_delete_playlist(c, mpd_playlist_get_path(playlist)))
-                       continue;
+               if (!mpd_run_rm(connection, mpd_playlist_get_path(playlist))) {
+                       mpdclient_handle_error(c);
+                       break;
+               }
+
+               c->events |= MPD_IDLE_STORED_PLAYLIST;
 
                /* translators: MPD deleted the playlist, as requested by the
                   user */
                screen_status_printf(_("Playlist deleted"));
        }
-       return 0;
 }
 
 static void
-browse_init(WINDOW *w, int cols, int rows)
+screen_file_init(WINDOW *w, int cols, int rows)
 {
        current_path = g_strdup("");
 
        browser.lw = list_window_init(w, cols, rows);
+       browser.song_format = options.list_format;
 }
 
 static void
-browse_resize(int cols, int rows)
+screen_file_resize(int cols, int rows)
 {
-       browser.lw->cols = cols;
-       browser.lw->rows = rows;
+       list_window_resize(browser.lw, cols, rows);
 }
 
 static void
-browse_exit(void)
+screen_file_exit(void)
 {
        if (browser.filelist)
                filelist_free(browser.filelist);
@@ -285,22 +260,16 @@ browse_exit(void)
 }
 
 static void
-browse_open(G_GNUC_UNUSED struct mpdclient *c)
+screen_file_open(struct mpdclient *c)
 {
-       if (browser.filelist == NULL) {
-               browser.filelist = mpdclient_filelist_get(c, "");
-#ifndef NCMPC_MINI
-               mpdclient_install_playlist_callback(c, playlist_changed_callback);
-#endif
-               mpdclient_install_browse_callback(c, file_changed_callback);
-       }
+       screen_file_reload(c);
+       screen_browser_sync_highlights(browser.filelist, &c->playlist);
 }
 
 static const char *
-browse_title(char *str, size_t size)
+screen_file_get_title(char *str, size_t size)
 {
        const char *path = NULL, *prev = NULL, *slash = current_path;
-       char *path_locale;
 
        /* determine the last 2 parts of the path */
        while ((slash = strchr(slash, '/')) != NULL) {
@@ -312,7 +281,7 @@ browse_title(char *str, size_t size)
                /* fall back to full path */
                path = current_path;
 
-       path_locale = utf8_to_locale(path);
+       char *path_locale = utf8_to_locale(path);
        g_snprintf(str, size, "%s: %s",
                   /* translators: caption of the browser screen */
                   _("Browse"), path_locale);
@@ -321,30 +290,48 @@ browse_title(char *str, size_t size)
 }
 
 static void
-browse_paint(void)
+screen_file_paint(void)
 {
-       list_window_paint(browser.lw, browser_lw_callback, browser.filelist);
+       screen_browser_paint(&browser);
+}
+
+static void
+screen_file_update(struct mpdclient *c)
+{
+       if (c->events & (MPD_IDLE_DATABASE | MPD_IDLE_STORED_PLAYLIST)) {
+               /* the db has changed -> update the filelist */
+               screen_file_reload(c);
+       }
+
+       if (c->events & (MPD_IDLE_DATABASE | MPD_IDLE_STORED_PLAYLIST
+#ifndef NCMPC_MINI
+                        | MPD_IDLE_QUEUE
+#endif
+                        )) {
+               screen_browser_sync_highlights(browser.filelist, &c->playlist);
+               screen_file_paint();
+       }
 }
 
 static bool
-browse_cmd(struct mpdclient *c, command_t cmd)
+screen_file_cmd(struct mpdclient *c, command_t cmd)
 {
        switch(cmd) {
        case CMD_PLAY:
-               if (file_handle_enter(c)) {
-                       file_repaint();
+               if (screen_file_handle_enter(c)) {
+                       screen_file_paint();
                        return true;
                }
 
                break;
 
        case CMD_GO_ROOT_DIRECTORY:
-               file_change_directory(c, "");
-               file_repaint();
+               change_directory(c, "");
+               screen_file_paint();
                return true;
        case CMD_GO_PARENT_DIRECTORY:
-               file_change_to_parent(c);
-               file_repaint();
+               change_to_parent(c);
+               screen_file_paint();
                return true;
 
        case CMD_LOCATE:
@@ -353,63 +340,55 @@ browse_cmd(struct mpdclient *c, command_t cmd)
                   segmentation fault in the current implementation */
                return false;
 
+       case CMD_SCREEN_UPDATE:
+               screen_file_reload(c);
+               screen_browser_sync_highlights(browser.filelist, &c->playlist);
+               screen_file_paint();
+               return false;
+
+       default:
+               break;
+       }
+
+       if (browser_cmd(&browser, c, cmd)) {
+               if (screen_is_visible(&screen_browse))
+                       screen_file_paint();
+               return true;
+       }
+
+       if (!mpdclient_is_connected(c))
+               return false;
+
+       switch(cmd) {
        case CMD_DELETE:
                handle_delete(c);
-               file_repaint();
+               screen_file_paint();
                break;
+
        case CMD_SAVE_PLAYLIST:
                handle_save(c);
                break;
-       case CMD_SCREEN_UPDATE:
-               file_reload(c);
-#ifndef NCMPC_MINI
-               sync_highlights(c, browser.filelist);
-#endif
-               list_window_check_selected(browser.lw,
-                                          filelist_length(browser.filelist));
-               file_repaint();
-               return false;
 
        case CMD_DB_UPDATE:
-               if (c->status == NULL)
-                       return true;
-
-               if (mpd_status_get_update_id(c->status) == 0) {
-                       if (mpdclient_cmd_db_update(c, current_path) == 0) {
-                               if (strcmp(current_path, "")) {
-                                       char *path_locale =
-                                               utf8_to_locale(current_path);
-                                       screen_status_printf(_("Database update of %s started"),
-                                                            path_locale);
-                                       g_free(path_locale);
-                               } else
-                                       screen_status_printf(_("Database update started"));
-                       }
-               } else
-                       screen_status_printf(_("Database update running..."));
+               screen_database_update(c, current_path);
                return true;
 
        default:
                break;
        }
 
-       if (browser_cmd(&browser, c, cmd)) {
-               if (screen_is_visible(&screen_browse))
-                       file_repaint();
-               return true;
-       }
-
        return false;
 }
 
 const struct screen_functions screen_browse = {
-       .init = browse_init,
-       .exit = browse_exit,
-       .open = browse_open,
-       .resize = browse_resize,
-       .paint = browse_paint,
-       .cmd = browse_cmd,
-       .get_title = browse_title,
+       .init = screen_file_init,
+       .exit = screen_file_exit,
+       .open = screen_file_open,
+       .resize = screen_file_resize,
+       .paint = screen_file_paint,
+       .update = screen_file_update,
+       .cmd = screen_file_cmd,
+       .get_title = screen_file_get_title,
 };
 
 bool
@@ -417,8 +396,6 @@ screen_file_goto_song(struct mpdclient *c, const struct mpd_song *song)
 {
        const char *uri, *slash, *parent;
        char *allocated = NULL;
-       bool ret;
-       int i;
 
        assert(song != NULL);
 
@@ -436,18 +413,18 @@ screen_file_goto_song(struct mpdclient *c, const struct mpd_song *song)
        else
                parent = "";
 
-       ret = file_change_directory(c, parent);
+       bool ret = change_directory(c, parent);
        g_free(allocated);
        if (!ret)
                return false;
 
        /* select the specified song */
 
-       i = filelist_find_song(browser.filelist, song);
+       int i = filelist_find_song(browser.filelist, song);
        if (i < 0)
                i = 0;
 
-       list_window_set_selected(browser.lw, i);
+       list_window_set_cursor(browser.lw, i);
 
        /* finally, switch to the file screen */
        screen_switch(&screen_browse, c);