From: Ævar Arnfjörð Bjarmason Date: Sun, 6 Nov 2011 12:06:22 +0000 (+0100) Subject: apply: get rid of useless x < 0 comparison on a size_t type X-Git-Tag: v1.7.7.5~1^2~1 X-Git-Url: https://git.tokkee.org/?p=git.git;a=commitdiff_plain;h=473f4c96e315478185c4a07d6e7fb65801ee40b9 apply: get rid of useless x < 0 comparison on a size_t type According to the C standard size_t is always unsigned, therefore the comparison "n1 < 0 || n2 < 0" when n1 and n2 are size_t will always be false. This was raised by clang 2.9 which throws this warning when compiling apply.c: builtin/apply.c:253:9: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare] if (n1 < 0 || n2 < 0) ~~ ^ ~ builtin/apply.c:253:19: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare] if (n1 < 0 || n2 < 0) ~~ ^ ~ This check was originally added in v1.6.5-rc0~53^2 by Giuseppe Bilotta while adding an option to git-apply to ignore whitespace differences. Signed-off-by: Ævar Arnfjörð Bjarmason Signed-off-by: Junio C Hamano --- diff --git a/builtin/apply.c b/builtin/apply.c index f2edc5281..d600ac63a 100644 --- a/builtin/apply.c +++ b/builtin/apply.c @@ -250,9 +250,6 @@ static int fuzzy_matchlines(const char *s1, size_t n1, const char *last2 = s2 + n2 - 1; int result = 0; - if (n1 < 0 || n2 < 0) - return 0; - /* ignore line endings */ while ((*last1 == '\r') || (*last1 == '\n')) last1--;