Code

sparse: Fix some "symbol not declared" warnings
authorRamsay Jones <ramsay@ramsay1.demon.co.uk>
Thu, 7 Apr 2011 18:49:33 +0000 (19:49 +0100)
committerJunio C Hamano <gitster@pobox.com>
Fri, 22 Apr 2011 17:04:27 +0000 (10:04 -0700)
commitc51477229ee4c7846d40a447860b5bf94aa1103d
tree4bfce447467267ad409f75e33f5cb5d3ec6689d3
parent0bcd9ae85d7e05e78a10a69a2ebe98dcde130937
sparse: Fix some "symbol not declared" warnings

In particular, sparse issues the "symbol 'a_symbol' was not declared.
Should it be static?" warnings for the following symbols:

    attr.c:468:12: 'git_etc_gitattributes'
    attr.c:476:5:  'git_attr_system'
    vcs-svn/svndump.c:282:6: 'svndump_read'
    vcs-svn/svndump.c:417:5: 'svndump_init'
    vcs-svn/svndump.c:432:6: 'svndump_deinit'
    vcs-svn/svndump.c:445:6: 'svndump_reset'

The symbols in attr.c only require file scope, so we add the static
modifier to their declaration.

The symbols in vcs-svn/svndump.c are external symbols, and they
already have extern declarations in the "svndump.h" header file,
so we simply include the header in svndump.c.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
attr.c
vcs-svn/svndump.c