Code

http-push: enable "proactive auth"
authorJeff King <peff@peff.net>
Wed, 14 Dec 2011 00:11:56 +0000 (19:11 -0500)
committerJunio C Hamano <gitster@pobox.com>
Wed, 14 Dec 2011 00:34:44 +0000 (16:34 -0800)
commita4ddbc33d7906f0e10c68c140a9a1003d9715a77
treed5326b24cdb37c93c57763f8079f7b0f59061091
parent0521710a8b9321751ca8768c3f7ea8895901e5c3
http-push: enable "proactive auth"

Before commit 986bbc08, git was proactive about asking for
http passwords. It assumed that if you had a username in
your URL, you would also want a password, and asked for it
before making any http requests.

However, this could interfere with the use of .netrc (see
986bbc08 for details). And it was also unnecessary, since
the http fetching code had learned to recognize an HTTP 401
and prompt the user then. Furthermore, the proactive prompt
could interfere with the usage of .netrc (see 986bbc08 for
details).

Unfortunately, the http push-over-DAV code never learned to
recognize HTTP 401, and so was broken by this change. This
patch does a quick fix of re-enabling the "proactive auth"
strategy only for http-push, leaving the dumb http fetch and
smart-http as-is.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
http-fetch.c
http-push.c
http.c
http.h
remote-curl.c
t/t5540-http-push.sh