Code

remote-curl: Fix warning after HTTP failure
authorShawn O. Pearce <spearce@spearce.org>
Tue, 4 Oct 2011 23:20:19 +0000 (16:20 -0700)
committerJunio C Hamano <gitster@pobox.com>
Wed, 5 Oct 2011 02:11:50 +0000 (19:11 -0700)
commit6cdf0223fe4a9ccae543fece8b5e78a626ccdf89
tree02358dc60d30c071f5a7132425fd2465bce0444f
parentec014eac0e9e6f30cbbca616090fa2ecf74797e7
remote-curl: Fix warning after HTTP failure

If the HTTP connection is broken in the middle of a fetch or clone
body, the client presented a useless error message due to part of
the upload-pack->remote-curl pkt-line protocol leaking out of the
helper as the helper's "fetch result":

  error: RPC failed; result=18, HTTP code = 200
  fatal: The remote end hung up unexpectedly
  fatal: early EOF
  fatal: unpack-objects failed
  warning: https unexpectedly said: '0000'

Instead when the HTTP RPC fails discard all remaining data from
upload-pack and report nothing to the transport helper. Errors
were already sent to stderr.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
remote-curl.c