From fc48363f939c50ddd5637881dc6ddae2299df04f Mon Sep 17 00:00:00 2001 From: mental Date: Sat, 29 Apr 2006 15:42:18 +0000 Subject: [PATCH] since the view and document are both managed by the collector, reffing the document from the view is totally unnecessary --- ChangeLog | 7 +++++++ src/ui/view/view.cpp | 4 +--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index d4d316430..a44b9d39c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2006-04-29 MenTaLguY + + * src/ui/view/view.cpp: + + Wait a minute -- UI::View::View and SPDocument are both managed + by the collector -- the view doesn't need to ref the document! + 2006-04-29 MenTaLguY * src/ui/view/view.cpp: add missing unref diff --git a/src/ui/view/view.cpp b/src/ui/view/view.cpp index 48c48c750..04158ddbd 100644 --- a/src/ui/view/view.cpp +++ b/src/ui/view/view.cpp @@ -97,7 +97,6 @@ void View::_close() { if (_doc) { _document_uri_set_connection.disconnect(); _document_resized_connection.disconnect(); - sp_document_unref(_doc); _doc = 0; } @@ -139,10 +138,9 @@ void View::setDocument(SPDocument *doc) { if (_doc) { _document_uri_set_connection.disconnect(); _document_resized_connection.disconnect(); - sp_document_unref (_doc); } - _doc = sp_document_ref (doc); + _doc = doc; _document_uri_set_connection = _doc->connectURISet(sigc::bind(sigc::ptr_fun(&_onDocumentURISet), this)); _document_resized_connection = -- 2.30.2