From f8263c5339fd70ee00b60c37b715c7e46b30a3bf Mon Sep 17 00:00:00 2001 From: Alexandre Julliard Date: Sun, 23 Jul 2006 19:51:04 +0200 Subject: [PATCH] show-branch: Fix another performance problem. When naming commits, stop walking the parent chain as soon as we find a commit that already has a name. The parent chain of that commit will be walked later on in any case (or may even have been walked already). This avoids O(n^2) behavior; on a tree where show-branch displays 6800 commits, the total run time drops from 77 seconds to 5 seconds. Signed-off-by: Alexandre Julliard Signed-off-by: Junio C Hamano --- builtin-show-branch.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/builtin-show-branch.c b/builtin-show-branch.c index 3d240ca43..82f75b72d 100644 --- a/builtin-show-branch.c +++ b/builtin-show-branch.c @@ -89,6 +89,8 @@ static int name_first_parent_chain(struct commit *c) name_parent(c, p); i++; } + else + break; c = p; } return i; -- 2.30.2