From f6b98e46bdf64454d7c6ab76d617237118799d7b Mon Sep 17 00:00:00 2001 From: Todd Zullinger Date: Sun, 8 Feb 2009 18:12:43 -0500 Subject: [PATCH] git-web--browse: Fix check for /bin/start The previous check in git-web--browse for /bin/start used test -n /bin/start, which was always true. This lead to "start" being tried first in the browser list. On systems with upstart installed, "start" exists and might be in the PATH, but it makes a poor choice for a web browser. Instead, test that /bin/start exists and is executable. Signed-off-by: Todd Zullinger Signed-off-by: Junio C Hamano --- git-web--browse.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-web--browse.sh b/git-web--browse.sh index 78d236b77..7ed0faddc 100755 --- a/git-web--browse.sh +++ b/git-web--browse.sh @@ -115,7 +115,7 @@ if test -z "$browser" ; then browser_candidates="open $browser_candidates" fi # /bin/start indicates MinGW - if test -n /bin/start; then + if test -x /bin/start; then browser_candidates="start $browser_candidates" fi -- 2.30.2