From e294030fe89efcdd92430b60cf9568ffbe7317a8 Mon Sep 17 00:00:00 2001 From: Matthieu Moy Date: Thu, 2 Sep 2010 13:57:34 +0200 Subject: [PATCH] setup_unpack_trees_porcelain: take the whole options struct as parameter This is a preparation patch to let setup_unpack_trees_porcelain set show_all_errors itself. Signed-off-by: Matthieu Moy Signed-off-by: Junio C Hamano --- builtin/checkout.c | 2 +- builtin/merge.c | 2 +- merge-recursive.c | 2 +- unpack-trees.c | 4 +++- unpack-trees.h | 3 ++- 5 files changed, 8 insertions(+), 5 deletions(-) diff --git a/builtin/checkout.c b/builtin/checkout.c index 00cd1645c..f6caac104 100644 --- a/builtin/checkout.c +++ b/builtin/checkout.c @@ -373,7 +373,7 @@ static int merge_working_tree(struct checkout_opts *opts, topts.src_index = &the_index; topts.dst_index = &the_index; - setup_unpack_trees_porcelain(topts.msgs, "checkout"); + setup_unpack_trees_porcelain(&topts, "checkout"); refresh_cache(REFRESH_QUIET); diff --git a/builtin/merge.c b/builtin/merge.c index 20a28b218..a25951475 100644 --- a/builtin/merge.c +++ b/builtin/merge.c @@ -705,7 +705,7 @@ int checkout_fast_forward(const unsigned char *head, const unsigned char *remote opts.merge = 1; opts.fn = twoway_merge; opts.show_all_errors = 1; - setup_unpack_trees_porcelain(opts.msgs, "merge"); + setup_unpack_trees_porcelain(&opts, "merge"); trees[nr_trees] = parse_tree_indirect(head); if (!trees[nr_trees++]) diff --git a/merge-recursive.c b/merge-recursive.c index 85f339ef7..084f54b88 100644 --- a/merge-recursive.c +++ b/merge-recursive.c @@ -185,7 +185,7 @@ static int git_merge_trees(int index_only, opts.fn = threeway_merge; opts.src_index = &the_index; opts.dst_index = &the_index; - setup_unpack_trees_porcelain(opts.msgs, "merge"); + setup_unpack_trees_porcelain(&opts, "merge"); init_tree_desc_from_tree(t+0, common); init_tree_desc_from_tree(t+1, head); diff --git a/unpack-trees.c b/unpack-trees.c index 7267ae7c6..8bf8ce880 100644 --- a/unpack-trees.c +++ b/unpack-trees.c @@ -50,8 +50,10 @@ const char *unpack_plumbing_errors[NB_UNPACK_TREES_ERROR_TYPES] = { ? ((o)->msgs[(type)]) \ : (unpack_plumbing_errors[(type)]) ) -void setup_unpack_trees_porcelain(const char **msgs, const char *cmd) +void setup_unpack_trees_porcelain(struct unpack_trees_options *opts, + const char *cmd) { + const char **msgs = opts->msgs; const char *msg; char *tmp; const char *cmd2 = strcmp(cmd, "checkout") ? cmd : "switch branches"; diff --git a/unpack-trees.h b/unpack-trees.h index d62bba9ba..fad680dce 100644 --- a/unpack-trees.h +++ b/unpack-trees.h @@ -26,7 +26,8 @@ enum unpack_trees_error_types { * Sets the list of user-friendly error messages to be used by the * command "cmd" (either merge or checkout) */ -void setup_unpack_trees_porcelain(const char **msgs, const char *cmd); +void setup_unpack_trees_porcelain(struct unpack_trees_options *opts, + const char *cmd); struct rejected_paths_list { char *path; -- 2.30.2