From e18a24371c517818211cbc6ce44157bbf191e351 Mon Sep 17 00:00:00 2001 From: Florian Forster Date: Thu, 27 Mar 2008 17:13:41 +0100 Subject: [PATCH] vmem plugin: Add the `Verbose' config option. All the statistics is just too much for every-day-use ;) --- src/vmem.c | 107 +++++++++++++++++++++++++++++++++++------------------ 1 file changed, 70 insertions(+), 37 deletions(-) diff --git a/src/vmem.c b/src/vmem.c index 3235cb68..e0f76e76 100644 --- a/src/vmem.c +++ b/src/vmem.c @@ -24,7 +24,13 @@ #include "plugin.h" #if KERNEL_LINUX -/* No global variables */ +static const char *config_keys[] = +{ + "Verbose" +}; +static int config_keys_num = STATIC_ARRAY_SIZE (config_keys); + +static int verbose_output = 0; /* #endif KERNEL_LINUX */ #else @@ -67,6 +73,25 @@ static void submit_one (const char *plugin_instance, const char *type, submit (plugin_instance, type, type_instance, &value, 1); } /* void submit_one */ +static int vmem_config (const char *key, const char *value) +{ + if (strcasecmp ("Verbose", key) == 0) + { + if ((strcasecmp ("true", value) == 0) + || (strcasecmp ("yes", value) == 0) + || (strcasecmp ("on", value) == 0)) + verbose_output = 1; + else + verbose_output = 0; + } + else + { + return (-1); + } + + return (0); +} /* int vmem_config */ + static int vmem_read (void) { #if KERNEL_LINUX @@ -131,41 +156,6 @@ static int vmem_read (void) submit_one (NULL, "vmpage_number", inst, value); } - /* - * Number of page allocations, refills, steals and scans. This is collected - * ``per zone'', i. e. for DMA, DMA32, normal and possibly highmem. - */ - else if (strncmp ("pgalloc_", key, strlen ("pgalloc_")) == 0) - { - char *inst = key + strlen ("pgalloc_"); - value_t value = { .counter = counter }; - submit_one (inst, "vmpage_action", "alloc", value); - } - else if (strncmp ("pgrefill_", key, strlen ("pgrefill_")) == 0) - { - char *inst = key + strlen ("pgrefill_"); - value_t value = { .counter = counter }; - submit_one (inst, "vmpage_action", "refill", value); - } - else if (strncmp ("pgsteal_", key, strlen ("pgsteal_")) == 0) - { - char *inst = key + strlen ("pgsteal_"); - value_t value = { .counter = counter }; - submit_one (inst, "vmpage_action", "steal", value); - } - else if (strncmp ("pgscan_kswapd_", key, strlen ("pgscan_kswapd_")) == 0) - { - char *inst = key + strlen ("pgscan_kswapd_"); - value_t value = { .counter = counter }; - submit_one (inst, "vmpage_action", "scan_kswapd", value); - } - else if (strncmp ("pgscan_direct_", key, strlen ("pgscan_direct_")) == 0) - { - char *inst = key + strlen ("pgscan_direct_"); - value_t value = { .counter = counter }; - submit_one (inst, "vmpage_action", "scan_direct", value); - } - /* * Page in and page outs. For memory and swap. */ @@ -204,6 +194,47 @@ static int vmem_read (void) pgfaultvalid |= 0x02; } + /* + * Skip the other statistics if verbose output is disabled. + */ + else if (verbose_output == 0) + continue; + + /* + * Number of page allocations, refills, steals and scans. This is collected + * ``per zone'', i. e. for DMA, DMA32, normal and possibly highmem. + */ + else if (strncmp ("pgalloc_", key, strlen ("pgalloc_")) == 0) + { + char *inst = key + strlen ("pgalloc_"); + value_t value = { .counter = counter }; + submit_one (inst, "vmpage_action", "alloc", value); + } + else if (strncmp ("pgrefill_", key, strlen ("pgrefill_")) == 0) + { + char *inst = key + strlen ("pgrefill_"); + value_t value = { .counter = counter }; + submit_one (inst, "vmpage_action", "refill", value); + } + else if (strncmp ("pgsteal_", key, strlen ("pgsteal_")) == 0) + { + char *inst = key + strlen ("pgsteal_"); + value_t value = { .counter = counter }; + submit_one (inst, "vmpage_action", "steal", value); + } + else if (strncmp ("pgscan_kswapd_", key, strlen ("pgscan_kswapd_")) == 0) + { + char *inst = key + strlen ("pgscan_kswapd_"); + value_t value = { .counter = counter }; + submit_one (inst, "vmpage_action", "scan_kswapd", value); + } + else if (strncmp ("pgscan_direct_", key, strlen ("pgscan_direct_")) == 0) + { + char *inst = key + strlen ("pgscan_direct_"); + value_t value = { .counter = counter }; + submit_one (inst, "vmpage_action", "scan_direct", value); + } + /* * Page action * @@ -245,7 +276,9 @@ static int vmem_read (void) void module_register (void) { - plugin_register_read ("vmem", vmem_read); + plugin_register_config ("vmem", vmem_config, + config_keys, config_keys_num); + plugin_register_read ("vmem", vmem_read); } /* void module_register */ /* vim: set sw=2 sts=2 ts=8 : */ -- 2.30.2