From ddde85aad33bad5e7f5ed0d21ee082ef1dcda140 Mon Sep 17 00:00:00 2001 From: Aleksei Zakharov Date: Thu, 19 Oct 2017 08:44:28 +0000 Subject: [PATCH] Add comment about "avgtime" usage --- src/ceph.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/ceph.c b/src/ceph.c index 488680ac..bfd95e82 100644 --- a/src/ceph.c +++ b/src/ceph.c @@ -518,6 +518,12 @@ static int parse_keys(char *buffer, size_t buffer_size, const char *key_str) { size_t tmp_size = sizeof(tmp); const char *cut_suffixes[] = {".type", ".avgcount", ".sum", ".avgtime"}; + /* The "avgtime" metric reports ("sum" / "avgcount"), i.e. the average time + * per request since the start of the Ceph daemon. Report this only when the + * user has configured "long running average". Otherwise, use the rate of + * "sum" and "avgcount" to calculate the current latency. + */ + if (buffer == NULL || buffer_size == 0 || key_str == NULL || strlen(key_str) == 0) return EINVAL; -- 2.30.2