%(title)s

From d2be7624bc634835e8b0f1175d727f77fe7f63ab Mon Sep 17 00:00:00 2001 From: richard Date: Thu, 14 Feb 2002 23:39:18 +0000 Subject: [PATCH] . All forms now have "double-submit" protection when Javascript is enabled on the client-side. git-svn-id: http://svn.roundup-tracker.org/svnroot/roundup/trunk@626 57a73879-2fb5-44c3-a270-3262357dd7e2 --- CHANGES.txt | 2 ++ roundup/cgi_client.py | 34 ++++++++++++++++++++++++++++------ roundup/htmltemplate.py | 13 ++++++++----- 3 files changed, 38 insertions(+), 11 deletions(-) diff --git a/CHANGES.txt b/CHANGES.txt index 9a2ee92..a14d0e5 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -11,6 +11,8 @@ Fixed: . mailgw checks encoding on first part too. . #511586 ] unittest FAIL: testReldate_date . Added a uniquely Roundup header to email, "X-Roundup-Name" + . All forms now have "double-submit" protection when Javascript is enabled + on the client-side. 2002-01-24 - 0.4.0 diff --git a/roundup/cgi_client.py b/roundup/cgi_client.py index aea9d1d..ad521c4 100644 --- a/roundup/cgi_client.py +++ b/roundup/cgi_client.py @@ -15,7 +15,7 @@ # BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE, # SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS. # -# $Id: cgi_client.py,v 1.100 2002-01-16 07:02:57 richard Exp $ +# $Id: cgi_client.py,v 1.101 2002-02-14 23:39:18 richard Exp $ __doc__ = """ WWW request handler (also used in the stand-alone server). @@ -80,6 +80,20 @@ class Client: if self.debug: self.headers_sent = headers + single_submit_script = ''' + +''' + def pagehead(self, title, message=None): url = self.env['SCRIPT_NAME'] + '/' machine = self.env['SERVER_NAME'] @@ -113,10 +127,12 @@ class Client: ''') else: add_links = '' + single_submit_script = self.single_submit_script self.write(_(''' %(title)s +%(single_submit_script)s %(message)s @@ -348,9 +364,9 @@ class Client: if self.nodeid: cl = self.db.classes[self.classname] l = cl.get(self.nodeid, 'nosy') - if assignedto_id in l: - return - props['nosy'] = l + if assignedto_id in l: + return + props['nosy'] = l else: props['nosy'] = [] if assignedto_id not in props['nosy']: @@ -746,7 +762,7 @@ class Client: self.write(_('''

- + @@ -770,7 +786,7 @@ class Client:

- + @@ -1079,10 +1095,12 @@ class ExtendedClient(Client): ''') else: add_links = '' + single_submit_script = self.single_submit_script self.write(_('''%(title)s +%(single_submit_script)s %(message)s

Existing User Login
Login name:
New User Registration
marked items are optional...
Name:

@@ -1182,6 +1200,10 @@ def parsePropsFromForm(db, cl, form, nodeid=0): # # $Log: not supported by cvs2svn $ +# Revision 1.100 2002/01/16 07:02:57 richard +# . lots of date/interval related changes: +# - more relaxed date format for input +# # Revision 1.99 2002/01/16 03:02:42 richard # #503793 ] changing assignedto resets nosy list # diff --git a/roundup/htmltemplate.py b/roundup/htmltemplate.py index c4f8866..e913dc2 100644 --- a/roundup/htmltemplate.py +++ b/roundup/htmltemplate.py @@ -15,7 +15,7 @@ # BASIS, AND THERE IS NO OBLIGATION WHATSOEVER TO PROVIDE MAINTENANCE, # SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS. # -# $Id: htmltemplate.py,v 1.71 2002-01-23 06:15:24 richard Exp $ +# $Id: htmltemplate.py,v 1.72 2002-02-14 23:39:18 richard Exp $ __doc__ = """ Template engine. @@ -708,7 +708,7 @@ class IndexTemplate(TemplateFunctions): # display the filter section if (show_display_form and self.instance.FILTER_POSITION in ('top and bottom', 'top')): - w('\n'%self.classname) + w('\n'%self.classname) self.filter_section(filter_template, filter, columns, group, all_filters, all_columns, show_customization) # make sure that the sorting doesn't get lost either @@ -790,7 +790,7 @@ class IndexTemplate(TemplateFunctions): # display the filter section if (show_display_form and hasattr(self.instance, 'FILTER_POSITION') and self.instance.FILTER_POSITION in ('top and bottom', 'bottom')): - w('\n'%self.classname) + w('\n'%self.classname) self.filter_section(filter_template, filter, columns, group, all_filters, all_columns, show_customization) # make sure that the sorting doesn't get lost either @@ -1000,7 +1000,7 @@ class ItemTemplate(TemplateFunctions): # designators... w = self.client.write - w(''%( + w(''%( self.classname, nodeid)) s = open(os.path.join(self.templates, self.classname+'.item')).read() replace = ItemTemplateReplace(self.globals, locals(), self.cl, nodeid) @@ -1030,7 +1030,7 @@ class NewItemTemplate(TemplateFunctions): s = open(os.path.join(self.templates, c+'.newitem')).read() except IOError: s = open(os.path.join(self.templates, c+'.item')).read() - w(''%c) + w(''%c) for key in form.keys(): if key[0] == ':': value = form[key].value @@ -1043,6 +1043,9 @@ class NewItemTemplate(TemplateFunctions): # # $Log: not supported by cvs2svn $ +# Revision 1.71 2002/01/23 06:15:24 richard +# real (non-string, duh) sorting of lists by node id +# # Revision 1.70 2002/01/23 05:47:57 richard # more HTML template cleanup and unit tests # -- 2.30.2