From ced7b828fadbf3d6de49d75392f1516b4ceb4491 Mon Sep 17 00:00:00 2001 From: Andreas Ericsson Date: Thu, 30 Nov 2006 12:28:28 +0100 Subject: [PATCH] ls-files: Give hints when errors happen. Without this patch "git commit file.c file2.c" produces the not so stellar output: error: pathspec 'file.c' did not match any. error: pathspec 'file2.c' did not match any. With this patch, the output is changed to: error: pathspec 'file.c' did not match any file(s) known to git. error: pathspec 'file2.c' did not match any file(s) known to git. Did you forget to 'git add'? Signed-off-by: Andreas Ericsson Signed-off-by: Junio C Hamano --- builtin-ls-files.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/builtin-ls-files.c b/builtin-ls-files.c index ad8c41e73..bc79ce40f 100644 --- a/builtin-ls-files.c +++ b/builtin-ls-files.c @@ -487,10 +487,14 @@ int cmd_ls_files(int argc, const char **argv, const char *prefix) for (num = 0; pathspec[num]; num++) { if (ps_matched[num]) continue; - error("pathspec '%s' did not match any.", + error("pathspec '%s' did not match any file(s) known to git.", pathspec[num] + prefix_offset); errors++; } + + if (errors) + fprintf(stderr, "Did you forget to 'git add'?\n"); + return errors ? 1 : 0; } -- 2.30.2