From c9bc159d7f41e2916830b05529c1ce06a81d975f Mon Sep 17 00:00:00 2001 From: Paul T Darga Date: Thu, 8 Jun 2006 14:14:47 -0400 Subject: [PATCH] check for error return from fork() Trivial fixup for fork() callsites which do not check for errors. Signed-off-by: Paul T Darga Signed-off-by: Junio C Hamano --- connect.c | 2 ++ imap-send.c | 6 +++++- rsh.c | 6 +++++- 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/connect.c b/connect.c index eca94f754..52d709e58 100644 --- a/connect.c +++ b/connect.c @@ -657,6 +657,8 @@ int git_connect(int fd[2], char *url, const char *prog) if (pipe(pipefd[0]) < 0 || pipe(pipefd[1]) < 0) die("unable to create pipe pair for communication"); pid = fork(); + if (pid < 0) + die("unable to fork"); if (!pid) { snprintf(command, sizeof(command), "%s %s", prog, sq_quote(path)); diff --git a/imap-send.c b/imap-send.c index 52e2400b5..285ad29af 100644 --- a/imap-send.c +++ b/imap-send.c @@ -924,6 +924,7 @@ imap_open_store( imap_server_conf_t *srvc ) struct hostent *he; struct sockaddr_in addr; int s, a[2], preauth; + pid_t pid; ctx = xcalloc( sizeof(*ctx), 1 ); @@ -941,7 +942,10 @@ imap_open_store( imap_server_conf_t *srvc ) exit( 1 ); } - if (fork() == 0) { + pid = fork(); + if (pid < 0) + _exit( 127 ); + if (!pid) { if (dup2( a[0], 0 ) == -1 || dup2( a[0], 1 ) == -1) _exit( 127 ); close( a[0] ); diff --git a/rsh.c b/rsh.c index d66526941..07166addd 100644 --- a/rsh.c +++ b/rsh.c @@ -48,6 +48,7 @@ int setup_connection(int *fd_in, int *fd_out, const char *remote_prog, int sizen; int of; int i; + pid_t pid; if (!strcmp(url, "-")) { *fd_in = 0; @@ -91,7 +92,10 @@ int setup_connection(int *fd_in, int *fd_out, const char *remote_prog, if (socketpair(AF_UNIX, SOCK_STREAM, 0, sv)) return error("Couldn't create socket"); - if (!fork()) { + pid = fork(); + if (pid < 0) + return error("Couldn't fork"); + if (!pid) { const char *ssh, *ssh_basename; ssh = getenv("GIT_SSH"); if (!ssh) ssh = "ssh"; -- 2.30.2