From c8400d9ef57dc68925d93d0cb9f1777396b380e2 Mon Sep 17 00:00:00 2001 From: "Hunter, D. Seth" Date: Tue, 30 Jun 2009 20:24:47 -0400 Subject: [PATCH] http-push: fix xml_entities() string parsing overrun xml_entities() in http-push.c did not properly stop at the end of the string being examined, which would occasionally cause nonsense to be appended to escaped URL strings and result in failed DAV XML queries Signed-off-by: Seth Hunter Signed-off-by: Junio C Hamano --- http-push.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/http-push.c b/http-push.c index 8cc8ee0df..00e83dcec 100644 --- a/http-push.c +++ b/http-push.c @@ -193,6 +193,8 @@ static char *xml_entities(char *s) case '&': strbuf_addstr(&buf, "&"); break; + case 0: + return strbuf_detach(&buf, NULL); } s++; } -- 2.30.2