From c82a22c39cbc32576f64f5c6b3f24b99ea8149c7 Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Tue, 16 May 2006 17:18:22 -0700 Subject: [PATCH] merge-base: Clarify the comments on post processing. The comment fooled myself believing that we still had an unsolved horizon effect. Signed-off-by: Junio C Hamano --- merge-base.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/merge-base.c b/merge-base.c index f0dc06ef5..4856ca01c 100644 --- a/merge-base.c +++ b/merge-base.c @@ -82,8 +82,9 @@ static struct commit *interesting(struct commit_list *list) * commit B. * * - * Another pathological example how this thing can fail to mark an ancestor - * of a merge base as UNINTERESTING without the postprocessing phase. + * Another pathological example how this thing used to fail to mark an + * ancestor of a merge base as UNINTERESTING before we introduced the + * postprocessing phase (mark_reachable_commits). * * 2 * H @@ -118,7 +119,9 @@ static struct commit *interesting(struct commit_list *list) * D7 2 3 7 7 3 2 1 2 * E7 2 3 7 7 7 2 1 2 * - * and we end up showing E as an interesting merge base. + * and we ended up showing E as an interesting merge base. + * The postprocessing phase re-injects C and continues traversal + * to contaminate D and E. */ static int show_all = 0; -- 2.30.2