From c35dfe858991ee1969870d2da9337a1da567157e Mon Sep 17 00:00:00 2001 From: Linus Torvalds Date: Sun, 24 Apr 2005 14:22:09 -0700 Subject: [PATCH] Verify that the object type matches for tree/commit objects even before parsing. The type doesn't come from the parsing, the type also has to match the usage. --- commit.c | 2 +- tree.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/commit.c b/commit.c index c0dd689ea..c6fdfd491 100644 --- a/commit.c +++ b/commit.c @@ -15,7 +15,7 @@ struct commit *lookup_commit(unsigned char *sha1) ret->object.type = commit_type; return ret; } - if (obj->parsed && obj->type != commit_type) { + if (obj->type != commit_type) { error("Object %s is a %s, not a commit", sha1_to_hex(sha1), obj->type); return NULL; diff --git a/tree.c b/tree.c index 23476da7d..3537c1155 100644 --- a/tree.c +++ b/tree.c @@ -80,7 +80,7 @@ struct tree *lookup_tree(unsigned char *sha1) ret->object.type = tree_type; return ret; } - if (obj->parsed && obj->type != tree_type) { + if (obj->type != tree_type) { error("Object %s is a %s, not a tree", sha1_to_hex(sha1), obj->type); return NULL; -- 2.30.2